From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#9919: 24.0.91; font-lock broken in dired Date: Mon, 31 Oct 2011 15:29:05 -0700 Message-ID: <14743DC722C642EC9D87D0FAA95ECD27@us.oracle.com> References: <1161A09A8D6E494CBF91D53B99D5FBC2@us.oracle.com> <02C44A1DAC5C497CAD108EF825D585A8@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1320100197 21740 80.91.229.12 (31 Oct 2011 22:29:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Oct 2011 22:29:57 +0000 (UTC) To: <9919@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 31 23:29:53 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0Mb-0003Pb-Gm for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Oct 2011 23:29:53 +0100 Original-Received: from localhost ([::1]:40769 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0Mb-0003X4-14 for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Oct 2011 18:29:53 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:34903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0MX-0003Wm-LR for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:29:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL0MW-0001eQ-Jo for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:29:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL0MW-0001eG-IC for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:29:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RL0Of-0001qt-Ty for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2011 18:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2011 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9919 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9919-submit@debbugs.gnu.org id=B9919.13201002837072 (code B ref 9919); Mon, 31 Oct 2011 22:32:01 +0000 Original-Received: (at 9919) by debbugs.gnu.org; 31 Oct 2011 22:31:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0O2-0001q1-UB for submit@debbugs.gnu.org; Mon, 31 Oct 2011 18:31:23 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RL0O1-0001pu-HZ for 9919@debbugs.gnu.org; Mon, 31 Oct 2011 18:31:22 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9VMT61I026358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <9919@debbugs.gnu.org>; Mon, 31 Oct 2011 22:29:07 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9VMT5OF022503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <9919@debbugs.gnu.org>; Mon, 31 Oct 2011 22:29:06 GMT Original-Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9VMSxh8013707 for <9919@debbugs.gnu.org>; Mon, 31 Oct 2011 17:29:00 -0500 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Oct 2011 15:28:59 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <02C44A1DAC5C497CAD108EF825D585A8@us.oracle.com> Thread-Index: AcyX32v0cjDKgpEgRy2pUVpARhB4ygAOP9JQAACTrkA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090207.4EAF2133.0058,ss=1,re=0.000,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 31 Oct 2011 18:32:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53373 Archived-At: > If this user-visible change is intended, then please (a) > update the doc to explain it, and (b) mention the change in NEWS. Whatever the motivation behind this change (assuming it was intentional), the effect is that font-locking now gets done _twice_ when someone modifies `font-lock-defaults', because of the need to call `font-lock-refresh-defaults'. In my case, this happens each time a Dired buffer is visited. (Likewise buffer menu and finder and...) This is a waste of time. It should be possible to simply update `font-lock-defaults' (e.g. in a mode hook) and have font-locking be done only once, using the updated defaults. Why impose double font-locking? Why should any initial font-locking with the wrong defaults followed by "refreshing" to the right ones be needed? This apparently was not needed in the past. It was such a simple idiom: (set (make-local-variable 'font-lock-defaults) '(nil t nil nil nil (font-lock-fontify-region-function . browse-kill-ring-fontify-region))) (setq font-lock-defaults '(buffer-menu-font-lock-keywords t)) (setq font-lock-defaults '(finder-font-lock-keywords nil nil (("+-*/.<>=!?$%_&~^:@" . "w")) nil)) (set (make-local-variable 'font-lock-defaults) '(compilation-mode-font-lock-keywords t)) ... On n'arrete pas le progres...