From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.bugs Subject: bug#24378: [PATCH 1/6] =?UTF-8?Q?Don=E2=80=99t?= use FETCH_MULTIBYTE_CHAR when advancing index Date: Tue, 6 Sep 2016 15:31:29 +0200 Message-ID: <1473168694-13605-1-git-send-email-mina86@mina86.com> References: <1473168498-13194-1-git-send-email-mina86@mina86.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473169056 1581 195.159.176.226 (6 Sep 2016 13:37:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2016 13:37:36 +0000 (UTC) To: 24378@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 15:37:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhGZ8-0008E3-Nv for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 15:37:30 +0200 Original-Received: from localhost ([::1]:33477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGZ6-0004Xi-Ay for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 09:37:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGTu-0000Bt-QP for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 09:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhGTr-0007FS-3y for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 09:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGTr-0007FO-0M for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 09:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bhGTq-0005vj-Sw for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 09:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michal Nazarewicz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2016 13:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24378-submit@debbugs.gnu.org id=B24378.147316870922724 (code B ref 24378); Tue, 06 Sep 2016 13:32:02 +0000 Original-Received: (at 24378) by debbugs.gnu.org; 6 Sep 2016 13:31:49 +0000 Original-Received: from localhost ([127.0.0.1]:50997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhGTc-0005uI-Ri for submit@debbugs.gnu.org; Tue, 06 Sep 2016 09:31:49 -0400 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:38712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhGTb-0005tq-4s for 24378@debbugs.gnu.org; Tue, 06 Sep 2016 09:31:47 -0400 Original-Received: by mail-wm0-f47.google.com with SMTP id 1so190061076wmz.1 for <24378@debbugs.gnu.org>; Tue, 06 Sep 2016 06:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ah2kbn09b1VqClKNMWb1mpyIy9vNOfqQNNDpKFhp4U0=; b=GWpv5tx8BbCnd5igPZl0wPRUyPVwt80Q4W5soHjs+feG7KLQPWV+NQVJr9gQjn7drH +rYcO7jqS+EWDWLUsEO6Z5jbbJRnXGNQeQn2DByoQurF6OPISJbYxSTrzNAYBphnzYHI 0O/tdrRkZMHLGSpuUv0EpL7fT7vnwJGDLI0U36d6ZzMUIZneYgMoeGeUHbf4Cy/SCdTO ORir4xGIweGqhRYIGrI7sIC979+0dutZvbdt13/BD6IISlM6kfkCZQTA5Tiwzyuoj4YB O/gyFcy0Yb24TXIPx4lsoENIcWPu7ei1HccCP2UnbeX0GL8JyU4ruKZvhy75k95fMsSd 4DGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ah2kbn09b1VqClKNMWb1mpyIy9vNOfqQNNDpKFhp4U0=; b=mRMd5T1/79ko6S8t4SiVOwRV9PUFFmz3oGg94h1g5aqZaqAJ20dhhjfJ81Pz7LgzHP /D5Mz53Cs8ekZWChQf8cvkSGK+tgdXqhgqo1sGuXL/e86NT6/hEDTJJcQmQQl35EDkGM 6XOC1XHFAeAkNcXcW+L6GaXUrhy2CNh0HmiCzuXzNF1VjTON3CHLw5eGv96qF4vP7LcS fy7lb4jLOdDKxhNKhHgt+t1U1r094i8uI7MxcrPd+Zt5KTEtWJxoYJP0rYbKeXD7+JG9 wq7F+KWeWo1YYMgGnIodq7mL3pbDzjfiQOWyE0HTYHjPh3zKEwdNdsead4YIcDLmsauf tOsg== X-Gm-Message-State: AE9vXwPC2IasuuMCv+4cuo8j7urJX2yBqirQ6PofuKj5XuqMXLueIc338OvgcQ6si36OdcPo X-Received: by 10.194.110.229 with SMTP id id5mr35545280wjb.23.1473168700899; Tue, 06 Sep 2016 06:31:40 -0700 (PDT) Original-Received: from mpn.zrh.corp.google.com ([2620:0:105f:301:c096:945d:4464:fe41]) by smtp.gmail.com with ESMTPSA id c65sm3518684wme.10.2016.09.06.06.31.40 for <24378@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Sep 2016 06:31:40 -0700 (PDT) Original-Received: by mpn.zrh.corp.google.com (Postfix, from userid 126942) id 7B6B41E0280; Tue, 6 Sep 2016 15:31:39 +0200 (CEST) X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1473168498-13194-1-git-send-email-mina86@mina86.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122986 Archived-At: * src/casefiddle.c (casify_region): use STRING_CHAR_AND_LENGTH as a safe alternative to FETCH_MULTIBYTE_CHAR which is documented in src/buffer.h as unsafe when used for advancing index. --- src/casefiddle.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/casefiddle.c b/src/casefiddle.c index 6114a6f..5456eac 100644 --- a/src/casefiddle.c +++ b/src/casefiddle.c @@ -223,10 +223,7 @@ casify_region (enum case_action flag, Lisp_Object b, Lisp_Object e) int c2, len; if (multibyte) - { - c = FETCH_MULTIBYTE_CHAR (start_byte); - len = CHAR_BYTES (c); - } + c = STRING_CHAR_AND_LENGTH (BYTE_POS_ADDR(start_byte), len); else { c = FETCH_BYTE (start_byte); -- 2.8.0.rc3.226.g39d4020