From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#24313: [PATCH] Add tests for dom.el Date: Sun, 28 Aug 2016 18:38:00 +0200 Message-ID: <1472402280.5159.0@smtp.gmail.com> References: <1472235970.16843.0@smtp.gmail.com> <1472374727.3660.0@smtp.gmail.com> <"Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sun, 28 Aug 2016 10:58:47 +0200"> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Trace: blaine.gmane.org 1472402364 10404 195.159.176.226 (28 Aug 2016 16:39:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Aug 2016 16:39:24 +0000 (UTC) Cc: Lars Ingebrigtsen , 24313-done@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 28 18:39:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be376-00026z-8d for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2016 18:39:16 +0200 Original-Received: from localhost ([::1]:39984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be373-0000Hr-Re for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2016 12:39:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be36x-0000Ge-5P for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 12:39:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1be36s-0001Tc-Pn for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 12:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be36s-0001TR-MZ for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 12:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1be36s-00085C-Ij for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 12:39:02 -0400 Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2016 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 24313@debbugs.gnu.org, simenheg@gmail.com, simenheg@gmail.com Original-Received: via spool by 24313-done@debbugs.gnu.org id=D24313.147240229030997 (code D ref 24313); Sun, 28 Aug 2016 16:39:02 +0000 Original-Received: (at 24313-done) by debbugs.gnu.org; 28 Aug 2016 16:38:10 +0000 Original-Received: from localhost ([127.0.0.1]:42973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be362-00083t-FR for submit@debbugs.gnu.org; Sun, 28 Aug 2016 12:38:10 -0400 Original-Received: from mail-lf0-f47.google.com ([209.85.215.47]:33740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be361-00083b-0f for 24313-done@debbugs.gnu.org; Sun, 28 Aug 2016 12:38:09 -0400 Original-Received: by mail-lf0-f47.google.com with SMTP id b199so86378441lfe.0 for <24313-done@debbugs.gnu.org>; Sun, 28 Aug 2016 09:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=hA5ADBwYXHn2i39KW24QXabkQcn/rrxTNu9rYHEPUDw=; b=Njacemsy131ytvAXhrJgWC/9O67SnAR3LSPl7tK+G9MQu2AZWDmdqTRG+cUC6gCNmQ mrrkWC26t6fDFD6UcSRoEU7vdlmZxwDU47fosTlpend8fapqL2t2+fN9BxM1RLeTv4U0 ALy4mxI09+ZbrSCbB9hgodXm7pFBdBuV+dtuT6Zo4WpSFh0isaRzL+RgCLAAuJln4Qlo 4QeR5/SVAu4JmqnMykYTuM3lyepAD9DXI5PoHF6cDmMMa/YoRH9HDfnS73UUtCb3VJca i77wKYfxOvvxkp9+HUrb1pU+O/9G+FU1UwCEDxpXOpl72VD2bToG3kjtKaiy2OW5Y6Lb BkJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=hA5ADBwYXHn2i39KW24QXabkQcn/rrxTNu9rYHEPUDw=; b=dN/rd2uftu0qVxnUe56Zs9EmVDS70pPNmH0ch9Yyb/s9gQhZVinJM2XCXyWdhpsupJ NJEAoxKuvXV0asJYmvZvo+OuKqixFYyukZ0KbXYGGzH3NEXIoY7w/wqKTusfoFhYB2KU 1DT4Ls6GAtysMW7L9TYuSWNmCNmkFRrR/hGY97tKBvQEE8Iyd2O8w5zE7fT8SzNSa5tC i3KygVX/2cvR1NsX/ymryU9zWI5pSsu0ftbJPKdquFVZEo+xzzmSddcf6L5JxUwJqEuL d7xL+HkUeP1MKAdG2PtV65AItplPzwHqwotnA1Y0jyJMzMshXGkEqd+O+tqR3TBwyYA2 syaQ== X-Gm-Message-State: AE9vXwPXAJMu+twXjCzJHV3nkTq8cFA4vLGaMsBRZ2rhmv3JtIrKBKmYefTnJZ0IxRuPzg== X-Received: by 10.25.160.15 with SMTP id j15mr4290720lfe.109.1472402282944; Sun, 28 Aug 2016 09:38:02 -0700 (PDT) Original-Received: from [192.168.100.6] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id s2sm5796125lja.35.2016.08.28.09.38.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Aug 2016 09:38:02 -0700 (PDT) In-Reply-To: <87poottfj9.fsf@gmx.de> X-Mailer: geary/0.11.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122744 Archived-At: On Sun, Aug 28, 2016 at 11:21 AM, Michael Albinus wrote: > It depends. Likely you are right, but sometimes it might be worth to > note also what is NOT covered by a test, or to mention possible side > effects which are tested implicitely. But it is your decision, of > course. I agree with you. I went over the tests once more with this in mind and found one instance which I think was worth a comment, but still think the rest are trivial enough to stand on their own. I've installed the tests with the changes you suggested last time. Thanks again for your time. -- Simen