unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#61245: 29.0.60; Should c-ts-mode-set-style be local by default?
@ 2023-02-03  2:45 Yuan Fu
  2023-02-03  7:41 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Yuan Fu @ 2023-02-03  2:45 UTC (permalink / raw)
  To: 61245



Normally this sort of function only affect the current buffer.
c-set-style only sets the style for the current buffer, too. I wonder if
we should make c-ts-mode-set-style default to local, too?

Yuan





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#61245: 29.0.60; Should c-ts-mode-set-style be local by default?
  2023-02-03  2:45 bug#61245: 29.0.60; Should c-ts-mode-set-style be local by default? Yuan Fu
@ 2023-02-03  7:41 ` Eli Zaretskii
  2023-02-04 23:34   ` Yuan Fu
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2023-02-03  7:41 UTC (permalink / raw)
  To: Yuan Fu; +Cc: 61245

> From: Yuan Fu <casouri@gmail.com>
> Date: Thu, 2 Feb 2023 18:45:31 -0800
> 
> Normally this sort of function only affect the current buffer.
> c-set-style only sets the style for the current buffer, too. I wonder if
> we should make c-ts-mode-set-style default to local, too?

Yes, the style is a buffer-local setting.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#61245: 29.0.60; Should c-ts-mode-set-style be local by default?
  2023-02-03  7:41 ` Eli Zaretskii
@ 2023-02-04 23:34   ` Yuan Fu
  0 siblings, 0 replies; 3+ messages in thread
From: Yuan Fu @ 2023-02-04 23:34 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 61245



> On Feb 2, 2023, at 11:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 2 Feb 2023 18:45:31 -0800
>> 
>> Normally this sort of function only affect the current buffer.
>> c-set-style only sets the style for the current buffer, too. I wonder if
>> we should make c-ts-mode-set-style default to local, too?
> 
> Yes, the style is a buffer-local setting.

Ok, I pushed a change that made c-ts-mode-set-style buffer-local, and added c-ts-mode-set-global-style.

Yuan




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-04 23:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-03  2:45 bug#61245: 29.0.60; Should c-ts-mode-set-style be local by default? Yuan Fu
2023-02-03  7:41 ` Eli Zaretskii
2023-02-04 23:34   ` Yuan Fu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).