From: Michal Nazarewicz <mina86@mina86.com>
To: 23843@debbugs.gnu.org
Subject: bug#23843: [PATCH 1/3] Make ‘delete-trailing-whitespace’ delete spaces after form feed
Date: Sat, 25 Jun 2016 00:14:43 +0200 [thread overview]
Message-ID: <1466806485-15732-1-git-send-email-mina86@mina86.com> (raw)
In-Reply-To: <1466806193-15280-1-git-send-email-mina86@mina86.com>
* lisp/simple.el (delete-trailing-whitespace): Treat form fead as
a non-whitespace character (regradless of whether it’s character syntax
is whitespace) and delete any whitespace following it instead of leaving
lines with form feeds completely unchanged. I.e. a line like "\f " will
now became "\f".
---
etc/NEWS | 6 ++++++
lisp/simple.el | 15 +++++++--------
test/lisp/simple-tests.el | 17 +++++++++++++++--
3 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index b3a044d..e76628a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -187,6 +187,12 @@ questions, with a handy way to display help texts.
'undo', undo the last replacement; bound to 'u'.
'undo-all', undo all replacements; bound to 'U'.
+** 'delete-trailing-whitespace' deletes whitespace after form feed.
+In modes where form feed was treated as a whitespace character,
+'delete-trailing-whitespace' would keep lines containing it unchanged.
+It now deletes whitespace after the last form feed thus behaving the
+same as in modes where the character is not whitespace.
+
\f
* Changes in Specialized Modes and Packages in Emacs 25.2
diff --git a/lisp/simple.el b/lisp/simple.el
index bc3e7b8..ffedbfa 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -602,15 +602,14 @@ delete-trailing-whitespace
(list nil nil))))
(save-match-data
(save-excursion
- (let ((end-marker (copy-marker (or end (point-max))))
- (start (or start (point-min))))
- (goto-char start)
- (while (re-search-forward "\\s-$" end-marker t)
- (skip-syntax-backward "-" (line-beginning-position))
+ (let ((end-marker (copy-marker (or end (point-max)))))
+ (goto-char (or start (point-min)))
+ (with-syntax-table (make-syntax-table (syntax-table))
;; Don't delete formfeeds, even if they are considered whitespace.
- (if (looking-at-p ".*\f")
- (goto-char (match-end 0)))
- (delete-region (point) (match-end 0)))
+ (modify-syntax-entry ?\f "_")
+ (while (re-search-forward "\\s-$" end-marker t)
+ (skip-syntax-backward "-" (line-beginning-position))
+ (delete-region (point) (match-end 0))))
;; Delete trailing empty lines.
(goto-char end-marker)
(when (and (not end)
diff --git a/test/lisp/simple-tests.el b/test/lisp/simple-tests.el
index 40cd1d2..2722544 100644
--- a/test/lisp/simple-tests.el
+++ b/test/lisp/simple-tests.el
@@ -204,7 +204,7 @@ simple-test--transpositions
\f
;;; `delete-trailing-whitespace'
-(ert-deftest simple-delete-trailing-whitespace ()
+(ert-deftest simple-delete-trailing-whitespace--bug-21766 ()
"Test bug#21766: delete-whitespace sometimes deletes non-whitespace."
(defvar python-indent-guess-indent-offset) ; to avoid a warning
(let ((python (featurep 'python))
@@ -219,11 +219,24 @@ simple-test--transpositions
"\n"
"\n"))
(delete-trailing-whitespace)
- (should (equal (count-lines (point-min) (point-max)) 3)))
+ (should (string-equal (buffer-string)
+ (concat "query = \"\"\"WITH filtered AS\n"
+ "WHERE\n"
+ "\"\"\".format(fv_)\n"))))
;; Let's clean up if running interactive
(unless (or noninteractive python)
(unload-feature 'python)))))
+(ert-deftest simple-delete-trailing-whitespace--formfeeds ()
+ "Test formfeeds are not deleted but whitespace past them is."
+ (with-temp-buffer
+ (with-syntax-table (make-syntax-table)
+ (modify-syntax-entry ?\f " ") ; Make sure \f is whitespace
+ (insert " \f \n \f \f \n\nlast\n")
+ (delete-trailing-whitespace)
+ (should (string-equal (buffer-string) " \f\n \f \f\n\nlast\n"))
+ (should (equal ?\s (char-syntax ?\f))))))
+
;;; auto-boundary tests
(ert-deftest undo-auto-boundary-timer ()
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-06-24 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 22:09 bug#23843: [PATCH 0/3] Small `delete-trailing-whitespace' fixes and improvements Michal Nazarewicz
2016-06-24 22:14 ` Michal Nazarewicz [this message]
2016-06-24 22:14 ` bug#23843: [PATCH 2/3] Simplify ‘delete-trailing-whitespace’ by not treating \n as whitespace Michal Nazarewicz
2016-06-24 22:14 ` bug#23843: [PATCH 3/3] Don’t create unnecessary marker in ‘delete-trailing-whitespace’ Michal Nazarewicz
2016-07-04 12:12 ` bug#23843: Small `delete-trailing-whitespace' fixes and improvements Michal Nazarewicz
2016-07-04 16:29 ` Glenn Morris
2016-07-04 22:06 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466806485-15732-1-git-send-email-mina86@mina86.com \
--to=mina86@mina86.com \
--cc=23843@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).