From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#23383: [PATCH] Support completion of color functions in CSS mode Date: Thu, 28 Apr 2016 19:51:37 +0200 Message-ID: <1461865897.9211.0@smtp.gmail.com> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> <20160427201745.09dd0967@ThinkPax> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-hNYYvTG/5IjE3bzLECIV" X-Trace: ger.gmane.org 1461865945 7971 80.91.229.3 (28 Apr 2016 17:52:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Apr 2016 17:52:25 +0000 (UTC) Cc: 23383@debbugs.gnu.org To: Etienne Prud'homme Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 28 19:52:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avq6l-0007z4-0Y for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 19:52:11 +0200 Original-Received: from localhost ([::1]:50439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avq6k-0001O4-Je for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 13:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avq6f-0001KV-TM for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:52:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avq6c-000508-OG for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avq6c-0004zx-LF for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avq6c-0002En-Bw for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2016 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23383-submit@debbugs.gnu.org id=B23383.14618659088577 (code B ref 23383); Thu, 28 Apr 2016 17:52:02 +0000 Original-Received: (at 23383) by debbugs.gnu.org; 28 Apr 2016 17:51:48 +0000 Original-Received: from localhost ([127.0.0.1]:53539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avq6N-0002EH-Un for submit@debbugs.gnu.org; Thu, 28 Apr 2016 13:51:48 -0400 Original-Received: from mail-lf0-f47.google.com ([209.85.215.47]:36441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avq6M-0002Dz-7m for 23383@debbugs.gnu.org; Thu, 28 Apr 2016 13:51:46 -0400 Original-Received: by mail-lf0-f47.google.com with SMTP id u64so92583693lff.3 for <23383@debbugs.gnu.org>; Thu, 28 Apr 2016 10:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=dqWSe0SU+SmYUsbwdRZ6OXomhrmz978F82eD/PRUni8=; b=KRkhniSFzZ9wSFH4IJL9ZTvx/N/kPB4Utfy0urbYPH1HMhJd70PC0CPSAs8c3M2va4 a+Z7dpl6pVvGgi0nNuzALC5LYF+w3QZcBAdD2z09+UNFlc3G0zNOp4c3mXpr7Ju3fBun vzIBAv+bziY0uWYOgXfAB+zQBUgn9WzP6/sZXo7Ecqw3aIYAVh5YlAZnH6lYuBtLW9F7 hI2MJDBjyxGV7CrLc8BtD159YFsFpH/C2IcKnJNABCw2S6ocvzw5C/LeLwYl6qIsNTHZ bc9oV93LknJSjvszjvDpcD2yM/5uIZcotSj6lmnLNdnfHdeEegrlAflBqIv/Uhf7QKc7 JBlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=dqWSe0SU+SmYUsbwdRZ6OXomhrmz978F82eD/PRUni8=; b=FVqZhvI2+rRUoKCErjsV7PtHsmlB9lO2yJyd0HNG6xGAmS0VEZBmuquofBZm4tRhRX YL5InGPQrSMP4N4ktdn/fWJ8fe6qXsZ2RgIVHvmA2qACNkn6OupqWh1UaLJY+c+j753g +Jk74OUYI3uF6zFFu/GU6ucPo7l3NUtjsyRt0Eoz0kTHG1bDhHLSEsanX2xuZ1YEmtj5 fI+rrYMuE1aof9l3n3yM36dKhWPUZaNLPy/F+VtCAX0fa4DKlQb3cOrrH4ffSM1CfHom 0zniObb9X+CMips07Bp2DW2rFiinVwM7/0XCANhzanR6YAdol+Pg1pXdB0n2BHfZ7K09 9Y/Q== X-Gm-Message-State: AOPr4FWg8nh4HtUJ1RGaVOVWm2RlLof82SYvjV13H2nvCrViXUMqmcLl0fO2KhExyvFkRw== X-Received: by 10.25.18.102 with SMTP id h99mr6888827lfi.127.1461865900243; Thu, 28 Apr 2016 10:51:40 -0700 (PDT) Original-Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id mz2sm1832952lbb.18.2016.04.28.10.51.38 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Apr 2016 10:51:39 -0700 (PDT) In-Reply-To: <20160427201745.09dd0967@ThinkPax> X-Mailer: geary/0.10.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117111 Archived-At: --=-hNYYvTG/5IjE3bzLECIV Content-Type: text/plain; charset=utf-8; format=flowed Thanks for the revision, Etienne. There are still a couple of issues that need to be resolved. - I think we should stick to the current CSS Color Module Level 3 recommendation [1]. The functions apart from `rgb()', `rgba()', `hsl()', and `hsla()' are only present in an Editor's Draft. I find no other resources about them, so I don't think we should include them until the new spec becomes at least a Candidate Recommendation. - I think there's little use in completing `#' since it's only one character. - `namedColor' must be changed to `named-color' to match the name of the value class. - The new color names need to be double-checked. For instance I see that `limegreen' has become `limeg een' and `salmon' has become `sa mon'. - The test `css-test-property-values' in test/lisp/textmodes/css-mode-tests.el needs a small update. [1] https://www.w3.org/TR/css3-color/ -- Simen --=-hNYYvTG/5IjE3bzLECIV Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks for the revision, Etienne.

There are s= till a couple of issues that need to be resolved.

= - I think we should stick to the current CSS Color Module Level 3
  recommendation [1]. The functions apart from `rgb()', `rgba()',
  `hsl()', and `hsla()' are only present in an Editor's Draft. = I find no
  other resources about them, so I don't think we = should include them
  until the new spec becomes at least a = Candidate Recommendation.

- I think there's little= use in completing `#' since it's only one
  character.

- `namedColor' must be changed to `named-color' to mat= ch the name of the
  value class.

-= The new color names need to be double-checked. For instance I see that
  `limegreen' has become `limeg een' and `salmon' has become `s= a mon'.

- The test `css-test-property-values' in
  test/lisp/textmodes/css-mode-tests.el needs a small update.=


-- Simen

= --=-hNYYvTG/5IjE3bzLECIV--