Hello Etienne, thanks for the patch.<br><br>On Wed, Apr 27, 2016 at 12:48 AM, Etienne Prud'homme &lt;e.e.f.prudhomme@gmail.com&gt; wrote:<br>
<blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">The attached patch adds completion for CSS color functions such as
`rgb()'. Values were taken from the “CSS Color Module Level 4”. It can
be found at: <a href="https://drafts.csswg.org/css-color/#color-type">https://drafts.csswg.org/css-color/#color-type</a></div></blockquote><div><br></div><div><div>It will be nice to have completion for those new color functions. Some</div><div>feedback regarding the patch follows.</div><div><br></div><div>- In the completion definitions we've tried to stay as close as possible</div><div>&nbsp; to the structure used in the CSS spec. This means that instead of</div><div>&nbsp; introducing `color-functions' we should make `color' complete directly</div><div>&nbsp; to "rgb()", "rgba()", and so on, then `hex-color', `named-color' and</div><div>&nbsp; the literal `currentcolor' (I think we can skip</div><div>&nbsp; `deprecated-system-color'). `named-color' will then contain the</div><div>&nbsp; literal color names like `color' does now.</div><div><br></div><div>- One of the tests in test/lisp/textmodes/css-mode-tests.el needs</div><div>&nbsp; updating. To see this, run `make lisp/textmodes/css-mode-tests' from</div><div>&nbsp; the test directory.</div><div><br></div><div>- Please wrap lines around column 70 or so to stay in line with the rest</div><div>&nbsp; of the file.</div></div><br><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">As a sidenote, how should we handle functions? Since they use
parentheses, the point is going to be outside of parentheses.

Eg.
rgba()*
      ^(point)</div></blockquote><div><br></div><div>True, I'm not sure how to best solve it.</div><br><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">Also, should we include the parameters number?</div></blockquote><br><div><div>I think that's rather a job for something like ElDoc (I'm currently</div><div>working on adding ElDoc support to CSS mode).</div><div><br></div><div>-- Simen</div></div>