bug#23229: 24.5; Wrong indentation in SCSS files (CSS mode) when using nested interpolated selectors

bug#23229: 24.5; Wrong indentation in SCSS files (CSS mode) when using nested interpolated selectors

[Artemiy Solopov]

[-- Attachment #1: Type: text/plain, Size: 3490 bytes --]

Steps to reproduce (after emacs -Q):

* Visit an SCSS file with nested interpolated selectors, like the 
attached one.
* Set CSS mode with M-x css-mode
* Indent the file (for example, mark the whole file and run M-x 
indent-for-tab)
* Notice the indentation of the "background: $col;" line. As it is now, 
it's indented at the same level as the previous selector line, and the 
closing brace after this line is indented one level shallower. The 
desired behaviour would be to indent the "background: $col;" line one 
level deeper than the selector, and the closing brace the same as the 
selector.



In GNU Emacs 24.5.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.27)
of 2015-10-08 on art-solopov
Windowing system distributor `The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04.4 LTS

Configured using:
`configure --prefix=3D/home/user/built-software/emacs
--with-x-toolkit=3Dgtk2'

Important settings:
value of $LANG: ru_RU.UTF-8
value of $XMODIFIERS: @im=3Dibus
locale-coding-system: utf-8-unix

Major mode: CSS

Minor modes in effect:
tooltip-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t

Recent messages:
Checking 151 files in 
/home/user/built-software/emacs/share/emacs/24.5/lisp=
/emacs-lisp...
Checking 24 files in 
/home/user/built-software/emacs/share/emacs/24.5/lisp/=
cedet...
Checking 57 files in 
/home/user/built-software/emacs/share/emacs/24.5/lisp/=
calendar...
Checking 87 files in 
/home/user/built-software/emacs/share/emacs/24.5/lisp/=
calc...
Checking 111 files in 
/home/user/built-software/emacs/share/emacs/24.5/lisp=
/obsolete...
Checking for load-path shadows...done
C-c <down> is undefined
Auto-saving...done
C-c <down> is undefined
Making completion list... [2 times]

Load-path shadows:
None found.

Features:
(help-mode pp shadow sort gnus-util mail-extr emacsbug message
format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils css-mode smie
time-date cyril-util tooltip electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process gfilenotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)

Memory information:
((conses 16 74708 7308)
(symbols 48 17743 0)
(miscs 40 50 200)
(strings 32 10083 4084)
(string-bytes 1 282357)
(vectors 16 10142)
(vector-slots 8 394794 13313)
(floats 8 66 304)
(intervals 56 238 29)
(buffers 960 15)
(heap 1024 34180 2009))

--=20
=D0=90=D1=80=D1=82=D0=B5=D0=BC=D0=B8=D0=B9 =D0=A1=D0=BE=D0=BB=D0=BE=D0=BF=
=D0=BE=D0=B2


[-- Attachment #2: spl.scss --]
[-- Type: text/plain, Size: 153 bytes --]

$cols: (#4FC, rgba(#AA1, .6), #E67);

@for $i from 1 through 3 {
  $col: nth($cols, $i);

  .legend {
    .item.#{$i} {
    background: $col;
  }
  }
}

bug#23229: 24.5; Wrong indentation in SCSS files (CSS mode) when using nested interpolated selectors

[Simen Heggestøyl]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

Hello, Artemiy, thanks for the report.

Are you seeing this with the version of CSS mode shipped with Emacs
24.5? The file you provided is indented as expected for me, using CSS
mode from Emacs 25.

Could you try that and see if it works like you expect?

-- Simen

[-- Attachment #2: Type: text/html, Size: 367 bytes --]

bug#23229: 24.5; Wrong indentation in SCSS files (CSS mode) when using nested interpolated selectors

[Simen Heggestøyl]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

On Wed, Apr 6, 2016 at 6:09 PM, Artemiy Solopov <art-solopov@yandex.ru> 
wrote:
> Yup, I just cloned the upstream from Savanna and it works perfectly! 
> Thank you very much! Sorry for bothering you.

Good to hear!

-- Simen

[-- Attachment #2: Type: text/html, Size: 362 bytes --]