From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: "Saulius Menkevičius" <saulius.menkevicius@gmail.com>,
jostein@kjonigsen.net
Cc: Alan Mackenzie <acm@muc.de>, Ingo Lohmar <i.lohmar@gmail.com>,
23053@debbugs.gnu.org
Subject: bug#23053: 25.0.92; error in cc-mode when editing C# file with a generic class inheritance
Date: Tue, 22 Mar 2016 11:21:15 +0100 [thread overview]
Message-ID: <1458642075.3844218.556219010.3D599124@webmail.messagingengine.com> (raw)
In-Reply-To: <m2y49bv6p9.fsf@gmail.com>
On Mon, Mar 21, 2016, at 10:53 PM, Saulius Menkevičius wrote:
> Actually, removing and installing csharp-mode from package manager with
> the latest emacs-25 fixed the issue for me. And I could not replicate
> the same problem in Java mode.
>
> --
> Saulius Menkevičius (saulius.menkevicius@gmail.com)
I completely nuked my previous Emacs build (and personal setup) and
tried setting everything up from scratch again.
I second your findings: Using the emacs-25 branch everything works fine.
If I base my build on Emacs git master though, I still get all of the
problems described above.
There are currently differences between master and emacs-25 and I guess
these changes needs to be vetted better:
> $ git checkout emacs-25
> $ git diff master -- lisp/progmodes/cc-mode.el
> diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el
> index 9ebe6f7..738870b 100644
> --- a/lisp/progmodes/cc-mode.el
> +++ b/lisp/progmodes/cc-mode.el
> @@ -141,18 +141,7 @@
> ;; derived-mode-ex.el>.
>
> (defun c-leave-cc-mode-mode ()
> - (when c-buffer-is-cc-mode
> - (save-restriction
> - (widen)
> - (c-save-buffer-state ()
> - (c-clear-char-properties (point-min) (point-max) 'category)
> - (c-clear-char-properties (point-min) (point-max) 'syntax-table)
> - (c-clear-char-properties (point-min) (point-max) 'c-is-sws)
> - (c-clear-char-properties (point-min) (point-max) 'c-in-sws)
> - (c-clear-char-properties (point-min) (point-max) 'c-type)
> - (if (c-major-mode-is 'awk-mode)
> - (c-clear-char-properties (point-min) (point-max) 'c-awk-NL-prop))))
> - (setq c-buffer-is-cc-mode nil)))
> + (setq c-buffer-is-cc-mode nil))
>
> (defun c-init-language-vars-for (mode)
> "Initialize the language variables for one of the language modes
> @@ -1493,7 +1482,6 @@ c-mode
> abbrev-mode t)
> (use-local-map c-mode-map)
> (c-init-language-vars-for 'c-mode)
> - (c-make-noise-macro-regexps)
> (c-make-macro-with-semi-re) ; matches macro names whose expansion ends with ;
> (c-common-init 'c-mode)
> (easy-menu-add c-c-menu)
> @@ -1549,7 +1537,6 @@ c++-mode
> abbrev-mode t)
> (use-local-map c++-mode-map)
> (c-init-language-vars-for 'c++-mode)
> - (c-make-noise-macro-regexps)
> (c-make-macro-with-semi-re) ; matches macro names whose expansion ends with ;
> (c-common-init 'c++-mode)
> (easy-menu-add c-c++-menu)
> @@ -1603,7 +1590,6 @@ objc-mode
> abbrev-mode t)
> (use-local-map objc-mode-map)
> (c-init-language-vars-for 'objc-mode)
> - (c-make-noise-macro-regexps)
> (c-make-macro-with-semi-re) ; matches macro names whose expansion ends with ;
> (c-common-init 'objc-mode)
> (easy-menu-add c-objc-menu)
Anything you can look into, Alan?
--
Jostein Kjønigsen
jostein@kjonigsen.net / jostein@secure.kjonigsen.net
next prev parent reply other threads:[~2016-03-22 10:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 9:07 bug#23053: 25.0.92; error in cc-mode when editing C# file with a generic class inheritance Saulius Menkevičius
2016-03-18 21:13 ` bug#23053: followup on 23053 Saulius Menkevičius
2016-03-18 21:33 ` bug#23053: 25.0.92; error in cc-mode when editing C# file with a generic class inheritance Jostein Kjønigsen
2016-03-18 23:08 ` Ingo Lohmar
2016-03-19 7:29 ` Jostein Kjønigsen
2016-03-19 8:27 ` Jostein Kjønigsen
2016-03-21 12:26 ` Alan Mackenzie
2016-03-21 12:45 ` Jostein Kjønigsen
2016-03-21 21:53 ` Saulius Menkevičius
2016-03-22 10:21 ` Jostein Kjønigsen [this message]
2016-03-25 18:54 ` Alan Mackenzie
2016-03-26 7:26 ` Jostein Kjønigsen
2016-03-26 10:48 ` Alan Mackenzie
2016-03-19 10:05 ` Ingo Lohmar
2016-03-19 15:00 ` jostein
2016-03-19 17:54 ` Jostein Kjønigsen
2016-03-20 20:57 ` Jostein Kjønigsen
[not found] ` <mailman.7741.1458315553.843.bug-gnu-emacs@gnu.org>
2016-03-19 13:14 ` Alan Mackenzie
2016-03-19 14:15 ` Saulius Menkevičius
2016-03-20 21:16 ` Alan Mackenzie
2016-03-21 21:51 ` Saulius Menkevičius
2016-03-26 10:55 ` Alan Mackenzie
2016-03-26 10:59 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458642075.3844218.556219010.3D599124@webmail.messagingengine.com \
--to=jostein@secure.kjonigsen.net \
--cc=23053@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=i.lohmar@gmail.com \
--cc=jostein@kjonigsen.net \
--cc=saulius.menkevicius@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).