From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#19946: 24.4; js-mode, indentation Date: Sun, 20 Mar 2016 20:47:44 +0100 Message-ID: <1458503264.1747260.554579266.3BC0CBEA@webmail.messagingengine.com> References: <1424858977.3139392.232164745.05CFB51D@webmail.messagingengine.com> <87r3f6unew.fsf@gmail.com> <6420dbed-587e-87e1-e167-73359a65bf6b@yandex.ru> <1458500460.1739128.554550090.7C772DCA@webmail.messagingengine.com> <008e3b7c-4867-ce5b-153c-83ea3a31030d@yandex.ru> Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1458503301 3219 80.91.229.3 (20 Mar 2016 19:48:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2016 19:48:21 +0000 (UTC) Cc: 19946@debbugs.gnu.org, dan.colascione@gmail.com To: Dmitry Gutov , jostein@kjonigsen.net, Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 20 20:48:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahjKc-00013b-4l for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Mar 2016 20:48:10 +0100 Original-Received: from localhost ([::1]:54263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahjKb-0000wv-Gf for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Mar 2016 15:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahjKX-0000wq-Cd for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 15:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahjKU-00066P-63 for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 15:48:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahjKT-00066G-SZ for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 15:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ahjKT-0004Mn-My for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2016 15:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2016 19:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19946-submit@debbugs.gnu.org id=B19946.145850326616752 (code B ref 19946); Sun, 20 Mar 2016 19:48:01 +0000 Original-Received: (at 19946) by debbugs.gnu.org; 20 Mar 2016 19:47:46 +0000 Original-Received: from localhost ([127.0.0.1]:55855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahjKE-0004M8-ED for submit@debbugs.gnu.org; Sun, 20 Mar 2016 15:47:46 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahjKD-0004M1-4o for 19946@debbugs.gnu.org; Sun, 20 Mar 2016 15:47:45 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id F3B6C21F56 for <19946@debbugs.gnu.org>; Sun, 20 Mar 2016 15:47:44 -0400 (EDT) Original-Received: from web5 ([10.202.2.215]) by compute4.internal (MEProxy); Sun, 20 Mar 2016 15:47:44 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:from:in-reply-to:message-id:mime-version :references:reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=I0zKGZIxFvIW8Hyt0IxCTqNHxdg=; b=h/uFYq5/lK+Aw9GgMhe4ny1kw1kf MsnWmRybXq0YBtiSpzBCwzcZNKko7vzYN8gyqwBGvieoG7X8V2gmWjTkYk2I592F d1F5/EcoQkD3xRfdbkyqusXgNbwRGAZ3pqB+P/+ZnXzvmJ3d9mAk/AGOZyVmDgmJ dtWCuGJh4S0Bf9E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=I0zKGZ IxFvIW8Hyt0IxCTqNHxdg=; b=ZHYnIbqNRzgTsHNKrYSKRb+Hb6XaqPj6yTA3qV WdU4600f2UzSCz//mfI0EwaDRWxxnkxc7hcQE9GrJqz6pnjbmi1bY+dKBGhYF8Zk BQX91v36LI+bHK/t4V3luaomx/kUbwclO4LpOsSo4wqPR6ryGn62ZMH4JTY1BaUj MdBsQ= Original-Received: by web5.nyi.internal (Postfix, from userid 99) id BA082A6CD54; Sun, 20 Mar 2016 15:47:44 -0400 (EDT) X-Sasl-Enc: yV16zW0i+CBW5FjIy95GzVTg9kDAM3XO3Xr7iXa2SgzS 1458503264 X-Mailer: MessagingEngine.com Webmail Interface - ajax-872772a7 In-Reply-To: <008e3b7c-4867-ce5b-153c-83ea3a31030d@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115174 Archived-At: On Sun, Mar 20, 2016, at 08:18 PM, Dmitry Gutov wrote: > On 03/20/2016 09:01 PM, Jostein Kj=F8nigsen wrote: >=20 > It's not an argument, it's an observation: clearly we, as a project,=20 > haven't made a decision to properly support mixed-newline files. Fair enough. >> By following the cardinal rule of good software, that is produce the >> least amont of astonishment, cc-mode does what's right: it produces the >> expected outcome, no matter what kind of file it's working with. >=20 > Hmm, does this help? >=20 > diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el > index 15a52ba..dffdb77 100644 > --- a/lisp/progmodes/js.el > +++ b/lisp/progmodes/js.el > @@ -578,6 +578,7 @@ js-mode-syntax-table > (c-populate-syntax-table table) > (modify-syntax-entry ?$ "_" table) > (modify-syntax-entry ?` "\"" table) > + (modify-syntax-entry ?\C-M " " table) > table) > "Syntax table for `js-mode'.") >=20 That works for me, at least in js-mode. While not a general solution to all weird files one might encounter while working in Emacs, it at least makes js-files behave as expected. And in a fairly reusable manner too: I can copy this code and I'm home free. Would pushing this up to cc-mode's c-populate-syntax-table function also be considered an option? Or does that just sound on overall way too risky? --=20 Jostein Kj=F8nigsen jostein@kjonigsen.net / jostein@secure.kjonigsen.net