From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50344: C-x v keybinding for vc-print-branch-log Date: Thu, 7 Oct 2021 03:47:32 +0300 Message-ID: <14527e3e-964f-50f5-acf2-4f0390b2baef@yandex.ru> References: <87mtoux1ha.fsf@mail.linkov.net> <1f39aa34-6626-3d0b-d764-2c9908787d99@yandex.ru> <87o8998wf4.fsf@mail.linkov.net> <84e4e2ef-6c8d-3645-9e1e-3129981dd45f@yandex.ru> <875yvgvohe.fsf@gnus.org> <87y28burzd.fsf@mail.linkov.net> <87o896kt5k.fsf@gnus.org> <87sfyhj3qw.fsf@mail.linkov.net> <87zgsoctoc.fsf@gnus.org> <59a05468-2309-c6e7-5a2a-51426c208966@yandex.ru> <87tuiv4hvc.fsf@gnus.org> <87fsudsngq.fsf@mail.linkov.net> <85dfa858-091b-80df-b9d1-bd1136c2b91e@yandex.ru> <878rz72wqg.fsf@mail.linkov.net> <30b7d470-26b1-7d7a-2d43-9e85059c1fc5@yandex.ru> <87y276qyqe.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 50344@debbugs.gnu.org, Lars Ingebrigtsen , Filipp Gunbin , "Eric S. Raymond" To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 07 02:48:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYHa0-0008sP-Gb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 02:48:12 +0200 Original-Received: from localhost ([::1]:52770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYHZy-0005wV-8i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Oct 2021 20:48:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYHZq-0005wL-Nb for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 20:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYHZq-00035q-G8 for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 20:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYHZq-0007BT-86 for bug-gnu-emacs@gnu.org; Wed, 06 Oct 2021 20:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 00:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50344 X-GNU-PR-Package: emacs Original-Received: via spool by 50344-submit@debbugs.gnu.org id=B50344.163356766327589 (code B ref 50344); Thu, 07 Oct 2021 00:48:02 +0000 Original-Received: (at 50344) by debbugs.gnu.org; 7 Oct 2021 00:47:43 +0000 Original-Received: from localhost ([127.0.0.1]:45724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYHZW-0007Ar-Vr for submit@debbugs.gnu.org; Wed, 06 Oct 2021 20:47:43 -0400 Original-Received: from mail-lf1-f43.google.com ([209.85.167.43]:33766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYHZU-0007A9-26 for 50344@debbugs.gnu.org; Wed, 06 Oct 2021 20:47:41 -0400 Original-Received: by mail-lf1-f43.google.com with SMTP id y23so17831087lfb.0 for <50344@debbugs.gnu.org>; Wed, 06 Oct 2021 17:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tzKLNPWLykr9/aBbnysaMFDhv/d07ViTwAW8uENxWOc=; b=S+RcG/QHjYfJEHl3l3dEhZCQEWu6Z40ZeyWV2uA6pfUjN6WPeIFu0VlIo2lx24zi44 6S5FGxt0NNjEmJ6tnEHxK2w1F9DrEcTsncgjq2SKTVc0nWWCP24UIfa7hQhiIrekU07p m1peDP8ChtBODyU9HrqRxZfdX+aKrRG8Oy9s/p68RgGMw2A7CM3fOz6dxByt1nGimfCx VYxMxTaSg9ykjLag9YWBW+qXvIFf+ijRf1uiDwBTygj5w/uDR4nZOW/cw5INWPPTxWTU e/4nNH6seR7TfWln9Uv0a6uru6/QxupcefjdEm591vPM5WDwg6rkg9Qr96dsuEjKDbFl jnog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tzKLNPWLykr9/aBbnysaMFDhv/d07ViTwAW8uENxWOc=; b=qPpSEDHDEfHZjE23pxQRoloRuxAy1IxRnExtFzTU1IKu2dOK6IjKXcB/4JcAVKuOij Jc68vgaiuwSB2fb/miT4AGWSMrrX+Qpxl5XApNYj5OOMatW7LZAgmIm08+6jZ9ncafMP BsxKMYW8zteI7m8oSEpo6GrxVMpTyugRxAWUOeGaR/c1tBrPQhlJZsQkMo51l1BTv/L1 Uyfbgbt0T/IeNY83vL3itj2rNo8PHj24XutqhSw6e7l+lmJj/Qk2aqngAcLeMK0qDn3o FznwAx5E7NJFHfJpPWZ3dZQXpk1VjL9oBQf0Na3h2dPA2s9PnIs4dpM39bewwhr42qLz 2OGw== X-Gm-Message-State: AOAM532pmi4kLEsqHYnmeqnqInDustlhlKRL1a5pmt2op49pjbfksLkp +n9KRpPqJrEq91ETpA9+90c= X-Google-Smtp-Source: ABdhPJxHttw4yoOqYNYX74+hZbHJV669Dec1wLU+2+qGTVmqaxcv9QiPeVFiSLY1QKK0YPFVX954Eg== X-Received: by 2002:ac2:5229:: with SMTP id i9mr1160013lfl.493.1633567653913; Wed, 06 Oct 2021 17:47:33 -0700 (PDT) Original-Received: from [192.168.1.113] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id f37sm2392190lfv.214.2021.10.06.17.47.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 17:47:33 -0700 (PDT) In-Reply-To: <87y276qyqe.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216600 Archived-At: On 06.10.2021 19:28, Juri Linkov wrote: >>>> Other commands, like maybe "C-x v b r" - rename, could be added then. >>> I can't find the existing vc API method for renaming tags/branches. >> I think that's OK. > But even the current branch creating command fails for git. > For example, 'C-u C-x v s new_branch RET' fails with the error: > > (error "Failed (status 1): git --no-pager update-index --refresh .") > > and shows the*vc* buffer saying that modified files need update. > > Whereas `M-& git checkout -b new_branch` works fine with modified files. All right, yes, the current behavior is weird. It's actually documented in the description of the 'create-tag' action: ;; Attach the tag NAME to the state of the working copy. This ;; should make sure that files are up-to-date before proceeding with ;; the action. Perhaps ESR or Dan N. have a good justification for this, but it seems to me the contemporary expectation is that tags and branches are created from the committed revision history, and not from the "working copy". Some backends may choose to enforce this kind of limitation, but the more modern ones like Git or Hg should skip the check IMHO. And it seems, from looking at vc-hg-create-tag, Hg already skips it.