From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#21798: 25.0.50; [PATCH] Add support for retrieving paths to JSON elements Date: Sun, 08 Nov 2015 22:12:39 +0100 Message-ID: <1447017159.19568.0@smtp.gmail.com> References: <1446281162.2607.0@smtp.gmail.com> <5634CEE7.3070200@yandex.ru> <1446407553.4906.0@smtp.gmail.com> <1446420466.13180.0@smtp.gmail.com> <56381558.7050607@yandex.ru> <1446827488.11140.2@smtp.gmail.com> <563CE043.9060404@yandex.ru> <1446922215.4732.0@smtp.gmail.com> <563E4E73.50702@yandex.ru> <1446985933.1975.0@smtp.gmail.com> <563F7560.1000409@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-jNI1lirybN5kUJ62U79c" X-Trace: ger.gmane.org 1447017202 14726 80.91.229.3 (8 Nov 2015 21:13:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Nov 2015 21:13:22 +0000 (UTC) Cc: 21798-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 08 22:13:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZvXGw-0000C9-KQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2015 22:13:10 +0100 Original-Received: from localhost ([::1]:48846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvXGv-0001ei-Vb for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2015 16:13:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvXGs-0001eX-F8 for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 16:13:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvXGp-0001bT-9R for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 16:13:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvXGp-0001bM-6M for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 16:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZvXGo-00061l-Rr for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 16:13:02 -0500 Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Nov 2015 21:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21798 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 21798@debbugs.gnu.org, simenheg@gmail.com, simenheg@gmail.com Original-Received: via spool by 21798-done@debbugs.gnu.org id=D21798.144701716623141 (code D ref 21798); Sun, 08 Nov 2015 21:13:02 +0000 Original-Received: (at 21798-done) by debbugs.gnu.org; 8 Nov 2015 21:12:46 +0000 Original-Received: from localhost ([127.0.0.1]:57877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvXGX-00061A-GZ for submit@debbugs.gnu.org; Sun, 08 Nov 2015 16:12:45 -0500 Original-Received: from mail-lf0-f48.google.com ([209.85.215.48]:36548) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvXGV-000612-BR for 21798-done@debbugs.gnu.org; Sun, 08 Nov 2015 16:12:44 -0500 Original-Received: by lfs39 with SMTP id 39so60871239lfs.3 for <21798-done@debbugs.gnu.org>; Sun, 08 Nov 2015 13:12:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-type; bh=UopOfnqaHzxTh6BAoa3Gy9WMBLE2aWCpNOyHbgXXFdY=; b=ilGgEZt/eFmDBjt+M27Wg6bHumY2bV4jl3EpPkiWik2zji5Nvzftgyiw/H4uZF0Crf K16QrNkVhcKyQvx26q6YgY0m78knHmqrvDAzMRkLu4CXD1qxw3AbXcYJH9vganmNeyjX YBMzZh6LG6eJkp/a1o92iH74drhuzYRR3JQtIUPanUPfPtF0JLd+KYe6wNHoi69C1iCX +EIBg8BRUTwT5pcrFOWD3f2rIpoBERyk1VFAK66kwb7hegDVOZWDxHxMbJDSMAu2MGCx W8Yrqbnt2HIkA0nu+GFdwa2HGsRcSGF64jRb0G77gQEXF+IJHelU4F7RygUlOhzyRlen Zyhw== X-Received: by 10.25.164.66 with SMTP id n63mr4902282lfe.24.1447017162453; Sun, 08 Nov 2015 13:12:42 -0800 (PST) Original-Received: from [192.168.100.7] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id v1sm1847479lfd.25.2015.11.08.13.12.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Nov 2015 13:12:41 -0800 (PST) In-Reply-To: <563F7560.1000409@yandex.ru> X-Mailer: geary/0.10.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108583 Archived-At: --=-jNI1lirybN5kUJ62U79c Content-Type: text/plain; charset=utf-8; format=flowed On Sun, Nov 8, 2015 at 5:16 PM, Dmitry Gutov wrote: > Thank you, but since `json-read' needs an optional argument in this > case (which is not trivial to describe), I'd rather we go back to the > previous patch. > > How about renaming json-pre-read-function to > json-pre-element-read-function, maybe? And same for the other one. > > If you're fine with that, please install the result. (Or without the > rename, it's up to you). I installed the previous patch with the renaming you suggested. Thanks for your reviews! By the way, if you find the time, could you give bug #21616 a quick look as well? It teaches the JSON encoder how to sort objects by their keys. I think it would be nice to get it in before the feature freeze, since it's the last piece of the puzzle to enable the new json-mode to achieve feature parity with the old one. -- Simen --=-jNI1lirybN5kUJ62U79c Content-Type: text/html; charset=utf-8 On Sun, Nov 8, 2015 at 5:16 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
Thank you, but since `json-read' needs an optional argument in this case (which is not trivial to describe), I'd rather we go back to the previous patch. How about renaming json-pre-read-function to json-pre-element-read-function, maybe? And same for the other one. If you're fine with that, please install the result. (Or without the rename, it's up to you).

I installed the previous patch with the renaming you suggested.

Thanks for your reviews!

By the way, if you find the time, could you give bug #21616 a quick
look as well? It teaches the JSON encoder how to sort objects by their
keys. I think it would be nice to get it in before the feature freeze,
since it's the last piece of the puzzle to enable the new json-mode to
achieve feature parity with the old one.

-- Simen
--=-jNI1lirybN5kUJ62U79c--