From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#21496: 25.0.50; guile-file compilation-error regexp is too wide Date: Sun, 20 Sep 2015 11:10:32 +0200 Message-ID: <1442740232.4029763.388464601.77A759F1@webmail.messagingengine.com> References: <37a49de7-566d-427c-a6a4-5b9a0c5b6723@email.android.com> <1442735047.4011990.388436737.1C10ECC9@webmail.messagingengine.com> <1442736482.4017257.388445737.60BE4453@webmail.messagingengine.com> Reply-To: jostein@kjonigsen.net NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_----------=_144274023240297631"; charset="utf-8" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1442740299 20871 80.91.229.3 (20 Sep 2015 09:11:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Sep 2015 09:11:39 +0000 (UTC) Cc: Jan Nieuwenhuizen , 21496@debbugs.gnu.org To: jostein@kjonigsen.net, Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 20 11:11:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZdaeY-0002ck-5F for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2015 11:11:22 +0200 Original-Received: from localhost ([::1]:50774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdaeX-000314-L8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Sep 2015 05:11:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdaeJ-0002kq-4m for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 05:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdaeF-0001TI-Aj for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 05:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdaeE-0001T8-Uz for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 05:11:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZdaeD-000198-SH for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2015 05:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2015 09:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21496-submit@debbugs.gnu.org id=B21496.14427402394378 (code B ref 21496); Sun, 20 Sep 2015 09:11:01 +0000 Original-Received: (at 21496) by debbugs.gnu.org; 20 Sep 2015 09:10:39 +0000 Original-Received: from localhost ([127.0.0.1]:38120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zdadp-00018W-5R for submit@debbugs.gnu.org; Sun, 20 Sep 2015 05:10:37 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zdadm-00018O-VK for 21496@debbugs.gnu.org; Sun, 20 Sep 2015 05:10:35 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3A99B2066D for <21496@debbugs.gnu.org>; Sun, 20 Sep 2015 05:10:33 -0400 (EDT) Original-Received: from web3 ([10.202.2.213]) by compute6.internal (MEProxy); Sun, 20 Sep 2015 05:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:from:in-reply-to:message-id:mime-version :references:reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=DX3FkFDEiORXM8+KUqRujR9jFsk=; b=vgRGg05PSNua+I/4kAErddsvqJjK GxfpXEyZCLDBrUM9ZJ9yu4EPLMNp6vbEjpEd3aLNJCg7L+S79yxgYcs0mlTNvEfW OKX5iMxNWW8LoojjDnd+VVSt9gtnVErpR8M7PBBVbIetQG2lFcAlrQuhCBphB72Z R+CPJVc+vjZiQ2c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :reply-to:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=DX3FkF DEiORXM8+KUqRujR9jFsk=; b=QmGyZX+zFpVcj3aPiRDDWOGCugLpYryRPD/v7Q 1PXZZQDn+agAnxB9+NCtaosQdZhQzceRywHyH3HoETHy95msOHLoWfrKGLy+T8VS YcNzKvXBv2cqwfvZlC9YQaqaDWAGHvNvsvxhLjC6dBYzsMrBZwMlLZcG/gSjAVa0 OgOoM= Original-Received: by web3.nyi.internal (Postfix, from userid 99) id D9FEA110AAB; Sun, 20 Sep 2015 05:10:32 -0400 (EDT) X-Sasl-Enc: sRYtfa26jn0rGYottaPrwe6WuyVHua4ZRseE1TN6wmTU 1442740232 X-Mailer: MessagingEngine.com Webmail Interface - ajax-e92f8263 In-Reply-To: <1442736482.4017257.388445737.60BE4453@webmail.messagingengine.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106724 Archived-At: This is a multi-part message in MIME format. --_----------=_144274023240297631 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="ISO-8859-1" Attached is a new patch which ensures guile-file only triggers when the match has an actual extension. That's honestly all that's needed to fix my issue and it should (hopefully) be permissive enough to work with whatever extension Schemers prefer. Everyone happy now? :) -- Jostein Kj=F8nigsen jostein@kjonigsen.net / jostein@secure.kjonigsen.net On Sun, Sep 20, 2015, at 10:08 AM, Jostein Kj=F8nigsen wrote: > Good feedack Andreas! >=20 > While there probably isn't any requirement for emacs-lisp to have the > extension "el", there's always some kind of conventions which goes > around. >=20 > I assume the same applies to Scheme. What extensions are > conventionally used for Scheme? >=20 > Checking wikipedia[1] I see the extensions "scm" and "ss" is used. > Another search yields[2] "s" and "scheme" too. >=20 > Can any Scheme-programmer elaborate on which extensions would be > useful to include in a patch like this? >=20 > I don't think there's any debate about the current regexp being too > wide, so it needs to be narrowed down somehow. >=20 > [1] https://en.wikipedia.org/wiki/Scheme_%28programming_language%29 > [2] https://duckduckgo.com/?q=3Dscheme+lang+file-extension >=20 > -- > Jostein Kj=F8nigsen > jostein@kjonigsen.net / jostein@secure.kjonigsen.net >=20 >=20 > On Sun, Sep 20, 2015, at 09:59 AM, Andreas Schwab wrote: >> Jostein Kj=F8nigsen writes: >>=20 >>> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el >>> index f9c097e..27a3833 100644 >>> --- a/lisp/progmodes/compile.el >>> +++ b/lisp/progmodes/compile.el >>> @@ -477,7 +477,9 @@ File =3D \\(.+\\), Line =3D \\([0-9]+\\)\\(?:, Colu= mn =3D \\([0-9]+\\)\\)?" >>> =A0 =A0 ;; >>> =A0 =A0 "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) " >>> =A0 =A0 1 2 3) >>> -=A0 =A0 (guile-file "^In \\(.+\\):\n" 1) >>> + >>> +=A0 =A0 ;; file-entries does not have to be errors, treat as info. >>> +=A0 =A0 (guile-file "^In \\(.+\\.scm\\):\n" 1 nil nil 0) >>=20 >> There is no requirement that names of scheme files end in `.scm'. >>=20 >> Andreas. >>=20 >> -- >> Andreas Schwab, schwab@linux-m68k.org >> GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756=A0 01D3 44D5 214B 8276 = 4ED5 >> "And now for something completely different." --_----------=_144274023240297631 Content-Disposition: attachment; filename="Emacs-compilation-mode-fixes.patch" Content-Id: <1442740184.4029673.502eae7c332aaa5bfb6134ab6841e2af30663b6c.618462DC@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="Emacs-compilation-mode-fixes.patch" RnJvbSBmYTFmYzk1MTRjOTVmMWM0YTcwNGZlMmMzMzA0NzFjZWJjYzE1MjJj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9z dGVpbj0yMEtqPUMzPUI4bmlnc2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5l dD4KRGF0ZTogU3VuLCAyMCBTZXAgMjAxNSAwOTozOTo1MCArMDIwMApTdWJq ZWN0OiBbUEFUQ0hdIEVtYWNzOiBjb21waWxhdGlvbi1tb2RlIGZpeGVzLgoK SXQncyBjb21tb24gZm9yIEVtYWNzLWxpc3AgbW9kdWxlLWRldmVsb3BlcnMg dG8gcnVuIEVtYWNzCmJ5dGUtY29tcGlsYXRpb24gaW4gc2VwYXJhdGUgYnVp bGQtc2NyaXB0cy4KCldoZW4gaW52b2tpbmcgYnl0ZS1jb21waWxlIG9uIEVt YWNzLWxpc3AgZmlsZXMgeW91IG9mdGVuIGdldCBoZWFkZXJzCmxpa2U6Cgot IEluIHRvcGxldmVsIGZvcm06Ci0gSW4gZW5kIG9mIGRhdGE6CgpXaGVuIHRo ZXNlIGVycm9ycyBzaG93IHVwIGluIHRoZSBvdXRwdXQgb2YgYSBidWlsZC1z Y3JpcHQgaW5pdGlhdGVkCnRocm91Z2ggTS14IGNvbXBpbGUgYW5kIHNob3cg dXAgaW4gYSBjb21waWxhdGlvbi1tb2RlIGJ1ZmZlciwgdGhlc2UKbGluZXMg Z2V0cyB0cmVhdGVkIGFzIGd1aWxlLWVycm9ycyBmb3IgZmlsZXMgd2l0aCB0 aGUgcmVzcGVjdGl2ZSBuYW1lcwoidG9wbGV2ZWwgZm9ybSIgYW5kICJlbmQg b2YgZGF0YSIuCgpUaGlzIGJyZWFrcyBwcmV2LWVycm9yIGFuZCBuZXh0LWVy cm9yIGJhc2VkIG5hdmlnYXRpb24uCgpUaGlzIHBhdGNoIGZpeGVzIHRoaXMg YnkgZG9pbmcgdGhlIGZvbGxvd2luZyBtb2RpZmljYXRpb25zOgoKLSBNYWtl IGd1aWxlLWZpbGUgb25seSB0cmlnZ2VyIHdoZW4gdGhlcmUncyBhIGZpbGUt ZXh0ZW5zaW9uLgotIFJlZHVjZSBzZXZlcml0eSBmcm9tIGVycm9yIHRvIHdh cm5pbmcuCi0tLQogbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbCB8IDYgKysr KystCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5l bCBiL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKaW5kZXggZjljMDk3ZS4u Y2I2MmI3ZiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5l bAorKysgYi9saXNwL3Byb2dtb2Rlcy9jb21waWxlLmVsCkBAIC00NzcsNyAr NDc3LDExIEBAIEZpbGUgPSBcXCguK1xcKSwgTGluZSA9IFxcKFswLTldK1xc KVxcKD86LCBDb2x1bW4gPSBcXChbMC05XStcXClcXCk/IgogICAgICA7Owog ICAgICAiXlxcKFteIFx0XHJcbihdK1xcKSAoXFwoWzAtOV0rXFwpOlxcKFsw LTldK1xcKSkgIgogICAgICAxIDIgMykKLSAgICAoZ3VpbGUtZmlsZSAiXklu IFxcKC4rXFwpOlxuIiAxKQorCisgICAgOzsgZmlsZS1lbnRyaWVzIGRvZXMg bm90IGhhdmUgdG8gYmUgZXJyb3JzLCB0cmVhdCBhcyBpbmZvLgorICAgIDs7 IHJlcXVpcmUgdGhlcmUgdG8gLWJlLSBhbiBleHRlbnNpb24sIHRvIG5vdCBh Y2NpZGVudGFsbHkKKyAgICA7OyBjYXRjaCBlbWFjcy1saXNwIGJ5dGUtY29t cGlsYXRpb24gb3V0cHV0LgorICAgIChndWlsZS1maWxlICJeSW4gXFwoLitc XC4uK1xcKTpcbiIgMSBuaWwgbmlsIDApCiAgICAgKGd1aWxlLWxpbmUgIl4g KlxcKFswLTldK1xcKTogKlxcKFswLTldK1xcKSIgbmlsIDEgMikKICAgICAp CiAgICJBbGlzdCBvZiB2YWx1ZXMgZm9yIGBjb21waWxhdGlvbi1lcnJvci1y ZWdleHAtYWxpc3QnLiIpCi0tIAoxLjkuMQoKCg== --_----------=_144274023240297631--