From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#66782: 29.1; ERT tests report test redefined depending on loading sequence Date: Thu, 2 Nov 2023 19:56:41 +0100 Message-ID: <143B680E-F34D-4E5E-9D11-2C50F7263920@gmail.com> References: <87msw393z8.fsf@debian-hx90.lan> <83y1fncl4k.fsf@gnu.org> <87o7gjgk65.fsf_-_@debian-hx90.lan> <83pm0zcc25.fsf@gnu.org> <87jzr7gfso.fsf@debian-hx90.lan> <83jzr7c74y.fsf@gnu.org> <87cywzge42.fsf@debian-hx90.lan> <83h6mbc5ss.fsf@gnu.org> <962518D0-36A0-4626-9652-0A0A977DBB2C@gmail.com> <87wmv6fnrn.fsf@debian-hx90.lan> <121E7FF6-4D07-40D5-A2D9-1B108605A117@gmail.com> <87pm0xf63w.fsf@debian-hx90.lan> <877cn3kfba.fsf@debian-hx90.lan> <87fs1ohy7m.fsf@debian-hx90.lan> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20217"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 66782@debbugs.gnu.org To: Xiyue Deng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 02 19:58:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qyctW-00055Y-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Nov 2023 19:58:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qycsi-00009D-Q9; Thu, 02 Nov 2023 14:57:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qycsg-00008h-U6 for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 14:57:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qycsg-0001ox-JD for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 14:57:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qyctF-00049a-L4 for bug-gnu-emacs@gnu.org; Thu, 02 Nov 2023 14:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Nov 2023 18:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66782 X-GNU-PR-Package: emacs Original-Received: via spool by 66782-submit@debbugs.gnu.org id=B66782.169895144915919 (code B ref 66782); Thu, 02 Nov 2023 18:58:01 +0000 Original-Received: (at 66782) by debbugs.gnu.org; 2 Nov 2023 18:57:29 +0000 Original-Received: from localhost ([127.0.0.1]:56045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qycsj-00048g-Ei for submit@debbugs.gnu.org; Thu, 02 Nov 2023 14:57:29 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:61731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qycse-00048Q-UE for 66782@debbugs.gnu.org; Thu, 02 Nov 2023 14:57:28 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c6ed1b9a1cso17104751fa.3 for <66782@debbugs.gnu.org>; Thu, 02 Nov 2023 11:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698951404; x=1699556204; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=LLKjJzbl3G9wgurUVFVboMdOb3uXI7Tm6CLZgcMMPPo=; b=FO7j15xvpqah8/oE9E2yK4NJE44oxMXbDlmBG9e5SQGZqzEbW+dotTT5OaH7IU6nDz do2DL6Unt3NAg6dN0ZLG5F1fyks0nAZDdniN3YG00x7OiQ17CDAc5t3WILF1A7kmhOAB PICciaOgyYULAKBk2acjpIeARieb5nGg/4vPp9g26D5SuOmlo3uRvJhlaS9e+P5nMfQx Mkg1aGcujVy3LTCc5tvXSmh1VudBbYP4JmLiD8rqUMe9oIjJvuXZqSW+mJbY2uw80pTM nRI4aV1fZRJWMq2EDITJXX/G3rgKWpBBltTXojgDTyKpnlGU4QmG/rd2qLSbUbPDSEab QmaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698951404; x=1699556204; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LLKjJzbl3G9wgurUVFVboMdOb3uXI7Tm6CLZgcMMPPo=; b=KJk6NP2QAGQE8MX+KaTxiqQrYq3Enmjj2Vd4qyxGnKi3OsjCRFJZYorMKIqEidIZVC 5Pv+FEvofxv+aiwL/i3ep1CDJcIEy8q//CSwgCSj8GsfMluwLoDHkvF/kCnX99dJGTd5 ETij/kS0277Og6zYW7EaL0rvBA/vnAMmz833R45++rJ9axqCHkDRTCR6UanYQV4YfQ0c LbFvLY920OH2jzuBERxVLFQNZFMfoyd1Z6rICXV1ZFtDXm0uIAkDYZuH3N/S4S62zih8 DOpxuowRRB73RHaU/ZKyEEHr2u/pevOqzs+Xhou2KTKdU11xOoxAk63jEffrxgdutAPf 3ebQ== X-Gm-Message-State: AOJu0Ywccda8xQBblikx4x4tBpG9/JHXPBy2LS3CkQJqPa7k2to4q46z Qc1l4aFuvyTPMsOMkJ+rgcQ= X-Google-Smtp-Source: AGHT+IGUvK4hCKiZBfZ5ESJy89GlPRgRycLxpVaurXya+UY+LCsgWjwxYdY7yA/eZSxfPWyThqL0fA== X-Received: by 2002:a2e:300a:0:b0:2c5:55a:b6ae with SMTP id w10-20020a2e300a000000b002c5055ab6aemr13681176ljw.16.1698951403459; Thu, 02 Nov 2023 11:56:43 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id l24-20020a2e9098000000b002bc3fbe9fd5sm12508ljg.55.2023.11.02.11.56.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2023 11:56:42 -0700 (PDT) In-Reply-To: <87fs1ohy7m.fsf@debian-hx90.lan> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273668 Archived-At: 2 nov. 2023 kl. 18.17 skrev Xiyue Deng : >> I understand if upstream don't want to complicate `require' logic too >> much. However I wonder whether it's OK to add warning if a required >> module has `ert-deftest' in it, so that it can help people identify = that >> a `Test "foo" redefined' error is due to requiring other module = instead >> of an actual duplicated test name. How does this sound? >=20 > As I didn't get an answer I assume this was a no-go. No, please don't make such an assumption -- I was just busy elsewhere = and hadn't given your message the attention it deserved. Sorry about = that. That said, in this case I'm not sure how to implement your suggestion in = a clean way and if all that effort is really worth the trouble, so = perhaps the answer would be the same anyway. And we probably don't want = to prohibit `ert-deftest` in required modules in general for reasons = mentioned -- they could be used with perfectly fine discipline = elsewhere. > So instead I'd > like to propose a slight change to the error message to mention that = it > may also be caused by an ert test being loaded multiple times. Patch = is > attached, please let me know whether this works. I wouldn't mind such a change if it really would help. Would it? Isn't = it just restating the problem in other words?