From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#20256: 25.0.50; css-mode: filling multi-line comments Date: Mon, 27 Apr 2015 22:32:31 +0200 Message-ID: <1430166751.5441.0@smtp.gmail.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-KvN0r79LeeL0QkgmjSPA" X-Trace: ger.gmane.org 1430166801 31145 80.91.229.3 (27 Apr 2015 20:33:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Apr 2015 20:33:21 +0000 (UTC) Cc: 20256-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 27 22:33:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YmpiI-0001TS-Tt for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Apr 2015 22:33:11 +0200 Original-Received: from localhost ([::1]:57570 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmpiI-0005xv-Bt for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Apr 2015 16:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmpiE-0005xq-Iv for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 16:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmpiA-0002HB-IE for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 16:33:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmpiA-0002H5-F4 for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 16:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YmpiA-0000uM-0S for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2015 16:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2015 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20256-done@debbugs.gnu.org id=D20256.14301667652897 (code D ref 20256); Mon, 27 Apr 2015 20:33:01 +0000 Original-Received: (at 20256-done) by debbugs.gnu.org; 27 Apr 2015 20:32:45 +0000 Original-Received: from localhost ([127.0.0.1]:41602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ymphs-0000k8-6c for submit@debbugs.gnu.org; Mon, 27 Apr 2015 16:32:44 -0400 Original-Received: from mail-lb0-f181.google.com ([209.85.217.181]:33755) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ymphp-0000et-0c for 20256-done@debbugs.gnu.org; Mon, 27 Apr 2015 16:32:41 -0400 Original-Received: by lbbzk7 with SMTP id zk7so91629426lbb.0 for <20256-done@debbugs.gnu.org>; Mon, 27 Apr 2015 13:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-type; bh=Ctn9XA+jwpgMH0kLYpw4VWFUbkxS9g3yh/SI1Hv3Mkg=; b=mXrKeFU4Z5Pt61DbDcgekNl1tnnrrHXlEi48R3aVcw4nATwfboqlc9Lp1l6qIiHLku rpRr2uTDqObb/nlQ9MgArB+igBpKYAGCUHkmmgiqI6adc9zfmX55VHHlMGpS/ybf3K8e /UY4hdpUznEt6b5HBbdvGn5j8AgB4SaDKSkNeiWCS4vDcDGYQmod46uhHFxYWrVGHg+O buzQFKlRwoN/6/asy94GGvUDOthN2mAdsdjLaayU7q3tELnFjLGvZGQuoQ+DApdLAT12 QS8RHUcdc64k4RUP3kGe3CHE9RzDSt0N0L82b/YkNzQX591o2+TQJDMwc0J2azwyvRgD Fp7w== X-Received: by 10.152.22.34 with SMTP id a2mr754475laf.59.1430166754919; Mon, 27 Apr 2015 13:32:34 -0700 (PDT) Original-Received: from [192.168.1.114] (cm-84.215.44.110.getinternet.no. [84.215.44.110]) by mx.google.com with ESMTPSA id lh8sm5018081lab.30.2015.04.27.13.32.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2015 13:32:34 -0700 (PDT) In-Reply-To: X-Mailer: geary/0.8.3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102112 Archived-At: --=-KvN0r79LeeL0QkgmjSPA Content-Type: text/plain; charset=utf-8; format=flowed On Mon, Apr 27, 2015 at 6:11 AM, Stefan Monnier wrote: >> +(defun prog-fill-paragraph (&optional justify) > [...] >> + ;; Filling inside a comment whose comment-end marker is not >> + ;; \n. This code is meant to be generic, so that it works >> for >> + ;; all modes. > > Hmm... so the code doesn't handle the case of comments that end with > \n? > > > Stefan No, I don't think so. When the comment-end marker is \n, `forward-comment' will leave point at the beginning of the next line, causing the whole filling code to be skipped. Even when tweaking the predicate so that the code is run anyway, it doesn't fill the comment properly. Was it ever intended to do so? I assumed from the comment that you quoted that it wasn't. Those kinds of comments seem to be handled well by the default `fill-paragraph', though. -- Simen --=-KvN0r79LeeL0QkgmjSPA Content-Type: text/html; charset=utf-8 On Mon, Apr 27, 2015 at 6:11 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
+(defun prog-fill-paragraph (&optional justify)
[...]
+ ;; Filling inside a comment whose comment-end marker is not + ;; \n. This code is meant to be generic, so that it works for + ;; all modes.
Hmm... so the code doesn't handle the case of comments that end with \n? Stefan

No, I don't think so. When the comment-end marker is \n,
`forward-comment' will leave point at the beginning of the next line,
causing the whole filling code to be skipped. Even when tweaking the
predicate so that the code is run anyway, it doesn't fill the comment
properly. Was it ever intended to do so? I assumed from the comment
that you quoted that it wasn't.

Those kinds of comments seem to be handled well by the default
`fill-paragraph', though.

-- Simen
--=-KvN0r79LeeL0QkgmjSPA--