unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Simen Heggestøyl" <simenheg@gmail.com>
To: 20256@debbugs.gnu.org
Subject: bug#20256: 25.0.50; css-mode: filling multi-line comments
Date: Sat, 04 Apr 2015 15:12:31 +0200	[thread overview]
Message-ID: <1428153151.17305.0@smtp.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Filling multi-line comments in `css-mode' is broken. Consider for
instance the following comment:

  /*
   * Multi-line comment here.
   * This comment spans
   * multiple
   * lines.
   * Better fill it!
   */

Filling it with a `fill-column' of 70, I'd expect the following
result:

  /*
   * Multi-line comment here.  This comment spans multiple lines.
   * Better fill it!
   */

But as of now, what we get is this:

  /* * Multi-line comment here.  * This comment spans * multiple *
  lines.  * Better fill it!  */

 From this comment in `css-fill-paragraph', it sounds like it is
supposed to work, or has been working some time before:

  ;; Filling inside a comment whose comment-end marker is not \n.
  ;; This code is meant to be generic, so that it works not only for
  ;; css-mode but for all modes.

Could someone fill me in?

Alternatively, we could let `css-mode' borrow comment filling code
from `cc-mode', like `js-mode' and `js2-mode' do. Please let me know
if that would be an acceptable fix.

-- Simen

[-- Attachment #2: Type: text/html, Size: 1585 bytes --]

             reply	other threads:[~2015-04-04 13:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 13:12 Simen Heggestøyl [this message]
2015-04-07 18:26 ` bug#20256: 25.0.50; css-mode: filling multi-line comments Stefan Monnier
2015-04-09 18:51   ` Simen Heggestøyl
2015-04-10  1:25     ` Stefan Monnier
2015-04-10 18:45       ` Simen Heggestøyl
2015-04-13 14:28         ` Stefan Monnier
2015-04-18 10:02           ` Simen Heggestøyl
2015-04-18 14:06             ` Stefan Monnier
2015-04-18 18:33               ` Simen Heggestøyl
2015-04-20 16:09                 ` Stefan Monnier
2015-04-21 19:08                   ` Simen Heggestøyl
2015-04-21 20:26                     ` Stefan Monnier
2015-04-26 20:56                   ` Simen Heggestøyl
2015-04-27  4:11                     ` Stefan Monnier
2015-04-27 20:32                       ` Simen Heggestøyl
2015-04-27 22:46                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428153151.17305.0@smtp.gmail.com \
    --to=simenheg@gmail.com \
    --cc=20256@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).