From: Michal Nazarewicz <mina86@mina86.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, 18730@debbugs.gnu.org
Cc: Milan Zamazal <pdm@zamazal.org>
Subject: bug#18730: [PATCHv2 1/2] tildify.el (tildify--pick-alist-entry): rename from tildify-mode-alist.
Date: Thu, 16 Oct 2014 17:34:11 +0200 [thread overview]
Message-ID: <1413473652-26262-1-git-send-email-mina86@mina86.com> (raw)
In-Reply-To: <xa1tegu9n4mh.fsf@mina86.com>
tildify-mode-alist does not really describe what the functino does so
rename it to tildify--pick-alist-entry. This also makes it clear that
the function is an internal one.
---
lisp/textmodes/tildify.el | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lisp/textmodes/tildify.el b/lisp/textmodes/tildify.el
index 50fee2f..91f5a38 100644
--- a/lisp/textmodes/tildify.el
+++ b/lisp/textmodes/tildify.el
@@ -4,7 +4,7 @@
;; Author: Milan Zamazal <pdm@zamazal.org>
;; Michal Nazarewicz <mina86@mina86.com>
-;; Version: 4.5.3
+;; Version: 4.5.4
;; Keywords: text, TeX, SGML, wp
;; This file is part of GNU Emacs.
@@ -226,13 +226,13 @@ won't be prompted for confirmation of each substitution."
;;; *** Auxiliary functions ***
-(defun tildify-mode-alist (mode-alist &optional mode)
+(defun tildify--pick-alist-entry (mode-alist &optional mode)
"Return alist item for the MODE-ALIST in the current major MODE."
(let ((alist (cdr (or (assoc (or mode major-mode) mode-alist)
(assoc t mode-alist)))))
(if (and alist
(symbolp alist))
- (tildify-mode-alist mode-alist alist)
+ (tildify--pick-alist-entry mode-alist alist)
alist)))
(defun tildify-foreach-region-outside-env (beg end callback)
@@ -244,7 +244,7 @@ arguments specifying the region to operate on. Stop scanning the
region as soon as CALLBACK returns nil. Environments to ignore
are determined from `tildify-ignored-environments-alist'."
(declare (indent 2))
- (let ((pairs (tildify-mode-alist tildify-ignored-environments-alist)))
+ (let ((pairs (tildify--pick-alist-entry tildify-ignored-environments-alist)))
(if (not pairs)
(funcall callback beg end)
(let ((func (lambda (b e)
@@ -300,10 +300,10 @@ replacements done and response is one of symbols: t (all right), nil
(quit), force (replace without further questions)."
(save-excursion
(goto-char beg)
- (let* ((alist (tildify-mode-alist tildify-pattern-alist))
+ (let* ((alist (tildify--pick-alist-entry tildify-pattern-alist))
(regexp (car alist))
(match-number (cadr alist))
- (tilde (tildify-mode-alist tildify-string-alist))
+ (tilde (tildify--pick-alist-entry tildify-string-alist))
(end-marker (copy-marker end))
answer
bad-answer
--
2.1.0.rc2.206.gedb03e5
next prev parent reply other threads:[~2014-10-16 15:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 8:01 bug#18730: [PATCH] tildify.el: Add `auto-tildify' and `auto-tildify-mode' Michal Nazarewicz
2014-10-15 14:35 ` Stefan Monnier
2014-10-16 9:34 ` Michal Nazarewicz
2014-10-16 14:03 ` Stefan Monnier
2014-10-16 14:57 ` Stefan Monnier
2014-10-16 16:07 ` Michal Nazarewicz
2014-10-16 19:39 ` Stefan Monnier
2014-10-17 8:44 ` Michal Nazarewicz
2014-10-17 13:06 ` Stefan Monnier
2014-10-22 23:19 ` Michal Nazarewicz
2014-10-24 22:51 ` Stefan Monnier
2014-10-28 22:01 ` bug#18730: [PATCH] tildify.el: introduce a `tildify-space-string' variable Michal Nazarewicz
2014-10-30 16:27 ` Stefan Monnier
2014-11-03 15:59 ` Michal Nazarewicz
2014-11-03 17:00 ` Stefan Monnier
2014-11-17 15:41 ` bug#18730: [PATCH 1/3] " Michal Nazarewicz
2014-11-17 15:41 ` bug#18730: [PATCH 2/3] tildify.el: introduce a `tildify-pattern' variable Michal Nazarewicz
2014-11-17 15:41 ` bug#18730: [PATCH 3/3] tildify.el: introduce a `tildify-foreach-region-function' variable Michal Nazarewicz
2014-11-17 17:38 ` bug#18730: [PATCH 1/3] tildify.el: introduce a `tildify-space-string' variable Stefan Monnier
2014-10-16 13:17 ` bug#18730: [PATCH] tildify.el: Add `auto-tildify' and `auto-tildify-mode' Ted Zlatanov
2014-10-16 14:16 ` Michal Nazarewicz
2014-10-16 14:55 ` Stefan Monnier
2014-10-16 17:17 ` Ted Zlatanov
2014-10-16 13:19 ` Ted Zlatanov
2014-10-16 15:34 ` Michal Nazarewicz [this message]
2014-10-16 15:34 ` bug#18730: [PATCHv2 2/2] " Michal Nazarewicz
2014-10-16 19:30 ` bug#18730: [PATCHv2 1/2] tildify.el (tildify--pick-alist-entry): rename from tildify-mode-alist Stefan Monnier
2014-11-24 14:20 ` bug#18730: [PATCH 1/2] tildify.el: Add `tildify-space' and `tildify-mode' Michal Nazarewicz
2014-11-24 14:20 ` bug#18730: [PATCH 2/2] tildify.el: Add `tildify-double-space-undos' Michal Nazarewicz
2014-12-10 17:44 ` bug#18730: [PATCH 1/2] tildify.el: Add `tildify-space' and `tildify-mode' Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413473652-26262-1-git-send-email-mina86@mina86.com \
--to=mina86@mina86.com \
--cc=18730@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=pdm@zamazal.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).