From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string Date: Fri, 14 May 2021 09:15:09 +0200 Message-ID: <139ea227-861b-b3c3-c36a-9b7ac30a5acb@gmx.at> References: <20210514011519.vsy5jbhyxd4v6kpt@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32673"; mail-complaints-to="usenet@ciao.gmane.io" To: Boruch Baum , 48408@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 14 09:16:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhS3O-0008QA-Dd for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 09:16:10 +0200 Original-Received: from localhost ([::1]:45508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhS3N-0001G5-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 03:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhS3G-0001F9-E9 for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 03:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhS3G-00057a-4o for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 03:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhS3G-00070a-0y for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 May 2021 07:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48408 X-GNU-PR-Package: emacs Original-Received: via spool by 48408-submit@debbugs.gnu.org id=B48408.162097651826889 (code B ref 48408); Fri, 14 May 2021 07:16:01 +0000 Original-Received: (at 48408) by debbugs.gnu.org; 14 May 2021 07:15:18 +0000 Original-Received: from localhost ([127.0.0.1]:44825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhS2Y-0006zd-Lp for submit@debbugs.gnu.org; Fri, 14 May 2021 03:15:18 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:57451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhS2W-0006zM-T8 for 48408@debbugs.gnu.org; Fri, 14 May 2021 03:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620976511; bh=fo4TJjyNTN1nqFM7dNS/jk0uj4YAxIq5Kxpi7nPxP6Q=; h=X-UI-Sender-Class:Subject:From:To:References:Date:In-Reply-To; b=RsOTo4p+X95uwH/q2ffAJvugoy8d/NTNFPdq4OQGYlZWmMLuqarPp+q3PWbnAFDmv bldVUgACedYhrx+qFZLhLqGMt48lel0n52SamIKpFBKHquVwRfUMSdyK38z0aSpHyR F8/LoOSwryVA/46NM/MnOH1faZg1oEh5fx2oVHJQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.218]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4zAs-1lXjCs3YUm-010qBg; Fri, 14 May 2021 09:15:10 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:fNyxFPPGq5ywxP/nq26ZhChdAu/os3PsATGlIjQsZLNfkU1hXMT Q66KIYOm2/ybJON89GB59el1crifhXD2I8oyj+xpMU2cjNmhk63lDdsRJeJG3M1WagHI4Vg BxRrS/QRSr4sFmjdqDutmUA20CUK7SGQ4O09wb0jV4T2UiA0RogpPWxzz3AYHpxyIhGXCLz RLcZlVA4sG8Mh98WhytXg== X-UI-Out-Filterresults: notjunk:1;V03:K0:HK4b85ZMZ8o=:Leq9e22N1ecMX952EzJhjH DyPhNBsueMsdZKj5qRZpC6L7tpQgo3DxBRJxHPJkXt1Yn+jVJmQabl1Tw2N7Ujl70lh1g5X7p 1Kk7RaXtGq2yG418Fy6PClzrFtJ8p7Wv3U20l/kNzW8STyd0j3BEXVWfrscPkZNaaG9XOZv11 vkFzpfefc9buc59hCAsZwZpw8zXEEEma1KLNXBnLQIL9MGWhfoMNrhFDQ7EqDAjCB7H9+XAOi tmnOOTxpcOjY2RecxDU8M5yLQhj6lKjJZpW2W/dx1Pyq+05v8/1tNorCUurqsbmce+QhbYktU S0VC2R5cD7XuzJLEaDthi/tIYMvgUTMwR1rHpuCSLJaFDaG2wPJax3NNPnfQBMWfh54zwOiFK YfLDnSg6XfoZMxpQ6knwcc8l442njwKHiELZugLD1OuUC7pgiNHvGFdWPieTfHdCVH5RXHK9o EthpbrgDRDTy7MrdIM6cW4bNCv8/V2sVcwjhmx8+U/ekd9H4Xa2FklgpO3O8ucr8x69RZQLx8 aSc35GoyVfyjODx0Mhky8unzXudQPuqFV3ODg50wQUxpQLG1/c91SBvryEPuJGAf3nZLdqj1I 8gP0FNLzkxozHxWYZcYrsyZ1HFgNT/SKMXKrfSSUuATTZquPNO0kN6RQ834+BuC8yf1BF0gk1 HEOMKMpFXR+R2XbeK7BfK6NbGOiZ59mKzFvGPHaQpl4VDktH5dTht1WJh2YpRGVVeXKA8e6FS IwDckGPI5SedCk6F3spkAGrx7YFytf2F2m8sqr99/+dMlaZsvS6gfQw/vOUtqeWqeclX2sox X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206488 Archived-At: > > In package windows.el, function `window-default-font-height' calls > > function `face-font', which can return a nil value, but performs a > > `string-equal' operation on the output without checking for that > > possibiliy. > > Please report this to the author(s) of that package. Sorry. This function is missing from my current window.el here ... > > I came across this in an unusual case, of having an 'emacs -nw' server > > an 'emacsclient -nw', and opening a GUI emacsclient to connect to it. > > From that point forward until the fix, every *second* attempt to use the > > minibuffer on the 'emacsclient -nw' would fail. > > > > The fix I'm using is: > > > > (if (and (display-multi-font-p (frame-parameter frame 'display)) > > (stringp default-font) ; <<<---!!! > > What is `default-font'? ... and so I didn't catch this one either. I'll try to find out what I'm doing differently now. martin