From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Trent W. Buck" <trentbuck@gmail.com>, 62370@debbugs.gnu.org
Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces
Date: Wed, 22 Mar 2023 20:10:37 +0000 [thread overview]
Message-ID: <13910d348d640c50ebdc@heytings.org> (raw)
In-Reply-To: <83y1no6dtd.fsf@gnu.org>
>> I think sieve-mode should inherit from font-lock-*-face, as most other
>> things do.
>
> I'm not sure I agree. These faces are with us for a long time, so
> changing their defaults now brings disadvantages: it could cause someone
> dislike the result.
>
> Does anyone else have an opinion about this?
>
I agree with both Trent and you.
Modes should inherit from font-lock-*-faces, unless there's a good reason
not to inherit from these faces. Otherwise customizing the visual
appearance of Emacs is a nightmare. This is, by the way, made clear in
(elisp)Major Mode Conventions: "Each face that the mode defines should, if
possible, inherit from an existing Emacs face. See Basic Faces, and see
Faces for Font Lock."
But the sieve-* faces have existed for twenty years, so it's now too late
to change them.
next prev parent reply other threads:[~2023-03-22 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 5:41 bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces Trent W. Buck
2023-03-22 14:49 ` Eli Zaretskii
2023-03-22 20:10 ` Gregory Heytings [this message]
2023-03-22 21:22 ` Jim Porter
2023-03-23 1:05 ` Trent W. Buck
2023-03-23 6:58 ` Eli Zaretskii
2023-03-23 7:03 ` Trent W. Buck
2023-03-23 7:25 ` Eli Zaretskii
2023-03-23 16:11 ` Jim Porter
2023-09-03 10:30 ` Stefan Kangas
2023-09-03 11:04 ` Philip Kaludercic
2023-09-05 4:43 ` Jim Porter
2023-09-05 12:01 ` Eli Zaretskii
2023-09-05 15:52 ` Jim Porter
2023-09-05 16:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13910d348d640c50ebdc@heytings.org \
--to=gregory@heytings.org \
--cc=62370@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=trentbuck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).