From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#35385: 27.0.50; Make dired-dwim-target aware of other frames Date: Thu, 19 Sep 2019 10:18:45 +0200 Message-ID: <138859c1-a7e0-f40d-4623-635826decd90@gmx.at> References: <87k1fl3e6z.fsf@tcd.ie> <87zhj4osjw.fsf@gnus.org> <877e67x6ny.fsf@mail.linkov.net> <87impp1djl.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71512"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "Basil L. Contovounesios" , 35385@debbugs.gnu.org To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 19 10:20:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iArft-000ITi-On for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2019 10:20:25 +0200 Original-Received: from localhost ([::1]:39992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iArfs-0005Lj-3Q for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2019 04:20:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33495) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iArfX-0005L7-HD for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 04:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iArfW-0002T2-Mg for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 04:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46289) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iArfW-0002Sy-GN for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 04:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iArfW-0002ix-BJ for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2019 04:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2019 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35385-submit@debbugs.gnu.org id=B35385.156888114210382 (code B ref 35385); Thu, 19 Sep 2019 08:20:02 +0000 Original-Received: (at 35385) by debbugs.gnu.org; 19 Sep 2019 08:19:02 +0000 Original-Received: from localhost ([127.0.0.1]:55107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAreY-0002hO-CN for submit@debbugs.gnu.org; Thu, 19 Sep 2019 04:19:02 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:42095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAreW-0002gk-Mk for 35385@debbugs.gnu.org; Thu, 19 Sep 2019 04:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1568881128; bh=7ncY64EU1bItGZvUXtVX0KORQ/j3uSBswWIhcFLF3OI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=PTJ2/HlUiaA1HeuzYBYHAx6z4dIIT0jZ4B4kUovZOWJdkz9V1q0uTtNm6PW5N2L7A inAH7AsRAyG4NdjtibzNfJXuRPE5MLMmN0vjW3ozh9zDiCIoitNvtg8ajP1C/8wnHv xBCZEa6K/7Wxuz6vpIybrZfz+ojs6rh4Y01NYDp4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.28]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTiPv-1ieJef2XfB-00U2MZ; Thu, 19 Sep 2019 10:18:48 +0200 In-Reply-To: <87impp1djl.fsf@mail.linkov.net> Content-Language: de-DE X-Provags-ID: V03:K1:kYlzgMM7RJUFrmNgWdYxMShYMuL46N49rFwa7i9ezA+RVYaBFak FVm8YqktE0ZgfhLb/WpEZ6wN11QR2guq17dcbd8rbB4Qr7zTrlaO7liq0Th0nPLpU1xjIYZ qMt1xHEOOTsU80a3M5YE7RrfTRkt87gLqBipStEmw4KBUJAX3amWBx5AGW2W7V8mqlGAVdP mcTALYPymg9h9Bbb0SIPw== X-UI-Out-Filterresults: notjunk:1;V03:K0:bQwBSg7+wzc=:zrLkKITTHh2bL6Q0kbRZp6 BlrVH/kjll9N3wZ7bNsb/hFgtOOUUThZ+Ss3jjexWEXusu42CRNLtTCu7T2BvKgSqo/8zuA+e mKF1wU1F6ioTFNHcb7ycyx1GMoTXfQ+lBbTDGmgwjjM2NzGfm525Tz6U/EHi/aT7Mzyk/nZrg u/vEzsnlAwi1M8b6zc/oV6/t7sA6nZBr27Akio4c0G0TXXuNCu8dxXYuxdGzvZFCQ/Hxs4INF sSAvjgm6AuI9zYsFTGtkePvKyd7XoQUEry6i4pDDPoROmp9h4ifqjf/ahiahF7p7P4wf20cGo +fZ+lBaEfNN/s14iyDn/L+nL94+2hqf1v0dCw8puYbb8OgC9+SLqDxJUTlyNBeLO43gn+7chn JR0XHubkkMmQjcdCYsgXgYQrFexe158KpTLLuGgw5didMVoyVDzR1qB1rpOI9nS21G9/oqVFW 7kq8gUwARwqNWee64GqOW0XuBiCAWE1RphS4j1Hk4lktv0f3L0CG+IhaInFYNXPw6qsBV7IcS 1apJsZkcrT/QJkG+HhU86AccZOSGWraWAG3Ai0ep+6DbuS6DT4/l+kw1ep/i23jvDrKrTYrfW 9ISmB9tRdVEkw4OMctzhUEjG9YXe51HFLirunpQzI1F+P+DTFnWcK+olTWBt1rmkE0/9DTd8D spYcMuMQpfCJ6yhOv5mGrmbGxx7Nlup35S++KKExNVzH1SgYXNzTbu7UdDS7tjAmLqVJjtnWp Ysd0A5dBR2VpoXrYpyXIOpRX81YUhQXU3E0Fne/r9wsBa0veJ14c4WA5f5TItKKyfXFHqtHk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166703 Archived-At: > BTW, while looking at windows walking functions, I noticed > an opportunity for simplification. > > Martin, could you please confirm if I'm not mistaken with this patch: Removing the (when (framep all-frames) (select-window (frame-first-window all-frames) 'norecord)) LGTM. Whether we should remove the (save-selected-window envelope is another question. If FUN changes the selected window, we'd now have a side effect we didn't have so far. Personally, I would always try to use 'walk-window-tree' instead of 'walk-windows' reserving the latter for operations that are allowed to create or delete windows. martin