From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 45797@debbugs.gnu.org
Subject: bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring
Date: Mon, 11 Jan 2021 20:20:04 +0100 (CET) [thread overview]
Message-ID: <1374515308.96389.1610392804487@ichabod.co-bxl> (raw)
[-- Attachment #1: Type: text/plain, Size: 80 bytes --]
See attached.
--
Sent with https://mailfence.com
Secure and private email
[-- Attachment #2: File Attachment: 0001-comint-read-input-ring-Simplify-last-commit.patch --]
[-- Type: text/x-diff, Size: 922 bytes --]
From 7adf2a49d3b247f424b7a9c2fab24a82418bbb8e Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Mon, 11 Jan 2021 11:09:30 -0800
Subject: [PATCH] comint-read-input-ring: Simplify last commit
* lisp/comint.el (comint-read-input-ring): Simplify.
It is not necessary to use `goto-char' again since we have already
moved point to the desired location.
---
lisp/comint.el | 1 -
1 file changed, 1 deletion(-)
diff --git a/lisp/comint.el b/lisp/comint.el
index 3476fd146c..53153af7d2 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -1000,7 +1000,6 @@ comint-read-input-ring
(goto-char (match-end 0)))
(setq start (point))
(setq history (buffer-substring start end))
- (goto-char start)
(when (and (not (string-match history-ignore history))
(or (null ignoredups)
(ring-empty-p ring)
--
2.29.2
next reply other threads:[~2021-01-11 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 19:20 Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-01-12 12:29 ` bug#45797: 28.0.50; [PATCH]: Simplify comint-read-input-ring Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374515308.96389.1610392804487@ichabod.co-bxl \
--to=bug-gnu-emacs@gnu.org \
--cc=45797@debbugs.gnu.org \
--cc=leungbk@mailfence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).