From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#63290: 30.0.50; Customize UI shows extra fields for (choice (const ...) (alist ...)) Date: Sun, 16 Jul 2023 10:15:26 -0300 Message-ID: <136334d9-262d-e290-cff3-159c2f827b87@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 63290@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 15:16:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL1bq-000AJ4-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 15:16:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL1bY-0007FL-Rb; Sun, 16 Jul 2023 09:16:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL1bW-0007Cv-N8 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 09:16:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL1bW-0002La-FC for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 09:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL1bV-0002NZ-UB for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 09:16:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 13:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63290 X-GNU-PR-Package: emacs Original-Received: via spool by 63290-submit@debbugs.gnu.org id=B63290.16895133419099 (code B ref 63290); Sun, 16 Jul 2023 13:16:01 +0000 Original-Received: (at 63290) by debbugs.gnu.org; 16 Jul 2023 13:15:41 +0000 Original-Received: from localhost ([127.0.0.1]:47051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL1bB-0002Mg-3U for submit@debbugs.gnu.org; Sun, 16 Jul 2023 09:15:41 -0400 Original-Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:45459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL1b6-0002MF-SR for 63290@debbugs.gnu.org; Sun, 16 Jul 2023 09:15:40 -0400 Original-Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3a04e5baffcso2669612b6e.3 for <63290@debbugs.gnu.org>; Sun, 16 Jul 2023 06:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689513331; x=1692105331; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=EuEGC0t0GuK6IWAHo8+P/T94c6+EfLfZVasRqCS5Dng=; b=JKnTuIbukP8xMA/lc8Y8m9Qx+if9hCboYrok4t5HaIwJPiJ07xL1x2gH4inJUfHSRL 0J6W4xk2JpmRXe7Mro/2pmaAyFXE5j/dtvastPiYOzBs4RTW2vJ40yLRL2+PAbIEphWy e/xx8GrPDR17J5Hc/ihqWGKJgOh+s2f8T5pGusw01CPtmZc1XUSrVkMK2qFa9BT6GzuJ Qt0JA6lal9segtl6Vng32gcex9dJc9KAy3BQlYyHOHV/Ol2nkSKkbbxN67dmuopmaDbO sFIcvVy0y1c9L52s8z6v7R2GfnHk8Ch40s1SUVjBnK3vNHBlmaYWRjHWqqL5c/gIkTHl 1fGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689513331; x=1692105331; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EuEGC0t0GuK6IWAHo8+P/T94c6+EfLfZVasRqCS5Dng=; b=IHkZISEMSdAY3Nq7+bkDDJKi+twfjuw30pA3aDwcY40hi5UhWIHZsIEvrcVRu6BGdf llMwsklIqS3IogyYtXk4IOj2XfK083Pj3DfuTJxIsH/K+8bFJX0Vbu9CONo3mVrEw6GT ljxOd+0WrXBlRDe8lYM96VhTjyCMg4lPzXA+E6OlmtdL4QFHVC+N9kKOgV+f8VTmsAqE hwomM11QRGCbQTP+PXXWK8GKW3fots04TGxubIwm+iw+wzWsYWCIPSQSymsQlFCUkUQy xAMcNGvk22gmSUBzrUWSadyMu6h2WKrxLPFavwPeYmzjbW0HMBHT6BQLV2TOd/pTxqVb 1Vbw== X-Gm-Message-State: ABy/qLYXjZx8tBKImEeGQ6GrHQ00lwol7tW9+9AdkjyTj/uSUD+InrOi Dv3xz/V/ewav32JKClycE1T0ESeZmR1reHAL X-Google-Smtp-Source: APBJJlH0HGgirP/dFcT3aEID0ZOAw8CrkfFDFjr6zgQpmQmDEWNrKsCD9Wa3jmat2nWba+f58QX5Cg== X-Received: by 2002:a05:6808:192a:b0:3a4:26d1:4a9e with SMTP id bf42-20020a056808192a00b003a426d14a9emr11809813oib.38.1689513331147; Sun, 16 Jul 2023 06:15:31 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id y14-20020a056808130e00b003a1f1933957sm5844359oiv.16.2023.07.16.06.15.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 06:15:30 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265329 Archived-At: Thomas Fitzsimmons writes: > This test case shows the issue: > > (defcustom test-custom nil "" :type >   '(choice (alist >         :key-type (string :tag "key") >         :value-type (string :tag "value")) >            (const :tag "auto" nil))) > (customize-variable 'test-custom) > > The UI first shows: > > Hide Test Custom: Choice: Value Menu Alist: > INS >     State : STANDARD. > > Then if I choose "Value Menu", and option 1 to choose the "auto" const > value, I get: > > Hide Test Custom: Choice: Value Menu auto >     State : EDITED, shown value does not take effect until you set or save it. > > which is fine.  Then if I choose "Value Menu" again and choose 0 for the > Alist, I get: > > Hide Test Custom: Choice: Value Menu Alist: > INS DEL key: >             value: > INS >     State : EDITED, shown value does not take effect until you set or save it. > > I wasn't expecting: > > INS DEL key: >             value: > > If I then save the customization, test-custom is ("" . "").  I think it > should instead be nil. > Thanks for the bug report. > > It seems like after a const is shown, Customize considers the variable > "edited".  I don't know why it is adding those extra INS/DEL key/value > UI boxes though. The code currently ignores the value if it's present but nil. That's not good, obviously.  But it might be tricky to fix it because other widgets depend on the code ignoring it... I think it might be good to have a different property specify a default value (defaulting to :value upon creation, if not provided), and let :value be treated as of today, like the current value holder.