From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#18109: 24.4.50; `compilation-error-regexp-alist-alist': wrong regexp for Maven Date: Mon, 7 Dec 2020 14:49:40 +0100 Message-ID: <133EE4BE-AD7E-4197-9888-1E4CCC47BB90@acm.org> References: <5FFB3461-E756-4C09-9BFE-E0F9C840E533@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 18109@debbugs.gnu.org To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 07 14:50:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmGuQ-0008NJ-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 14:50:34 +0100 Original-Received: from localhost ([::1]:49116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmGuP-00027W-Bd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Dec 2020 08:50:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmGtu-00026N-FV for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 08:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41377) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmGtu-0004hu-7s for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 08:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmGtu-00033j-6E for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2020 08:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2020 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18109 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18109-submit@debbugs.gnu.org id=B18109.160734898911737 (code B ref 18109); Mon, 07 Dec 2020 13:50:02 +0000 Original-Received: (at 18109) by debbugs.gnu.org; 7 Dec 2020 13:49:49 +0000 Original-Received: from localhost ([127.0.0.1]:52923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmGth-00033F-2S for submit@debbugs.gnu.org; Mon, 07 Dec 2020 08:49:49 -0500 Original-Received: from mail156c50.megamailservers.eu ([91.136.10.166]:49984 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmGte-000330-8B for 18109@debbugs.gnu.org; Mon, 07 Dec 2020 08:49:48 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1607348983; bh=OjCXlgAVROq/JjjMYKDDVBUOJJRl08rdmHZbHfNJs5Q=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=DFIuG9yTlg7qfAV9LRt7pjU7d5jouW/KdOFx/w5KGN6FzCB7IjLU8QaXPH+equyIH tjQJvh4kDeBFWqhxUbLwhJDTlxqV9FvAfQhs5F65g7U6W07kbmSw7xWqNHYQfyOEf2 4TtoI3D4pAud8ZzIgC87keFeU24gQE6fMWEWjB3I= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0B7Dne4b011527; Mon, 7 Dec 2020 13:49:42 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F17.5FCE32F7.0080, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KvgzJleN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=vWT8KFaXwqab4tfkh3sA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195227 Archived-At: 7 dec. 2020 kl. 11.41 skrev Filipp Gunbin : > It was me who put there those quantifiers, and I don't object to = making > the regexps stricter. It would be unfair to blame you for that! After all, that's how most of = the other patterns were written, and for logical reasons: it seems = intuitive and sensible to make the rules as loose as possible in case = the format changes or there is otherwise a variation in the output. If = the observed messages contain a single space in one place then standard = practice has been to tolerate any number of spaces there, maybe even = zero. However, experience tells us that this intuition is wrong. Output = formats do in fact tend to remain unchanged: Emacs and other editors, = IDEs and other code are parsing them, and they are not all equally = tolerant or in the same way. There is thus a self-reinforcing effect: = the tool keeps output stable because we expect it to. (When output = formats do change, it tends to be for good reasons and regexp tolerance = is then rarely useful.) > But, we just need to be aware that Java tools usually don't expect the > output to be parsed. Yes they do! The very composition of something like the gradle-kotlin = output e: FILENAME: (LINE, COL): MESSAGE is so strict and formalised that it was definitely made with = machine-readability in mind. > That is why I'm more inclined to > making regexps more _lax_, not the other way around (and fix the > problems with them once they appear). As we have found out the hard way, the cost of lax patterns is insidious = and diffuse until the mess really has to be sorted out -- and by then = it's hard to get hold of the various people involved who have since long = disappeared or forgot all about what they wrote years ago. Patterns are = added independently of one another but interact in unexpected ways. Thus, better to keep patterns strict, and only alter them when and if = tool output changes; it is then clear exactly what needs to be done and = why. For most rules this never becomes necessary.