unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: 30660@debbugs.gnu.org, "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Subject: bug#30660: mention describe-bindings on (info "(emacs) Keymaps")
Date: Sat, 24 Aug 2019 08:06:19 -0700 (PDT)	[thread overview]
Message-ID: <13355700-914e-477e-99b6-c278b55e5563@default> (raw)
In-Reply-To: <CADwFkmk9d-1pELNOzj0cngTALgBJ_HrLu=JEb5HE3sp6Jcdphg@mail.gmail.com>

> I've now packaged up a proposed patch

Thanks for working on this.  Looks mostly OK to me.
However:

1. I object to the use of `C-h M' as the key binding.
   Please use `C-h M-k'.  The letter `M/m' has other,
   and more useful, associations (mode, mail, .  And
   `M' currently is translated to the often used
   `C-h m'.  `K' is often associated in Emacs with
   "key" or "kill".  And it's as easy to use Meta as
   it is to use Shift.

   [And users of `help-fns+.el', which has the same
   command but with additional features, are used to
   `C-h M-k'.  Because the vanilla version will lack
   those additional features I'll continue to maintain
   `describe-keymap' in `help-fns+.el'.  If those
   features are also added to vanilla Emacs someday
   then I won't need to maintain it.]

2. When testing with `emacs -Q' (but perhaps because
   I ran into the error of #3?), and also using
   `C-h f' etc., I somehow ended up with two [back]
   links at the bottom of *Help*, like this:

   [back]

   [back]

   Please check that what you end up with doesn't
   lead to this.

3. The code raises this error when KEYMAP is not a
   symbol and SEARCH-SYMBOLS-P is nil, because
   FILE-NAME is nil.

(describe-keymap isearch-mode-map) => 

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-name-nondirectory(nil)
  (if (eq file-name (quote C-source)) "C source code" (file-name-nondirectory file-name))
  ...

4. When fixing that bug, please be sure not to print
   a generated name ("KEYMAP OBJECT (no variable)")
   for a non-existent or not found variable.

5. When fixing that bug, if the keymap is fine, and
   it has a variable that is not defined in a file,
   don't try to print a file for it.  Don't try to
   print a file for the non-variable case either.

Wrt 3-5: It's not right to blindly print a variable
name and a file for it.  The code needs to handle
cases such as variable not given, no variable at all,
and variable not defined in a file.





  reply	other threads:[~2019-08-24 15:06 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 20:25 bug#30660: mention describe-bindings on (info "(emacs) Keymaps") 積丹尼 Dan Jacobson
2018-02-28 23:29 ` Drew Adams
2019-08-23  7:18 ` Stefan Kangas
2019-08-23 18:44   ` Drew Adams
2019-08-23 22:40     ` Stefan Kangas
2019-08-24  1:46       ` Drew Adams
2019-08-24  3:01         ` Stefan Kangas
2019-08-24 15:06           ` Drew Adams [this message]
2019-10-16 22:42             ` Stefan Kangas
2019-10-14 20:28           ` Lars Ingebrigtsen
2019-10-14 20:33             ` Eli Zaretskii
2019-10-17  9:39               ` Stefan Kangas
2019-10-17  9:42                 ` Stefan Kangas
2019-10-17 12:07                   ` Robert Pluim
2019-10-17 13:10                     ` Eli Zaretskii
2019-10-17 13:30                       ` Stefan Kangas
2019-11-07  0:18                         ` Stefan Kangas
2019-11-07  0:40                           ` Drew Adams
2019-10-17 13:00                 ` Eli Zaretskii
2019-11-07  1:00                   ` Stefan Kangas
2019-11-11 15:04                     ` Stefan Kangas
2019-11-14 11:12                       ` Eli Zaretskii
2019-11-17 20:36                         ` Stefan Kangas
2019-11-18 16:23                           ` Eli Zaretskii
2019-11-19  6:07                           ` Richard Stallman
2019-11-19 16:04                             ` Eli Zaretskii
2019-11-17 20:51                         ` Stefan Kangas
2019-11-18 16:20                           ` Eli Zaretskii
2019-11-19 14:14                             ` Stefan Kangas
2019-11-19 17:03                               ` Eli Zaretskii
     [not found]                                 ` <87zhen2h81.fsf@marxist.se>
2020-01-17  8:07                                   ` Eli Zaretskii
2020-01-18  2:16                                     ` Stefan Kangas
2020-01-18  8:31                                       ` Eli Zaretskii
2020-01-18  9:12                                         ` Stefan Kangas
2020-01-18  9:41                                           ` Eli Zaretskii
2020-01-18 23:42                                             ` Stefan Kangas
2020-01-19  2:09                                               ` Drew Adams
2020-01-31 10:15                                               ` Eli Zaretskii
2020-02-04  1:32                                                 ` Stefan Kangas
2019-10-14 20:50             ` Drew Adams
2019-10-16 22:48               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13355700-914e-477e-99b6-c278b55e5563@default \
    --to=drew.adams@oracle.com \
    --cc=30660@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).