unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Valtteri Vuorikoski <vuori@notcom.org>
To: 42045@debbugs.gnu.org
Subject: bug#42045: 27.0.91; display-format-alist for X11 does not recognize DISPLAY with IPv6 literal
Date: Thu, 3 Sep 2020 12:39:48 +0300	[thread overview]
Message-ID: <1323e778-a9f3-a593-874a-e1af48c2aa6f@notcom.org> (raw)
In-Reply-To: <m2o8mpef78.fsf@gmail.com>

On 9/1/20 5:36 PM, Robert Pluim wrote:
>>>>>> On Thu, 25 Jun 2020 22:20:05 +0300, Valtteri Vuorikoski <vuori@notcom.org> said:
> 
>      Valtteri> If the DISPLAY environment variable is to an IPv6 literal such as
>      Valtteri> [::1]:1, the regexp that x-win.el adds to the display-format-alist to
>      Valtteri> recognize X11 does not match, which results in breakage.
> 
>      Valtteri> x-win.el should probably add a second regexp to the alist, such as:
>      Valtteri> (add-to-list 'display-format-alist '("\\`\\[[^]]*\\]:[0-9]+\\(\\.[0-9]+\\)?\\'" . x))
> 
> That regexp won't work, since now youʼre requiring the '[' and ']' to
> be present.
> 
> "\\`\\[?[^]]*\\]?:[0-9]+\\(\\.[0-9]+\\)?\\'" would fix that, but since
> we donʼt really care what comes before the ':', so would
> 
> "\\`.*:[0-9]+\\(\\.[0-9]+\\)?\\'"

Yes, note "second regexp": the current regexp would remain and match 
other types of hostnames/addresses. But if no one cares about the format 
of the host part, your version is simpler.

  -Valtteri






  reply	other threads:[~2020-09-03  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 19:20 bug#42045: 27.0.91; display-format-alist for X11 does not recognize DISPLAY with IPv6 literal Valtteri Vuorikoski
2020-09-01 14:36 ` Robert Pluim
2020-09-03  9:39   ` Valtteri Vuorikoski [this message]
2021-06-12 13:12   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323e778-a9f3-a593-874a-e1af48c2aa6f@notcom.org \
    --to=vuori@notcom.org \
    --cc=42045@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).