From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Date: Wed, 19 Apr 2023 13:47:23 +0300 Message-ID: <1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev> References: <97545727-7123-ca74-3d2e-4ac5c6d8f25a@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29826"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Daniel Mendler , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , 62776@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 12:48:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pp5Mc-0007Vt-Ut for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 12:48:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pp5M5-0002uv-CQ; Wed, 19 Apr 2023 06:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp5M2-0002uQ-PD for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 06:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pp5M2-0003Ou-G5 for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 06:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pp5M1-00008e-S7 for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 06:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 10:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62776 X-GNU-PR-Package: emacs Original-Received: via spool by 62776-submit@debbugs.gnu.org id=B62776.1681901255346 (code B ref 62776); Wed, 19 Apr 2023 10:48:01 +0000 Original-Received: (at 62776) by debbugs.gnu.org; 19 Apr 2023 10:47:35 +0000 Original-Received: from localhost ([127.0.0.1]:32831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp5La-00005U-QR for submit@debbugs.gnu.org; Wed, 19 Apr 2023 06:47:35 -0400 Original-Received: from new4-smtp.messagingengine.com ([66.111.4.230]:56749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp5LY-000056-LW for 62776@debbugs.gnu.org; Wed, 19 Apr 2023 06:47:33 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 454C558236A; Wed, 19 Apr 2023 06:47:27 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 19 Apr 2023 06:47:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1681901247; x=1681904847; bh=3jYD8wlxaXkAPtKDA14zssUGp8z8WEZREvt /5DtPcsk=; b=eVQ0Q8iF7dXcStzSH5Dy9KH0HmNcPE4G4UyRjl7nflLfSZPqwgC 36A/A8P7zvAn4tKet0Z9hzVCENkZDVn0ROZ4bbirLx3Icd56W87SQZ5689yQ6Ci4 PYmLMeiW9aK6SUtUQN47EAdvUBmEsHw723cvBF94TcHSz0pNy5RFfj9ZA6eHjwHF +k2cnS20nZi6AIIn1jEoHBDFcz2cJjt8ktpwDGC3JEbWdqHy5dpOcNxeNfeDDOjK Isp5evoDSufb2gaWtuL95wbTScMq15tb42o5Z0z7wn0eKrjTkKFKpFoyqIZ+6MOV 4SQ3r2gYo+b2RQLhrLuGC2q72iEAGOhl6xw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681901247; x= 1681904847; bh=3jYD8wlxaXkAPtKDA14zssUGp8z8WEZREvt/5DtPcsk=; b=c vG0K4fRaibqTY095+ttFoba/xA36T3ONm1ecwvrU3swEOJCGBgYrq83+RQujWVK4 IjlAx8CGJMkNkc3ubGJ2dBy0bA40O8Gk/Tow+tv23YfMtSeEna8F2/Yzq0KyI+oC Dt0nhRu9vuwKkQFGK73mzDypM99WWg6YzNiPoXEDDAySh1eWGAWAcuvdrkl+BVpQ 02EnJP5jglzWus5pbnacqETnLwWLoY6tXC0KDWYtWEJxnGS+34QdSOhjO0OxqUw/ oL1HybIBwTJGqV43ngzqHT8ZGJBomZrhbgrzZAvsRtHFlayVolCEQl+YYykXcREX 5nWd5h00A1JYD9E7DYPQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedttddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepvdeljeelgeehtdduvdetudfgfeejje fgleevteehvdfhffelvdfhteevhffghfegnecuffhomhgrihhnpehgihhthhhusgdrtgho mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 06:47:25 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260264 Archived-At: On 19/04/2023 08:54, Daniel Mendler wrote: > On 4/19/23 03:54, Dmitry Gutov wrote: >> It's possible that vertico--history-hash is confused by our manipulation >> of the history entries -- like how they are stored as absolute file >> names now (bug#58447). > Yes, that's right. A tweak to the hash manipulation would be needed. On > the other hand we cannot handle all special cases in > vertico--history-hash. For such cases one can set the > vertico-sort-function or vertico-sort-override-function variables per > command. Right. I wasn't sure what the special-ness of this case is, though. At first I figured it might be because of the local binding for the history variable (this is something we changed recently, after all). But now it just looks like if the variable is 'file-name-history', the hash only takes the first segment of file names from it. E.g., when history looked like this at the beginning: ("lisp/progmodes/ruby-mode.el") the hash at the end is: #s(hash-table size 1 test equal rehash-size 1.5 rehash-threshold 0.8125 data ("lisp/" 0)) I'm guessing this change is responsible for that: https://github.com/minad/vertico/commit/0bc58baba1904cefefccc1cd5510d2e942c181f1 Perhaps there is some straightforward way to determine whether the current completion table stops at separators or not, to be used here.