From: Dmitry Gutov <dmitry@gutov.dev>
To: "Daniel Mendler" <mail@daniel-mendler.de>,
"Rudolf Adamkovič" <salutis@me.com>,
62776@debbugs.gnu.org
Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history'
Date: Wed, 19 Apr 2023 13:47:23 +0300 [thread overview]
Message-ID: <1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev> (raw)
In-Reply-To: <caf5099f-d1e5-0ae3-b26a-706b14ebe268@daniel-mendler.de>
On 19/04/2023 08:54, Daniel Mendler wrote:
> On 4/19/23 03:54, Dmitry Gutov wrote:
>> It's possible that vertico--history-hash is confused by our manipulation
>> of the history entries -- like how they are stored as absolute file
>> names now (bug#58447).
> Yes, that's right. A tweak to the hash manipulation would be needed. On
> the other hand we cannot handle all special cases in
> vertico--history-hash. For such cases one can set the
> vertico-sort-function or vertico-sort-override-function variables per
> command.
Right. I wasn't sure what the special-ness of this case is, though.
At first I figured it might be because of the local binding for the
history variable (this is something we changed recently, after all).
But now it just looks like if the variable is 'file-name-history', the
hash only takes the first segment of file names from it. E.g., when
history looked like this at the beginning:
("lisp/progmodes/ruby-mode.el")
the hash at the end is:
#s(hash-table size 1 test equal rehash-size 1.5 rehash-threshold
0.8125 data ("lisp/" 0))
I'm guessing this change is responsible for that:
https://github.com/minad/vertico/commit/0bc58baba1904cefefccc1cd5510d2e942c181f1
Perhaps there is some straightforward way to determine whether the
current completion table stops at separators or not, to be used here.
next prev parent reply other threads:[~2023-04-19 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 15:21 bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 1:18 ` Dmitry Gutov
2023-04-18 21:38 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-19 1:54 ` Dmitry Gutov
2023-04-19 5:54 ` Daniel Mendler
2023-04-19 10:47 ` Dmitry Gutov [this message]
2023-04-19 12:05 ` Daniel Mendler
2023-04-19 15:28 ` Dmitry Gutov
2023-04-19 15:46 ` Daniel Mendler
2023-04-19 15:49 ` Dmitry Gutov
2023-04-19 17:07 ` Daniel Mendler
2023-04-19 22:24 ` Dmitry Gutov
[not found] ` <handler.62776.D62776.168194305529292.notifdone@debbugs.gnu.org>
2023-04-24 9:20 ` bug#62776: closed (Re: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history') Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev \
--to=dmitry@gutov.dev \
--cc=62776@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).