From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Mauger Newsgroups: gmane.emacs.bugs Subject: bug#24646: [PATCH] Complete the name of PostgreSQL databases Date: Mon, 14 Nov 2016 15:51:52 +0000 (UTC) Message-ID: <1306009066.3273743.1479138712402@mail.yahoo.com> References: <1476006914.21082.0@smtp.gmail.com> <1477224054.3087.0@smtp.gmail.com> <960375478.674241.1477259422133@mail.yahoo.com> <1478443615.12208.0@smtp.gmail.com> <1356767530.1331843.1478491407910@mail.yahoo.com> <1478949102.7910.0@smtp.gmail.com> Reply-To: Michael Mauger NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1479140760 4414 195.159.176.226 (14 Nov 2016 16:26:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Nov 2016 16:26:00 +0000 (UTC) Cc: "alex@gnu.org" , "24646@debbugs.gnu.org" <24646@debbugs.gnu.org> To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 14 17:25:54 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6K4H-0003hs-DG for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Nov 2016 17:25:13 +0100 Original-Received: from localhost ([::1]:41201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6K4K-0004FM-E6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Nov 2016 11:25:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6JYE-0003Pz-4t for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:52:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6JYA-0001Xh-8M for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:52:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6JYA-0001Xb-4f for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c6JY9-0004zA-Tu for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2016 10:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Nov 2016 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24646 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24646-submit@debbugs.gnu.org id=B24646.147913872019157 (code B ref 24646); Mon, 14 Nov 2016 15:52:01 +0000 Original-Received: (at 24646) by debbugs.gnu.org; 14 Nov 2016 15:52:00 +0000 Original-Received: from localhost ([127.0.0.1]:57280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6JY8-0004yv-Ex for submit@debbugs.gnu.org; Mon, 14 Nov 2016 10:52:00 -0500 Original-Received: from nm16-vm3.bullet.mail.ne1.yahoo.com ([98.138.91.146]:53163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6JY6-0004yg-VP for 24646@debbugs.gnu.org; Mon, 14 Nov 2016 10:51:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1479138713; bh=pesvk+sIUp2RhJM5GB19OguBc6T69f93TPfZDXYE4IM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=Zs2SsQMXybVBDBYBiSkcA24u5JiQvB2Pz5X9S4RULYFjE6a9vv+qVBwOCP2LZKMc3xXwssI8ZcLp5ypdYGYNiNDJ1kAl7bMTgwf9Wx6BwGifYh+FwlC8a5Cqy2Y7ofudXq9Bg/h1n+cPRM1T0gqXnBtWaO5Ypl33cyaWga2ajHFT+cgFogVN1szwyB2MMF3shhmsTr67jpO8/3LaVUC5X/+XVblN35tDVmLp9KzmtqbjNdGFVTOS4v7h45vbcVW4l8g4kqHebXQl/akH/TmQypuziFoKmiMeitzJ6KAhymvtAZeeV5lx3vg+WCeThTs+DGI5hioXd0fDLMUTcC9oMg== Original-Received: from [98.138.100.118] by nm16.bullet.mail.ne1.yahoo.com with NNFMP; 14 Nov 2016 15:51:53 -0000 Original-Received: from [98.138.89.193] by tm109.bullet.mail.ne1.yahoo.com with NNFMP; 14 Nov 2016 15:51:53 -0000 Original-Received: from [127.0.0.1] by omp1051.mail.ne1.yahoo.com with NNFMP; 14 Nov 2016 15:51:53 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 156748.40902.bm@omp1051.mail.ne1.yahoo.com X-YMail-OSG: 1ghdR5MVM1lE9dhSguv0.IlQ3TTSoxKZm5VQ6JZZYH2bUqgdYBjVEYmm0n3ctpA 1isZL7D2cMs1pWkT5J2arh.pv3zIGcP.18Lny5AvABxkhiorIJUmVlcUScCkm7EnB8HQzDu9ulIT DuUfw1Ugb6fhWiyOyz3qhC1Gc4pIBqL3i58TWLgi1QLFjWHZnbSTeSB_4cRjE_l98O9xbb.WJ5Vo X2Rz18vUTPW1.isJKAJveuVpjrXoQNsqzzvx2Oym2BpI7b_NvTz5JjxTZS9sRYTRynEtqmJaNJ0t rAxah3KFaHFXZLKQIgM4ie591fIP1YAzzi.CxzcZKbSY1sD7YpKr.tIg3U3vLRDh3FghPB1_rR8P 0xubWES3zv4YuFwhwadyRQj39h2h9tONeZM7_0FcfvoLB0Yf1zVwu1W44CKTSaqJ5kpp3wXGZlao 3Wt5QJFhKdmum4erWhvD6zqtDxz9BAabjSwQHNQA5YFVp1t3dsGur.CdqXiKDSz5zPjGxBWv2r1H xkmNoCeyaK2QtT5KocPXZ_b5pi1XmpWZ8dfT1mlBO9LKJ4.moPj_TrJzpKHNhEOGj5Q-- Original-Received: from jws200076.mail.ne1.yahoo.com by sendmailws112.mail.ne1.yahoo.com; Mon, 14 Nov 2016 15:51:52 +0000; 1479138712.672 In-Reply-To: <1478949102.7910.0@smtp.gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125692 Archived-At: > On Saturday, November 12, 2016 6:12 AM, Simen Heggest=C3=B8yl wrote: > > Thank you for your detailed feedback, Michael. >=20 > I agree with all of your points and have modified the patch accordingly, > except for one: >=20 > On Mon, Nov 7, 2016 at 5:03 AM, Michael Mauger =20 > wrote: >> * `dolist' can specify the return value rather than having a separate= =20 >> expression after the loop. That is, (dolist (row (process-lines ...)=20 >> (nreverse res)) ...)) is equivalent to (dolist (row (process-lines=20 >> ...)) ...) (nreverse res) >=20 > I'm aware of it, but I tend to avoid using it, since I have many times > myself overlooked it when reading code that uses it. If it's OK with you > I'll leave it like it is, but if you insist I can change it. >=20 >> * I'm concerned about the change to the `completing-read' call in=20 >> `sql-get-login-ext'. Rather than `nil', I'd suggest=20 > `confirm' so that=20 >> if the value isn't in the list, it must be confirmed. >> * If the REQUIRE-MATCH parameter should really be something other=20 >> than `t', then possibbly we should add another keyword=20 >> :completion-required whose value would be used in the=20 >> `completing-read' call (default to `t' to preserve current=20 >> functionality). >=20 > It's not important to me. I made the change because I thought it could > be frustrating for the user if `sql-postgres-list-databases' doesn't > work as it should, but I realize now that changing it probably deserves > a discussion and a patch on its own. >=20 >=20 > -- Simen >=20 Looks good. Go ahead and commit this.=20 Thank you, I appreciate the contribution.=20 I'll take a look at making the completion REQUIRE-MATCH change separately; = I do think that control of completion behavior is needed here but it impact= s more than just database selection for Postgres. The advantage of adding a= keyword to the `sql-product-alist' is that the user can control the behavi= or to meet their preferences. --=20 MICHAEL MAUGER // FSF Member // GNU Emacs sql-mode maintainer // GNU Linux,= GNU Emacs