unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Josh <emacs@woolsweater.net>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: 58122@debbugs.gnu.org
Subject: bug#58122: 28.2; overlay before/after-string does not render more than one fringe display spec
Date: Wed, 28 Sep 2022 18:18:57 -0700	[thread overview]
Message-ID: <1302d235-9614-47d9-bc39-989d8ecba8a8@app.fastmail.com> (raw)
In-Reply-To: <83fsgbiplv.fsf@gnu.org>



On Wed, Sep 28, 2022, at 6:40 AM, Eli Zaretskii wrote:
> tags 58122 wontfix
> thanks
>
>> Date: Tue, 27 Sep 2022 11:05:10 -0700
>> From: "Josh Caswell" <emacs@woolsweater.net>
>> 
>> An overlay `before-string' or `after-string' property with both left and right fringe display specs only seems to render the first spec.
>> 
>> *Demonstration*:
>> - Launch GUI Emacs with the -q flag
>> - In an Elisp buffer, define these two commands
>> 
>> (defun insert-two-squares ()
>>   (interactive)
>>   (insert (propertize " " 'display [(left-fringe hollow-square)
>> 				    (right-fringe hollow-square)])))
>> 
>> (defun overlay-two-squares (right-first)
>>   (interactive "P")
>>   (remove-overlays)
>>   (let ((ov (make-overlay (point) (point)))
>> 	(specs [(left-fringe hollow-square)
>> 		 (right-fringe hollow-square)]))
>>     (overlay-put ov 'before-string
>> 		 (propertize " "
>> 			     'display
>> 			     (if right-first
>> 				 (reverse specs)
>> 			       specs)))))
>> 
>> - Switch to a new test buffer
>> - Invoke `insert-two-squares'; observe that both left and right fringes display a hollow square
>> - Delete the inserted character (fringe bitmaps disappear)
>> - Invoke `overlay-two-squares'; observe that only the left fringe displays a hollow square
>> - Invoke `overlay-two-squares' prefixed with `C-u'; observe that only the _right_ fringe displays the hollow square
>> 
>> The same behavior is seen if the overlay property is `after-string' rather than `before-string'.
>> 
>> *Expectation*:
>> Based on the display spec documentation I would expect the overlay to render fringes the same way as an inserted propertized string.
>
> Thank you for your report.
>
> This was never supported in Emacs. The reasons are subtle and very
> technical, and I will not go into them here.  Making this work as
> expected might be possible, but it would require changes on a very low
> level in the code that handles nested display properties and overlay
> strings, which is already extremely complicated.  I find changes of
> such nature unjustified for such a fringe (pun intended) use case.
>
> As an easy work-around, you can have 2 different overlay strings at
> the same position, like this:

Got it. I think this workaround should be sufficient. Thank you for the quick response!





  reply	other threads:[~2022-09-29  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 18:05 bug#58122: 28.2; overlay before/after-string does not render more than one fringe display spec Josh Caswell
2022-09-28 13:40 ` Eli Zaretskii
2022-09-29  1:18   ` Josh [this message]
2022-09-29  6:12     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302d235-9614-47d9-bc39-989d8ecba8a8@app.fastmail.com \
    --to=emacs@woolsweater.net \
    --cc=58122@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).