From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ikumi Keita Newsgroups: gmane.emacs.bugs Subject: bug#61210: 28.2; Request to modify code which can accidentally overwrite AUCTeX function Date: Wed, 01 Feb 2023 21:13:16 +0900 Message-ID: <13008.1675253596@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10625"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier To: 61210@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 01 13:14:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNC0O-0002Yj-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Feb 2023 13:14:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNC05-0006QV-9s; Wed, 01 Feb 2023 07:14:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNC02-0006Q5-Gs for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 07:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNC02-0002jD-4v for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 07:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNC01-0001sF-SD; Wed, 01 Feb 2023 07:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ikumi Keita Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Feb 2023 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61210 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.16752536117157 (code B ref -1); Wed, 01 Feb 2023 12:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Feb 2023 12:13:31 +0000 Original-Received: from localhost ([127.0.0.1]:56630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNBzW-0001rN-NQ for submit@debbugs.gnu.org; Wed, 01 Feb 2023 07:13:31 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNBzS-0001rB-SS for submit@debbugs.gnu.org; Wed, 01 Feb 2023 07:13:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNBzQ-0006MH-Pn for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 07:13:24 -0500 Original-Received: from smtp1a.inetd.co.jp ([210.129.88.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNBzN-0002JJ-V1 for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2023 07:13:24 -0500 Original-Received: from localhost (42-144-46-173.rev.home.ne.jp [42.144.46.173]) by smtp1a.inetd.co.jp (Postfix) with ESMTPA id AC4A05C for ; Wed, 1 Feb 2023 21:13:16 +0900 (JST) X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.2 Content-ID: <13006.1675253595.1@localhost> Received-SPF: pass client-ip=210.129.88.11; envelope-from=ikumi@ikumi.que.jp; helo=smtp1a.inetd.co.jp X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254570 Archived-At: I'm working on arranging AUCTeX to reconcile built-in tex modes better. One of the primary aim is to avoid clash of major mode name; for example, to change `latex-mode' to `LaTeX-mode'. In the course of reviewing the code, I realized the following problem. If we do that in natural ways like (define-derived-mode LaTeX-mode text-mode "LaTeX" ...) or (defun LaTeX-mode () ...) , it could wreak havoc because tex-mode.el has these lines: ---------------------------------------------------------------------- ;;;###autoload (defalias 'TeX-mode #'tex-mode) ;;;###autoload (defalias 'plain-TeX-mode #'plain-tex-mode) ;;;###autoload (defalias 'LaTeX-mode #'latex-mode) ---------------------------------------------------------------------- These defalias'es overwrite the AUCTeX definition unconditionally if tex-mode.el are loaded after AUCTeX. So AUCTeX has to do workarounds like ---------------------------------------------------------------------- (define-derived-mode TeX-latex-mode text-mode "LaTeX" ... (setq major-mode 'LaTeX-mode) ...) (defalias 'LaTeX-mode #'TeX-latex-mode) ---------------------------------------------------------------------- and advertise `LaTeX-mode' as its official name. (Additionally, we need some gotchas so that directory local variable entry like ((LaTeX-mode (...))) should work.) Hence I'd like to request to modify the built-in tex-modes.el to delete those lines, or at least to do fboundp test like (unless (fboundp 'LaTeX-mode) (defalias 'LaTeX-mode #'latex-mode)) in, say, emacs-30. If that is accepted, we can clean up the above workarounds in the future, when the least emacs version supported by AUCTeX becomes 30. Regards, Ikumi Keita #StandWithUkraine #StopWarInUkraine In GNU Emacs 28.2 (build 1, x86_64-unknown-freebsd13.1, GTK+ Version 3.24.= 33, cairo version 1.17.4) of 2022-09-15 built on freebsd.vmware Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: 13.1-RELEASE-p5 Configured using: 'configure --with-canna --with-canna-includes=3D/usr/local/canna/include --with-canna-libraries=3D/usr/local/canna/lib --without-xim --disable-largefile --without-modules --with-sound=3Dyes --with-file-notification=3Dyes CFLAGS=3D-O3' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBXML2 NOTIFY KQUEUE PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $EMACSLOADPATH: /home/keita/elisp: value of $LANG: ja_JP.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: shell-dirtrack-mode: t TeX-PDF-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: /home/keita/.emacs.d/elpa/transient-20230124.2013/transient hides /usr/loc= al/share/emacs/28.2/lisp/transient ~/elisp/reftex-parse hides /usr/local/share/emacs/28.2/lisp/textmodes/reft= ex-parse /home/keita/.emacs.d/elpa/soap-client-3.2.1/soap-inspect hides /usr/local/= share/emacs/28.2/lisp/net/soap-inspect /home/keita/.emacs.d/elpa/soap-client-3.2.1/soap-client hides /usr/local/s= hare/emacs/28.2/lisp/net/soap-client Features: (shadow emacsbug mh-thread supercite regi mh-identity mh-letter mh-comp sendmail reftex-sel reftex-ref reftex-parse preview reftex-dcr reftex-auc reftex reftex-loaddefs reftex-vars tex-bar toolbar-x noutline outline tex-mode shell pcomplete font-latex tex-jp latex easy-mmode latex-flymake flymake-proc flymake project compile comint ansi-color ring warnings tex-ispell tex-style tex texmathp latexenc mh-search qp mm-archive smiley mail-extr mh-mime mh-gnus mh-alias multi-prompt crm mh-show goto-addr thingatpt gnus-cite gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int message dired dired-loaddefs rfc822 mml mml-sec mm-decode mm-bodies mm-encode gmm-utils mailheader gnus-win gnus-range gnus nnheader wid-edit mh-seq mh-inc hl-line mh-tool-bar mh-xface mh-utils mh-folder which-func imenu gnus-util rmail rmail-loaddefs mail-utils text-property-search mh-scan mh-e mh-compat mailabbrev mh-buffers mh-loaddefs skeleton misearch multi-isearch conf-mode mule-util kinsoku cl-extra help-mode parse-time iso8601 time-date ucs-normalize epa derived epg rfc6068 epg-config url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm rmc puny jka-compr twittering-mode advice xml edmacro kmacro preview-latex tex-site canna-im info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib japan-util iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 823574 92247) (symbols 48 23600 10) (strings 32 129178 21854) (string-bytes 1 5678353) (vectors 16 74334) (vector-slots 8 1690475 62672) (floats 8 431 886) (intervals 56 20117 6833) (buffers 992 34))