unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler <mail@daniel-mendler.de>
To: Gregory Heytings <gregory@heytings.org>
Cc: arstoffel@gmail.com, 60021@debbugs.gnu.org
Subject: bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects
Date: Tue, 13 Dec 2022 14:46:52 +0100	[thread overview]
Message-ID: <12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de> (raw)
In-Reply-To: <ec23ed3e95683680b8a7@heytings.org>

On 12/13/22 00:34, Gregory Heytings wrote:
> 
>>> Thanks for your bug report.  Can you check that the attached patch 
>>> fixes that bug, without introducing other obvious regressions?
>>
>> Yes, in my quick tests it fixes both issues. But I am not familiar with 
>> the code in question. Hard to tell if it introduces other regressions. 
>> Maybe Augusto (cc'ed) could also take a look please?
>>
> 
> He already did, and although it fixes the two reported recipes, it's alas 
> not a proper fix for that bug.

Why is this not a proper fix? Is there some deep issue here? Is there a
chance that this could be fixed in a better way? I have never looked
deeply into the inner workings of Pcomplete, but from my experience the
Pcomplete Capf unfortunately is one of the buggiest Capfs provided by
Emacs. Nevertheless, I am a happy Eshell user. Completion in combination
with my Corfu UI works quite well, but I also employ some advices which
ignore errors in Pcomplete and prevent the Capf from modifying the buffer.

Daniel





  reply	other threads:[~2022-12-13 13:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 21:23 bug#60021: 29.0.60; Eshell completion errors in the presence of buffer redirects Daniel Mendler
2022-12-12 22:24 ` Gregory Heytings
2022-12-12 22:51   ` Daniel Mendler
2022-12-12 23:34     ` Gregory Heytings
2022-12-13 13:46       ` Daniel Mendler [this message]
2022-12-13 13:50         ` Gregory Heytings
2022-12-13 14:15           ` Daniel Mendler
2022-12-13 14:20             ` Gregory Heytings
2022-12-19 22:24               ` Gregory Heytings
2022-12-20  6:45                 ` Daniel Mendler
2022-12-20  8:55                   ` Gregory Heytings
2022-12-20  9:47                     ` Daniel Mendler
2022-12-20 10:00                       ` Gregory Heytings
2022-12-29 22:03                         ` Gregory Heytings
2022-12-30  4:42                           ` Daniel Mendler
2022-12-12 22:41 ` Augusto Stoffel
2022-12-12 22:45   ` Daniel Mendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12e425eb-1fdc-a014-cf9c-e3ccb026f3b0@daniel-mendler.de \
    --to=mail@daniel-mendler.de \
    --cc=60021@debbugs.gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).