From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Mon, 30 Sep 2024 13:11:18 +0300 Message-ID: <12b28146-5cbc-48cd-b0e2-0c528d4b9b1c@yandex.ru> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> <878qv9scps.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38482"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 12:12:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svDOW-0009r4-3I for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 12:12:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svDOJ-00059c-L4; Mon, 30 Sep 2024 06:12:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svDOH-000590-IE for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 06:12:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svDOH-0003TN-8z for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 06:12:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=O52qedS54GXq4We5BgyjRMTSzlgEn7/a1Iu0ADb7NEA=; b=j4z4+hf0K0rym2p+kShcg7xsMicqcBdZtyxHWhboQa9c8/95QGLbwdyWeUz4ke4oLZ5+aZqNnT09NtQgEkSbt7ioD6Z1XNj70zhELtyM/DwFpqoJTqXzh16VGcollK24doWEuUsNl+Ay4Spzb4prPtH73t23+3lZHFp/ipPg8bfczOOJBtJcvcTXORX7lo6u8aRPTx22XJ5bQgE6cQTNnGJiwGtQBauJ4sTQoAgpMc2RagY5SC6sNMve1FfpaUqynjPtTXR+Bd5OMsd41v3vK6XpIuRNrC/dS7ooSzCU536mCcrwmI6+SRMvg4vZZJBgEA0pI/TzVOvnsaUKE/uRYg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svDOn-0004bS-O6 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 06:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.172769115817634 (code B ref 73387); Mon, 30 Sep 2024 10:13:01 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 30 Sep 2024 10:12:38 +0000 Original-Received: from localhost ([127.0.0.1]:44765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svDOQ-0004aM-5s for submit@debbugs.gnu.org; Mon, 30 Sep 2024 06:12:38 -0400 Original-Received: from forward500d.mail.yandex.net ([178.154.239.208]:41152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svDON-0004aE-4n for 73387@debbugs.gnu.org; Mon, 30 Sep 2024 06:12:37 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:4214:0:640:6125:0]) by forward500d.mail.yandex.net (Yandex) with ESMTPS id 59C8660B26; Mon, 30 Sep 2024 13:11:28 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id OBWKLVjOnOs0-1mXfj9KY; Mon, 30 Sep 2024 13:11:27 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1727691087; bh=O52qedS54GXq4We5BgyjRMTSzlgEn7/a1Iu0ADb7NEA=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=cHTaY7O4EYonAJStnCHMkmxLVmVAGOmrEnIbHbxHPvJdAyv0EkBKr6AxIU/GJ47fj dNaRAGPmn5mc8q+BHC3cli6Nrs/oiJe0y6YlP07FpLD+//4iTvZ7TaRCBu40uuRphs HpAOuWQuQO9oht7NqmNj2mo/clHVp4Or7oSg4G2Q= Authentication-Results: mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id 03C071200043; Mon, 30 Sep 2024 06:11:23 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 30 Sep 2024 06:11:24 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduhedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrd hruheqnecuggftrfgrthhtvghrnhepiefhjeeuveetffffvdefteffffekhfeuudejieeh heeiudelgfehgffffeduffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvg igrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrd hnrghmvgdprhgtphhtthhopeejfeefkeejseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepmhhonh X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Sep 2024 06:11:21 -0400 (EDT) Content-Language: en-US In-Reply-To: <878qv9scps.fsf@melete.silentflame.com> X-Yandex-Filter: 1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292702 Archived-At: On 30/09/2024 12:38, Sean Whitton wrote: > Hello, > > On Mon 30 Sep 2024 at 03:27am +03, Dmitry Gutov wrote: > >> On 30/09/2024 02:46, Sean Whitton wrote: >>> Hello, >>> On Fri 27 Sep 2024 at 10:13pm +03, Dmitry Gutov wrote: >>> >>>>> What do you think about this: >>>>> - add a command which does the kill-all-but-this-hunk (or hunks in >>>>> region if mark active) thing -- it's generally useful. >>>>> - make C-x v v on a narrowed buffer, by default, issue a message saying >>>>> "Cannot commit patch when narrowed, consider " >>>> Or it would implement that previous alternative - using the modified buffer >>>> string that's limited to the current narrowing. >>>> >>>> I'm somewhat concerned about supporting both approaches (how different are the >>>> code paths going to be?), but if that's needed for usability, perhaps it's >>>> okay. >>> Hmm, I thought that we thought the modified buffer string approach was >>> too messy. Would you mind outlining your proposal as a whole and how it >>> differs from my most recent one? >> Actually, how about we start with your suggested steps, sans for the last one, >> for now. Meaning, just aborting with a message when the buffer is narrowed, >> without the user option. >> >> We would not be removing any existing functionality this way (this scenario >> didn't work before, after all), and we could add it later. >> >> Would that work for your habits/scenarios? > You mean, just adding the command which kills hunks? Just these two points: - add a command which does the kill-all-but-this-hunk (or hunks in region if mark active) thing -- it's generally useful. - make C-x v v on a narrowed buffer, by default, issue a message saying "Cannot commit patch when narrowed, consider "