From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66947: 30.0.50; Implement missing functions for custom-icon widget Date: Sun, 5 Nov 2023 19:38:32 -0300 Message-ID: <12657c3e-9874-4f45-9f1c-5d6e63c8409c@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Stefan Kangas , 66947@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 05 23:39:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzlmS-000096-Tr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Nov 2023 23:39:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzlmC-00048M-9Q; Sun, 05 Nov 2023 17:39:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzlmA-00047z-FJ for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 17:39:26 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzlmA-00026a-6o for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 17:39:26 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzlmk-0003gz-Gr for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 17:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2023 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66947 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66947-submit@debbugs.gnu.org id=B66947.169922396314141 (code B ref 66947); Sun, 05 Nov 2023 22:40:02 +0000 Original-Received: (at 66947) by debbugs.gnu.org; 5 Nov 2023 22:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:38325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzlm6-0003g1-Tw for submit@debbugs.gnu.org; Sun, 05 Nov 2023 17:39:23 -0500 Original-Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:50197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzlm4-0003fk-0l for 66947@debbugs.gnu.org; Sun, 05 Nov 2023 17:39:20 -0500 Original-Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-777745f1541so279990485a.0 for <66947@debbugs.gnu.org>; Sun, 05 Nov 2023 14:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699223917; x=1699828717; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=eKgh+mnrKhZsFBh6Na3HTobEdqfj7b/LNq8Yxm3oImA=; b=ZOSOGOgX2lz/4achAjzJ10a96eElibiKCXg1DyJhhMSmEO0/JWw6KJy5Q4m9RpQ6eo ZxX610JBY0TRq6R9qA43JQRmkzparBTAh2iPOMAGG7iM5jal3ENXTqpyU1DUuDh9+VHq kaG2KPilBUdZBU2N9EYd7AYs1OkIkCYjMQnHoweWTkpabw/uB0GFcN1ES3uhNt0Gxmqh zgY/LNVyBhEWajOjTpQ+5Vv+S2VA7U3hScbQQTDNNRxqJOwFnyf7AtTW7g7E4HrelzPz KVTPOlrVuLjUO3EGipbCYxcozx7yukBXoCLhdEbvVaSm/HdKfxF0+INhyV8SlGKu+dEU dc9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699223917; x=1699828717; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eKgh+mnrKhZsFBh6Na3HTobEdqfj7b/LNq8Yxm3oImA=; b=s4WPjf4oFG0ZGJay6UuR7Zl0PYoZf5v0sLsD5RIBN3ppfkHQQgKdodAcelLMICAunz F9ZoDYFwMGydylqWSUjQaFxoeymeNzuEUZgJPuT9meyNAkFGwfxsW4zogIxlBEXcNP9v Jj8U9OVk7xYTl9y6Kd1i8ih9GPEkHOyP8PlKO019VJMrAXv8vCMyREYc7RMjZRthxHfT E73J8e0I1bx8hnZsGoavRkLH79Io8Qk/0mF3pyrBH6oSOuKZEu9Xf0z6eASig2Ilzst7 Cw4JB+K0CWzmDci033KRDB7IeV/TNffMb6Mae1VZPzpmcMfl1geF5ubxB4tUhsgrlOqJ SeDA== X-Gm-Message-State: AOJu0YysXGDLJ0x/nuchramLTI/Y6MljTCzTNodcwQc270AxEHTF4glV K+FQbJ1ln+opjayKabBNi0Q= X-Google-Smtp-Source: AGHT+IEtvbGdG5rtFBzSTF0ucZtng+JewC+uwENqmEKLySWw/ysz6+w6a5ljNlOKpM75tNeAJV5MRw== X-Received: by 2002:ac8:5a4f:0:b0:419:a2c6:820e with SMTP id o15-20020ac85a4f000000b00419a2c6820emr32664965qta.12.1699223917064; Sun, 05 Nov 2023 14:38:37 -0800 (PST) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id r25-20020ac84259000000b0041b7f89ad19sm2843458qtm.53.2023.11.05.14.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Nov 2023 14:38:36 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273845 Archived-At: On 5/11/23 11:24, Stefan Kangas wrote: > Mauro Aranda writes: > >> There are some missing functions for the custom-icon widget to actually >> work when customizing icons: >> :custom-mark-to-save >> :custom-reset-current >> :custom-reset-saved >> :custom-state-set-and-redraw >> :custom-reset-standard >> :custom-mark-to-reset-standard >> >> I'll send a patch. > > Thanks.  Is this patch intended for emacs-29, like the last one? Ideally, yes.  It doesn't solve serious bugs, but it completes, I think, the Customizing icons functionality. It does solve some bugs, like: emacs (require 'outline) M-x customize-group RET outlines Edit an option and an icon. Action the State button and select Save for Future Sessions That errors with: widget-apply: Symbol’s function definition is void: nil That's because of a :custom-mark-to-save function missing for the custom-icon widget.