From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Xiyue Deng <manphiz@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 66782@debbugs.gnu.org
Subject: bug#66782: 29.1; ERT tests report test redefined depending on loading sequence
Date: Sun, 29 Oct 2023 13:09:11 +0100 [thread overview]
Message-ID: <121E7FF6-4D07-40D5-A2D9-1B108605A117@gmail.com> (raw)
In-Reply-To: <87wmv6fnrn.fsf@debian-hx90.lan>
28 okt. 2023 kl. 23.19 skrev Xiyue Deng <manphiz@gmail.com>:
> To clarify one of my
> original proposals: if it makes no sense for a `ert-deftest' to depend
> on other `ert-deftest', I would say there is no reason for such a
> dependency, and people should move reusable components to a helper
> module instead.
There is no reason for one `ert-deftest` to make use of another, but was that the case here? I interpreted it as a test suite that spread its `ert-deftest` definitions over multiple .el files which isn't necessarily a bad way of organising them.
As said before, there is little sense in including the same individual tests from multiple 'root' .el files since that would run them more than once.
Perhaps that is what you meant? If so, please forgive me for the pedantry.
next prev parent reply other threads:[~2023-10-29 12:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 20:59 bug#66782: 29.1; ERT tests reports test redefined depending on loading sequence Xiyue Deng
2023-10-28 6:32 ` Eli Zaretskii
2023-10-28 9:39 ` bug#66782: 29.1; ERT tests report " Xiyue Deng
2023-10-28 9:48 ` Eli Zaretskii
2023-10-28 11:14 ` Xiyue Deng
2023-10-28 11:34 ` Eli Zaretskii
2023-10-28 11:50 ` Xiyue Deng
2023-10-28 12:03 ` Eli Zaretskii
2023-10-28 12:46 ` Mattias Engdegård
2023-10-28 21:19 ` Xiyue Deng
2023-10-29 12:09 ` Mattias Engdegård [this message]
2023-10-29 21:53 ` Xiyue Deng
2023-10-30 12:04 ` Mattias Engdegård
2023-10-30 20:47 ` Xiyue Deng
2023-11-02 17:17 ` Xiyue Deng
2023-11-02 18:56 ` Mattias Engdegård
2023-11-02 22:00 ` Xiyue Deng
2023-11-03 17:14 ` Mattias Engdegård
2023-11-03 17:56 ` Xiyue Deng
2023-11-04 8:51 ` Eli Zaretskii
2023-10-28 19:41 ` Xiyue Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121E7FF6-4D07-40D5-A2D9-1B108605A117@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=66782@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manphiz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).