From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62399: =?UTF-8?Q?=E5=9B=9E=E5=A4=8D:?= bug#62399: 30.0.50; eglot + csharp-ts-mode, query pattern is malformed Date: Thu, 23 Mar 2023 09:57:36 +0200 Message-ID: <11ee8256-a2e0-a64c-dc33-b9dab57ad552@yandex.ru> References: <408E56C1-3216-4B0C-BD4C-C6E0E608BC51@outlook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5960"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: =?UTF-8?Q?=E7=89=9F_?= =?UTF-8?Q?=E6=A1=90?= , "62399@debbugs.gnu.org" <62399@debbugs.gnu.org>, Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 08:58:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfFq5-0001Lv-8O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 08:58:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfFpk-0005VN-KF; Thu, 23 Mar 2023 03:58:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfFpi-0005V4-Ne for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 03:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfFpi-0004PO-Bh for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 03:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfFpi-0004Ni-33 for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 03:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Mar 2023 07:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62399 X-GNU-PR-Package: emacs Original-Received: via spool by 62399-submit@debbugs.gnu.org id=B62399.167955826816823 (code B ref 62399); Thu, 23 Mar 2023 07:58:02 +0000 Original-Received: (at 62399) by debbugs.gnu.org; 23 Mar 2023 07:57:48 +0000 Original-Received: from localhost ([127.0.0.1]:37240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfFpU-0004NH-A7 for submit@debbugs.gnu.org; Thu, 23 Mar 2023 03:57:48 -0400 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:40908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfFpR-0004N2-U9 for 62399@debbugs.gnu.org; Thu, 23 Mar 2023 03:57:46 -0400 Original-Received: by mail-ed1-f45.google.com with SMTP id ew6so19841507edb.7 for <62399@debbugs.gnu.org>; Thu, 23 Mar 2023 00:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679558260; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=sRR0sFLN+80bL/QsOV2LhFrSt/ig4RAL9dRlmx/zfKE=; b=YAUnyVq2lWWYkkLnIZuD/n0bVvFUmNFg4YBm+u0b4E3M12OVo/ZF76u9ORxAwFzI6x yDnlfBNmAyPBMSf//wEAiHebZR7tozvXLxHBa/RyV+2aznOE7VWEOZ6WnictkHtIJsiK 04S8qlLV58EXaxmvsaR8SuIHMSX1DPGrzwPP5aPR2Mn3JgeJIGdtFmwM2vbAiAx/T5tB aSUTHGw5duMetMHj+KRy525yBgGdA/AQpn2PPB0389f+d20S3DVvW2veimg8cp0DdAIF Bbvnl2y9kfgEH9euz/hbSi8JTvrhmPOUR/JKAo2LdNj7zG7YanzW6qBNqM1fjTm/TpS4 /d/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679558260; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sRR0sFLN+80bL/QsOV2LhFrSt/ig4RAL9dRlmx/zfKE=; b=jG8KT+EkGfgEeuxi8SPv0YKotCPQCAd0xCEAFQlVYLL+eYf5ui/QU9ipOhXnyJ30Oa 2HDNdXMk7OFCfv4jwLENOg5yLsp1BNEAF0px6tvXbc5YZdkICqWtZEbTPn8cFPpkttHY J+ESSOUo5lNHBbePujnPL/+l1hUf3qj6+ySK4mi+8SywSHcvQ1zi9MYVRxqxFxuYPsP3 85aqQdpG+sifoPS4gChnyiZs0UF5vyGKJpRhkl2waXQrHjckfLRiCJMtezKBpfccuJuu pQ9Qx0V6AqopCbiAcCBjvkkyTpB/kwzWIG9AyVcWa9Gq1WBdM+W3m50uzJFNki66KQJO 2fjw== X-Gm-Message-State: AO0yUKXhkhwFHjkQwPSUYBeAJStosOjcNjFbF4eut+K7yBrcZSIizGhC Khak2u6p6uTVQYlkavrDzPM= X-Google-Smtp-Source: AK7set8YInu9ackNphsUgntekrEKCWw3HmBYOYjScITSgGqBhSP5CcpkXDmd9zRkM6eeOMKw0KhRLw== X-Received: by 2002:a17:906:161b:b0:8b2:7567:9c30 with SMTP id m27-20020a170906161b00b008b275679c30mr11497137ejd.59.1679558259549; Thu, 23 Mar 2023 00:57:39 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id hy22-20020a1709068a7600b008e53874f8d8sm8207076ejc.180.2023.03.23.00.57.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 00:57:38 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258441 Archived-At: On 23/03/2023 08:25, 牟 桐 wrote: > Ah sorry, here it is: > > ``` csharp-ts-mode > Console.WriteLine("Hello, World!"); > ``` > > (yes, just one line...) Thanks! I guess the problem will show up with any file. And I can repro after installing the c-sharp grammar from master. > The lsp I’m using is `csharp-ls`, I guess it won’t affect this issue. > > But just in case, the way to install `csharp-ls` is > >    dotnet tool install csharp-ls -g A language server was not necessary to reproduce this, but thanks. This is the patch that worked for me: diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 47cd13e7fdb..e2df08f4dae 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -832,7 +832,7 @@ csharp-ts-mode--font-lock-settings (constructor_declaration name: (_) @font-lock-type-face) - (method_declaration type: [(identifier) (void_keyword)] @font-lock-type-face) + (method_declaration type: [(identifier) (predefined_type)] @font-lock-type-face) (method_declaration type: (generic_name (identifier) @font-lock-type-face)) (method_declaration name: (_) @font-lock-function-name-face) Looks like a change was made to the grammar fairly recently which made (void_keyword) not valid in the above context: https://github.com/tree-sitter/tree-sitter-c-sharp/commit/18a531d4c133d9f1b3796b9bead7681ba3382fb3 Cc'ing the author of that mode for a second opinion. But I guess we'll need a runtime check just like we added for java-ts-mode recently.