From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame Date: Mon, 18 Jul 2022 09:37:35 +0200 Message-ID: <11e7e566-f626-fcf4-adfc-d03efa0d861c@gmx.at> References: <5d86d890-9a2e-e4d6-13fb-da03285ea003@gmx.at> <61fe102b-eec2-9711-560e-c141ed3cc6e4@gmx.at> <171bab25-5eb2-884b-5c32-bcfe4fed21cc@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1997"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Eli Zaretskii , 56305@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 18 09:38:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDLKb-0000Or-6O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jul 2022 09:38:17 +0200 Original-Received: from localhost ([::1]:36868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDLKZ-0005TL-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jul 2022 03:38:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDLKM-0005Sy-Gv for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 03:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDLKM-0000O9-7z for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 03:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDLKM-0002Cr-3p for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2022 03:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2022 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56305 X-GNU-PR-Package: emacs Original-Received: via spool by 56305-submit@debbugs.gnu.org id=B56305.16581298668459 (code B ref 56305); Mon, 18 Jul 2022 07:38:02 +0000 Original-Received: (at 56305) by debbugs.gnu.org; 18 Jul 2022 07:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:49108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDLK6-0002CM-CD for submit@debbugs.gnu.org; Mon, 18 Jul 2022 03:37:46 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:49641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDLK5-0002C9-0o for 56305@debbugs.gnu.org; Mon, 18 Jul 2022 03:37:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1658129856; bh=d6+iCQNiS3xURzU/OTaoow4g6e6RZ+O4CG3Go1boPos=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=gqNTd8F6bkIq863LuVaVSHiAppsFycsi2IGe4uwNMIy5D7x1HVoKNpcnhcZPE3H9r gfTZwQeWztatZoRWpYXB4Bg5hVqghCJe7LnebalgSimGeeTVCfyf4mSjtcGDAW0lEp cW/JZoOYNjrpBAZEVv03eNEe1YAwro37qH4OuR48= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([213.142.96.153]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M89L1-1o9Eix1ysN-005FjH; Mon, 18 Jul 2022 09:37:36 +0200 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:z5cKCRmqkG5cwGdlScdA9ew375al6c8b/mMHNpAp607MaT2CGCG RUXZxrgnSRHFRliFjL8SOSImWroSGq7MET6d+DtlaFzQn+OvAkAu8v7Q1WHax5j7OPhqDN5 K+bIXim2ic3kLTSJYZzGPsSb3wdRfGFLtB890m/q2d6/7F5aFUfGn1UJ64FmJ9Lh8YOZS3P PC4PwFuj6X6P4MxjhZoRQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:B3VcQKjofYs=:COn0gnMDhtGWYBODURZl7j 012qqoud03DKdvC6SWTOvjKYyKaGZNlRgnVVaKHvPKWDwth0UJr7hti4kTiohmVmWuChnoo/l mUuIFG7onmG4E61cThZY9/q6F58J2dRmBKpsx/auaIIVJI29kYW0VNzqeeEsLIEUs0GS9yubP qEnhh+sKT8CZDktrh2GHmqjl0xJ1bT8+qFqbA0KuWx2ed4D8kJjzK+EeosceN5sX0bag77O6C NUA7FDRDw7/i5zCccJoCKKfkWvtc+Ud6UJqdm/AeZzpnQI4boO0xb0uvRoPjiOI7mtOM9Ov8Z Ayj5avmQzpOMI0ibgfXo9qjH6b8eC+Q+hGBwnMa4e3e5SxDTsRBVwEvR0LGL2Gs3Vqi99pgw9 FK9MbFBzey4uc7/fs1EZjxmitiOMAWQgVVDZCoUqe3nSedtaIlCWx/VMxBERNeqJbyLUeKTy8 7Fzrq0V7KNxmTBrn92ubAs32UgolaCFfLe4Q1Ec8flkhgYQCXpYiYDJ5Y41LLrWjLxi81Q6/V 0kkvybrmFPJpS2DFf/BgNnNaKJzAoJQaNPlDehpo7xEl51lDndchoU/oQuF0Aq0PbVEH2+iUR V1JDWmFecYfpHFToth8Q+SXjlqlF3NfayyFd+StwRPoEPvO6uVR7wBIeEZY1dhqWf0v+CNEcS Ws03dqEMbRBiQzsHA0U/yoocoJ0unP2pkAoB9xrO7BgHPT9GxHhfGFeaIdDfBU8zW9BWTeTG3 ewfuRRH8DXWRZQ+ZMABUdd2vE//CMnl9DAQ0IE0LUJ2Uz1wlMVw38S6/Y9I9zUnDZBcV5Kl4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237330 Archived-At: > In case you intend to fix this apparent blunder of mine: the point of > that commit was to set the selected window and frame so that ELisp code > run from the `mode-line-format` would see meaningful and consistent > values of selected-frame/window (and companions like the > frame-selected-window of the selected-frame, ...). How are display_mode_line or display_mode_lines affected by that commit? As an aside: 'mode-line-format' claims that it is a Template for displaying mode line for current buffer. which is misleading at least. A mode line belongs to a window and reflects the values used for displaying a buffer in that window. Whatever consistency we want here is necessitated by the fact that redisplay has to set up the current buffer appropriately ('window-point' replacing the buffer's point, for example, so line numbers, percentages or 'which-func-mode' appear correct). Elisp code hardly cares. Worse even: People who want to know, for example, whether the mode line belongs to the selected window have to use 'old-selected-window' for getting that. Whether a window is "really" selected is ultimately hidden by Kim's face trick for displaying selected/non-selected windows' mode lines. And by no means I'd ask for changing this. But a better explanation in the doc-strings and the manual should be in order. End of the aside. > If calling `Fselect_window` with a non-nil `norecord` argument messes > things up somehow then maybe we should fix `Fselect_window` accordingly, > or otherwise provide a "more bare bones" function that DTRT. > > It seems clear to me, for example, that when called with a non-nil > `norecord` (like in the mode-line code), `Fselect_window` should never > cause any change to the focus redirection (or the focus itself). NORECORD is not about focus. > And neither should it call things like `resize_mini_window`, I think. > >> In the sequel, obscure bugs began to pile up, all very difficult to >> describe and reproduce (Bug#23124, Bug#24285, Bug#34317) and were fixed >> with some trickery. The origin of all that evil remained in place. > > I can't see the connection between these bugs at the above commit, sorry. They are a direct result of x/gui_consider_frame_title calling Fselect_window calling resize_mini_window and were fixed by binding 'inhibit-redisplay' appropriately in x/gui_consider_frame_title. martin