From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Date: Sun, 5 Feb 2023 23:56:47 +0200 Message-ID: <11c83963-752c-e4c0-40a0-876b32a08017@yandex.ru> References: <6209c097-0369-828a-7513-d8afb73fd7f0@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61302@debbugs.gnu.org To: Randy Taylor , jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 05 22:57:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOn0h-0004xU-IU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Feb 2023 22:57:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOn0V-0000Pf-1R; Sun, 05 Feb 2023 16:57:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOn0Q-0000PP-Vv for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOn0Q-00018a-M5 for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOn0Q-0001Et-Hk for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61302 X-GNU-PR-Package: emacs Original-Received: via spool by 61302-submit@debbugs.gnu.org id=B61302.16756342174747 (code B ref 61302); Sun, 05 Feb 2023 21:57:02 +0000 Original-Received: (at 61302) by debbugs.gnu.org; 5 Feb 2023 21:56:57 +0000 Original-Received: from localhost ([127.0.0.1]:46628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOn0L-0001EV-BP for submit@debbugs.gnu.org; Sun, 05 Feb 2023 16:56:57 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:39934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOn0J-0001EI-V0 for 61302@debbugs.gnu.org; Sun, 05 Feb 2023 16:56:56 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id hn2-20020a05600ca38200b003dc5cb96d46so9526287wmb.4 for <61302@debbugs.gnu.org>; Sun, 05 Feb 2023 13:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=ZVEG6gEQvr8VGWfRZQSzD+3EvSG2aZOUX7FgR16+xro=; b=oFecfSQatBtVK194MRikwy3BGaaGcu7yLiVbylY4sLzAh6QBau+adnWPtmuB9/9ZnG 6N1Y0fXPfRcmm73JrG3TraH3k6hKvL5tS/DXm6ODvMQC68qpuVRCV2NztTcRo6V3AYd8 wzQ3Iawg4TK204I0GRw/cEGhwXX43i3fmLiZEKhWjz7gH5ybY8Kdzeoxr2uwCg7QmOWb 4MqXl3OqY3rKzdUHbKevIAyDocHE8JG+iszslQjDj8/vh4KlqYE/6ZljiLiSaPLHfLvv +PXAmdAcjlX6NQgI6nToDXOnU65qLTzg+MDovtBT//uKrBNmgsBmzpAvmNaYkZU+pIA7 EMjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZVEG6gEQvr8VGWfRZQSzD+3EvSG2aZOUX7FgR16+xro=; b=iyTa6/IIk1sIDRCrDxskoyk1fEjTnkpxqDkOr/b1bJRO3wSdvtRY4Cqz2Y2cq1Nv23 ergdOLeBZRo8+C0xtk4tKSkyFo8ZnDs+o4mlMZ0U4cZzPwuUIkHjcE90hOkxHOf2IPU7 46SvonwtbnaT3ma1nFeY3aWBNFzKSmmAIHZMEFPtoSXTviRixQtrTMpiR/dNrPHANSAy nfI6eyGDn8NK5MRfXKh9THKnLv7qnQWjXeiv3uyLfsXn3xYf2QrOZRwxXpAZI9qs8KrS HUvkllVupG78+0EGRHyICcJAT+KVFL/52necExB4u85ihK/zY10C/B1x767k3tgD7Jn2 8wcQ== X-Gm-Message-State: AO0yUKUsEqLVWFGuJAvAKa2mLqtM9goUD3X+p9l5YHLylkacuoTIqq3C DyiV2OxJKV9ca0+KJbHVoEA= X-Google-Smtp-Source: AK7set/ET490lq0Hhre7U0c3xt4XoHoxumNG//D7TzU5cKHBaYcfxJa0gNsqrGH0oI4HOarKxIvZ8g== X-Received: by 2002:a7b:ca54:0:b0:3dc:2b62:ee9f with SMTP id m20-20020a7bca54000000b003dc2b62ee9fmr17494011wml.3.1675634209973; Sun, 05 Feb 2023 13:56:49 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f21-20020a05600c43d500b003dc0cb5e3f1sm9012295wmn.46.2023.02.05.13.56.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Feb 2023 13:56:49 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254899 Archived-At: Hi Randy, Maybe I was too quick to commit the change. But let's discuss it. On 05/02/2023 23:30, Randy Taylor wrote: > That's expected (at least to me) because it's a property. It's both a property and a function, isn't it? > The same > applies to c-ts-mode and go-ts-mode as well. Regarding c-ts-mode, it might be a simple oversight, given that constructs like p->handler (it) do not come up very often. But if we take js-ts-mode, for example, where a property is often a function, the property name is highlighted as a function in a funcall. And speaking of c-ts-mode, this can fix that omission: diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el index 5093c3980b6..3740130be30 100644 --- a/lisp/progmodes/c-ts-mode.el +++ b/lisp/progmodes/c-ts-mode.el @@ -470,7 +470,9 @@ c-ts-mode--font-lock-settings :language mode :feature 'function '((call_expression - function: (identifier) @font-lock-function-name-face)) + function: + [(identifier) @font-lock-function-name-face + (field_expression field: (field_identifier) @font-lock-function-name-face)])) :language mode :feature 'variable