From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug Date: Sun, 1 May 2016 08:11:17 -0800 (GMT-08:00) Message-ID: <11c4e4d7-8fc6-4d87-a761-b81781f77aee@default> References: <8E0945F19B9F4E37BA18A7A2232F6411@us.oracle.com> <87pot92wqw.fsf@gnus.org> <87eg9l3i8e.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1462119164 6463 80.91.229.3 (1 May 2016 16:12:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 May 2016 16:12:44 +0000 (UTC) Cc: 13670@debbugs.gnu.org, Lars Ingebrigtsen To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 01 18:12:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awtyw-0006Og-Fo for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 18:12:30 +0200 Original-Received: from localhost ([::1]:33563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awtys-0007kl-Dv for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 12:12:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awtyj-0007bw-36 for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 12:12:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awtyX-0005d1-5p for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 12:12:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awtyX-0005bU-1m for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 12:12:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awtyT-0006xH-NF for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 12:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2016 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13670-submit@debbugs.gnu.org id=B13670.146211908726692 (code B ref 13670); Sun, 01 May 2016 16:12:01 +0000 Original-Received: (at 13670) by debbugs.gnu.org; 1 May 2016 16:11:27 +0000 Original-Received: from localhost ([127.0.0.1]:60834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awtxv-0006wS-L0 for submit@debbugs.gnu.org; Sun, 01 May 2016 12:11:27 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:43446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awtxt-0006wD-Vt for 13670@debbugs.gnu.org; Sun, 01 May 2016 12:11:26 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u41GBKoM028614 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 1 May 2016 16:11:20 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u41GBJ8H006199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 1 May 2016 16:11:20 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u41GBIgK019060; Sun, 1 May 2016 16:11:19 GMT In-Reply-To: <87eg9l3i8e.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117515 Archived-At: > The emacs-25 version of `autoload-generate-file-autoloads' does not > contain a call to `char-after', so I think it has been rewritten in the > meantime. >=20 > Moreover, if I let Emacs generate file autoloads for a file with this > content: >=20 > #+begin_src emacs-lisp > ;;;###autoload (autoload 'icicle-mode "icicles" > ;;;###autoload"Icicle mode: Toggle minibuffer input completion and > cycling. > ;;;###autoloadNon-nil prefix ARG turns mode on if ARG > 0, else off. > ;;;###autoloadIt is a global minor mode. It binds minibuffer keys." > ;;;###autoloadt nil) > #+end_src >=20 > (update-file-autoloads > "/home/micha/today/test.el" > nil > "/home/micha/today/test-auto.el") >=20 > the result looks like this: >=20 > #+begin_src emacs-lisp > (autoload 'icicle-mode "icicles" > "Icicle mode: Toggle minibuffer input completion and cycling. > Non-nil prefix ARG turns mode on if ARG > 0, else off. > It is a global minor mode. It binds minibuffer keys." > nil) > #+end_src >=20 > So this generates a sane docstring. >=20 > Is this acceptable? Absolutely. Based on what you say, I'll close the bug. Thx.