unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 13670@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug
Date: Sun, 1 May 2016 08:11:17 -0800 (GMT-08:00)	[thread overview]
Message-ID: <11c4e4d7-8fc6-4d87-a761-b81781f77aee@default> (raw)
In-Reply-To: <87eg9l3i8e.fsf@web.de>

> The emacs-25 version of `autoload-generate-file-autoloads' does not
> contain a call to `char-after', so I think it has been rewritten in the
> meantime.
> 
> Moreover, if I let Emacs generate file autoloads for a file with this
> content:
> 
> #+begin_src emacs-lisp
> ;;;###autoload (autoload 'icicle-mode "icicles"
> ;;;###autoload"Icicle mode: Toggle minibuffer input completion and
> cycling.
> ;;;###autoloadNon-nil prefix ARG turns mode on if ARG > 0, else off.
> ;;;###autoloadIt is a global minor mode.  It binds minibuffer keys."
> ;;;###autoloadt nil)
> #+end_src
> 
> (update-file-autoloads
>   "/home/micha/today/test.el"
>    nil
>   "/home/micha/today/test-auto.el")
> 
> the result looks like this:
> 
> #+begin_src emacs-lisp
>  (autoload 'icicle-mode "icicles"
> "Icicle mode: Toggle minibuffer input completion and cycling.
> Non-nil prefix ARG turns mode on if ARG > 0, else off.
> It is a global minor mode.  It binds minibuffer keys."
>  nil)
> #+end_src
> 
> So this generates a sane docstring.
> 
> Is this acceptable?

Absolutely.  Based on what you say, I'll close the bug.  Thx.





      reply	other threads:[~2016-05-01 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10  0:03 bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug Drew Adams
2016-04-28 22:29 ` Lars Ingebrigtsen
2016-04-29 16:11   ` Drew Adams
2016-05-01 15:34     ` Michael Heerdegen
2016-05-01 16:11       ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11c4e4d7-8fc6-4d87-a761-b81781f77aee@default \
    --to=drew.adams@oracle.com \
    --cc=13670@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).