unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 32106@debbugs.gnu.org, Boruch Baum <boruch_baum@gmx.com>
Subject: bug#32106: 25.2: tabulated-list-resize-current-column [PATCH INCLUDED]
Date: Mon, 24 Jun 2019 08:51:04 -0700 (PDT)	[thread overview]
Message-ID: <11ba7555-6b7a-45d9-8306-da4f519e2e09@default> (raw)
In-Reply-To: <m3r27jvyks.fsf@gnus.org>

> Looks good.  I've now added some documentation and then pushed these
> changes to the trunk.
> 
> Finding the right key pair to bind these one was a struggle, though.
> w/n would be natural for widen/narrow, right?  But n is taken.  So I
> thought e/s for expand/shrink?  s is taken in *Buffer List* buffers,
> which is probably the most prominent use case for the mode.
> 
> So I went with w/c for widen/contract, but that's a bit eh...
> 
> Bikeshedding is welcome!

FWIW, I'm not sure these commands should be bound
by default.  `tabulated-list-mode' is a helper mode.
It's used by other modes (user-defined major modes)
to build specific kinds of tables.

Of course, you can say that if we bind, say, `+'
and `-' in `tabulated-list-mode' then a mode that
derives from it can always rebind such keys.  And
`t-l-m' already binds some keys, as does its parent
mode, `special-mode'.

Still, I'm not sure binding more keys in `t-l-m' is
a good idea.  (I don't oppose it; just not convinced.)
In its defense, users can get used to such keys that
then work (by default) across all or most uses of
`t-l-m'.

If you do decide to bind these commands in `t-l-m'
then I'd suggest that the two keys be _obvious_
opposites (so, maybe not `w' and `c').  It's not
important that they be easy to type (e.g., they can
use modifiers), but it's helpful if their keys are
repeatable (by just pressing and holding).

FWIW, I used `+' and `-' for the same purpose in
my library `buff-menu+.el' (which I had to abandon
when `buff-menu.el' moved to use `t-l-m', as `t-l-m'
is too simplistic and rigid for some `buff-menu+.el'
features).






      parent reply	other threads:[~2019-06-24 15:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 15:56 bug#32106: 25.2: tabulated-list-resize-current-column [PATCH INCLUDED] Boruch Baum
2018-07-09 17:22 ` Eli Zaretskii
2018-07-09 18:42   ` Boruch Baum
2019-06-23 23:06 ` Lars Ingebrigtsen
2019-06-24  2:56   ` Drew Adams
2019-06-24  5:29     ` Boruch Baum
2019-06-24 13:56       ` Drew Adams
2019-06-24 14:37     ` Lars Ingebrigtsen
2019-06-24 15:07       ` Boruch Baum
2019-06-24 16:03         ` Lars Ingebrigtsen
2019-06-25 19:35           ` Juri Linkov
2019-06-25 20:32             ` Lars Ingebrigtsen
2019-06-24 15:51       ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11ba7555-6b7a-45d9-8306-da4f519e2e09@default \
    --to=drew.adams@oracle.com \
    --cc=32106@debbugs.gnu.org \
    --cc=boruch_baum@gmx.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).