From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call Date: Sun, 25 Dec 2022 23:29:21 +0200 Message-ID: <1191195d-1528-dc2a-64e0-15426e4b5608@yandex.ru> References: <4e44df18-207c-c7ca-0588-7285f3008dfb@yandex.ru> <358bbd65-9375-04c8-f0a2-24a4383f142e@yandex.ru> <2b4a91e1-bad1-382f-dd64-abf171efb404@yandex.ru> <60e207e0-7378-ad9f-3ef0-99df1c139939@yandex.ru> <902440c7-706a-20e1-55af-4e12e8cdda2c@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: aaronjensen@gmail.com To: 60321@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 25 22:30:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9YZb-0002Bw-5e for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Dec 2022 22:30:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9YZI-0005ij-Gu; Sun, 25 Dec 2022 16:30:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9YZH-0005iY-Pm for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2022 16:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9YZH-0006zB-9v for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2022 16:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p9YZG-0002e6-Rh; Sun, 25 Dec 2022 16:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: aaronjensen@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Dec 2022 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60321 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: aaronjensen@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.167200376910074 (code B ref -1); Sun, 25 Dec 2022 21:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Dec 2022 21:29:29 +0000 Original-Received: from localhost ([127.0.0.1]:50199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9YYj-0002cP-7B for submit@debbugs.gnu.org; Sun, 25 Dec 2022 16:29:29 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:45608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9YYh-0002cF-Ql for submit@debbugs.gnu.org; Sun, 25 Dec 2022 16:29:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9YYh-0005fS-Le for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2022 16:29:27 -0500 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9YYf-0006oM-QV for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2022 16:29:27 -0500 Original-Received: by mail-wm1-x32a.google.com with SMTP id fm16-20020a05600c0c1000b003d96fb976efso4267156wmb.3 for ; Sun, 25 Dec 2022 13:29:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=FaKgCphL0BiOAeir2i+HxIhDZi6RNovCtJwBDIlsq54=; b=GTxjojhXDlfoTvh9CA+uP4M20fDOiiVN+1CUCcVb5ZT7Q/HCNJcrwT7wr5bfN6OQoq B/126N+qpZ2aOWxytKbzy8DUlQXOnve6jC7weSp3pjktFMspC3jJo7qlc0/GbwondNtJ 3Pog3pygDobUcyzZyP1huthDg83WFkHG/+5n2onkcEXXX+bfcsCSoi2uogsS94WDnqeM ovTjw09zPy80dx0xa/IezaFiNt8TrW9LpSjgHZA8/n7uICZonvHgre3YxZx4Qs1QvVxH 812mr9jDGUNkhiwCxgtr4aknCfzxiavtgn34j2+Kx8DkCrxzRS6qlBzJcCM5h4ronKXF o95A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FaKgCphL0BiOAeir2i+HxIhDZi6RNovCtJwBDIlsq54=; b=SL6b9q+/L0Ui+j+PshfpLWWSLgQizIKc26ENF5j+UyxSuPKBsNGW7UM60LJdeh5l3E AfDDMb5rA5gc7lvQb/eSA1ioWWuloA/eOOi5E7Cg+OW5WcK9SXs9HS1oBiMSsezFEjkv 9T9tIbQY23WwCS0Cg8pT+geC/rn7nhaltM4pjfJGMUWOSCchSqP8J6Egegr/M1W/33xL 4Iev8qlke146RaCepc98428BsjdLBqQYYjtSlQpzI2h+Ti5ejjY0QtUDiRaiwwMJqeHu UTuuVWCcxck7cn4TjdftdRKrKWSHPGtC6p46iPykJtqZphyyiKd9Tct/hgYVBe8wJliU 2I8Q== X-Gm-Message-State: AFqh2krHX7gTKIgg8QCkxopuvoXRpZExoQJqyC0cU40IkoV1q99F5gxg dwOVPo4SyqIwMBGqzeP56PgdqROyuAg= X-Google-Smtp-Source: AMrXdXtnsZx4pCtANiI6O6dRZaTbKsMgWEZhWmnkOdxLJbS6iSlV2xJQ3mLAu7jJJ1KlZ8g2kwpBWw== X-Received: by 2002:a05:600c:4255:b0:3d3:3d34:5d63 with SMTP id r21-20020a05600c425500b003d33d345d63mr12225413wmm.8.1672003763127; Sun, 25 Dec 2022 13:29:23 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v26-20020a7bcb5a000000b003cf4eac8e80sm13697165wmj.23.2022.12.25.13.29.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Dec 2022 13:29:22 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251871 Archived-At: X-Debbugs-CC: aaronjensen@gmail.com Splitting off from debbugs#60186, second try. Since this setting also seems orthogonal to the "simplified" preference, and it'll require some more work. For future reference, here are the relevant Rubocop settings: https://docs.rubocop.org/rubocop/cops_layout.html#layoutfirsthashelementindentation https://docs.rubocop.org/rubocop/cops_layout.html#layoutfirstarrayelementindentation On 25/12/2022 02:12, Aaron Jensen wrote: >> We could also discuss cases like >> >> foo = bar({ >> tee: 1, >> qux: 2 >> }) >> >> baz([ >> 1, >> 2, >> 3 >> ]) >> >> but those would be an orthogonal feature. And I don't see them much in >> the wild, for some reason. > The same logic would apply. It doesn't matter how many indent starters > there are in a line, the indentation should only increase by one: > > > foo = bar({ > tee: 1, > qux: 2 > }) > > baz([ > 1, > 2, > 3 > ]) > > Of course, that begs the question what happens if you do this: > > baz([ > 1, > 2, > 3 > ] > ) Here are a couple trickier examples: takes_multi_pairs_hash(x: { a: 1, b: 2 }) and_in_a_method_call({ no: :difference }, foo, bar) AFAICT even Rubocop doesn't have a setting which would indent the second one somewhat reasonably, while keeping two-space indent before "no". > And, I think again, the answer is a social one, rather than a technical one. > > enh-ruby-mode and vim both do this this: > > baz([ > 1, > 2, > 3 > ] > ) Yup, that looks pretty bizarre. OTOH, I don't see why a developer would put a newline between "]" and ")" in this case.