From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Date: Tue, 24 May 2016 11:09:00 -0400 Message-ID: <1181b6a8-c007-fbec-cb25-991a716c7b14@cornell.edu> References: <83futj5mcl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1464102625 24704 80.91.229.3 (24 May 2016 15:10:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 May 2016 15:10:25 +0000 (UTC) Cc: 23540@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 24 17:10:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b5DyH-0004pC-Su for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 May 2016 17:10:14 +0200 Original-Received: from localhost ([::1]:53765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5DyG-0005A1-BW for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 May 2016 11:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5DxF-0004Ri-Qz for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:09:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Dx8-0000GT-8e for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:09:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Dx8-0000GO-5S for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b5Dx7-0004wh-Vz for bug-gnu-emacs@gnu.org; Tue, 24 May 2016 11:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 May 2016 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23540 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23540-submit@debbugs.gnu.org id=B23540.146410253619000 (code B ref 23540); Tue, 24 May 2016 15:09:01 +0000 Original-Received: (at 23540) by debbugs.gnu.org; 24 May 2016 15:08:56 +0000 Original-Received: from localhost ([127.0.0.1]:36532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5Dx2-0004wO-7a for submit@debbugs.gnu.org; Tue, 24 May 2016 11:08:56 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:49486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5Dx1-0004wB-4M for 23540@debbugs.gnu.org; Tue, 24 May 2016 11:08:55 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4OF8mD0015494; Tue, 24 May 2016 11:08:48 -0400 Original-Received: from [192.168.1.5] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4OF8kje023735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 24 May 2016 11:08:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 In-Reply-To: X-PMX-Cornell-Gauge: Gauge=XXXXX X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118617 Archived-At: On 5/15/2016 1:08 PM, Ken Brown wrote: > On 5/15/2016 12:15 PM, Eli Zaretskii wrote: >> Ffind_operation_coding_system includes an explicit test for the 4th >> argument to be an integer: >> >> if (!(STRINGP (target) >> || (EQ (operation, Qinsert_file_contents) && CONSP (target) >> && STRINGP (XCAR (target)) && BUFFERP (XCDR (target))) >> || (EQ (operation, Qopen_network_stream) && INTEGERP (target)))) >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> error ("Invalid argument %"pI"d of operation `%s'", >> XFASTINT (target_idx) + 1, SDATA (SYMBOL_NAME (operation))); >> >> This should obviously be augmented, now that the value can also be t. > > Presumably the documentation of open-network-stream should also be > updated to reflect this. I hesitate to do this myself without knowing > for sure that t is an acceptable value for all calls to > open-network-stream. I'd rather leave it for someone more familiar with > the code, like Lars. I went ahead and installed the obvious fix, to get rid of the test failure. I'm leaving the bug open because someone knowledgeable still needs to update the documentation of open-network-stream. Ken