From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root Date: Tue, 22 Sep 2020 22:48:32 +0300 Message-ID: <11761d79-1893-fdf3-843d-bea4a026fc7f@yandex.ru> References: <0b1c72d0-f8fb-a256-1563-1c43296c8edb@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18717"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 43464@debbugs.gnu.org To: Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 21:49:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKoHp-0004mU-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 21:49:13 +0200 Original-Received: from localhost ([::1]:34580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKoHn-0007nn-SK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 15:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKoHe-0007mT-Eo for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 15:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKoHe-0003y2-5b for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 15:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKoHe-0008NM-4c for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 15:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 19:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43464-submit@debbugs.gnu.org id=B43464.160080412432172 (code B ref 43464); Tue, 22 Sep 2020 19:49:02 +0000 Original-Received: (at 43464) by debbugs.gnu.org; 22 Sep 2020 19:48:44 +0000 Original-Received: from localhost ([127.0.0.1]:33468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKoHM-0008Mq-Gn for submit@debbugs.gnu.org; Tue, 22 Sep 2020 15:48:44 -0400 Original-Received: from mail-lf1-f42.google.com ([209.85.167.42]:39853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKoHI-0008Ma-Oj for 43464@debbugs.gnu.org; Tue, 22 Sep 2020 15:48:42 -0400 Original-Received: by mail-lf1-f42.google.com with SMTP id q8so19367015lfb.6 for <43464@debbugs.gnu.org>; Tue, 22 Sep 2020 12:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2g3ItPsXoY+o+rQDDU92YjwCyDOPP90a40uS/+yj/x4=; b=mBZAQ8TTEBD+KOV2dx7YQG4+O1MhB41uKge91gFVth1NufnkhSP3iiCZr3lPz4Juw4 0Ez7TX2hbVvhWjyWQ4zN6OlRLT5XjLsrHLDKR/hqPHemdBWGyuNFrpU7ttZLfKVURrwP OqUI2q7/f36V34QldPONx7ENfehhBt9ah8CyCpMdqkIFnP+1IHIdoD4AnpBPWq7izasx e2tOGdNWx0KIQ57fvj8FnTiaaMGodBdxtT5FN+GqDhFDlj+RnUzZUAk21o6NYY02VfRY g37eBnxgC773IvGk5RuBFcz9pf9WM0fkGoyr46tw8MRcSVIG9EqQ+VRh5BZRXHZ6/s3q R20A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2g3ItPsXoY+o+rQDDU92YjwCyDOPP90a40uS/+yj/x4=; b=m241aA+A7ZuwTcOt2qZ1UBKJM01hNB1PhxS/zXq9ENXp0ITeK6BLQSJLNxn/LUa/0q EV0rDFSWvMwwHPHih/HlVeTZ4ojmI9IK2GiQinenUccFQGvBNu3aNtYtNMaSHD/YrgSa EH9QXzPDEQBIdHqjztz7Z+Uf72Nj+WkURtDxF9L2f9SSb97Ff2kBKVyqqtJlZStuz7HX kxEEI+qZpvvJMZlg8xkoPRSwmSm51Jb/NT/NQs451ISS4tPGmybENIYDaffqohDzb7QW bj1Mjt3xw6/LQzFQeEsjin771Wd/0S6Qal6JOu7zphcrC9L7hL89c1+not7S3tDtWEC+ WOvg== X-Gm-Message-State: AOAM532SEcNtiA2MBxew0+FhzC9xl3Y8npZ1ObLi6CeOuDwRL0z3fAf2 DY/1XlpbKY1IDMTIkE/cf8bhOBXPfL+JCg== X-Google-Smtp-Source: ABdhPJyyEC9rR1cKUUg27kEIFD0NzuIHug3GuEN6PtNoCtkh81hmjFm53M1iRfA53JY0en9SAwWTXQ== X-Received: by 2002:a19:7b16:: with SMTP id w22mr2082620lfc.418.1600804114218; Tue, 22 Sep 2020 12:48:34 -0700 (PDT) Original-Received: from [192.168.0.104] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id q7sm3815687lfr.16.2020.09.22.12.48.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 12:48:33 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188743 Archived-At: On 18.09.2020 18:45, Andrii Kolomoiets wrote: > Dmitry Gutov writes: > >> On 18.09.2020 12:30, Andrii Kolomoiets wrote: >>> Calling `vc-git-revert` or `vc-hg-revert` directly with repo root or any >>> directory within repo works fine. >> >> True. That's how Git and Hg work anyway. >> >> I'm not saying the current situation is ideal, but we'd either have to >> give up any attempt to revert a directory (with a more appropriate >> message), or somehow differentiate between different backends where it >> would or wouldn't work. > > BTW vc-revert is also works fine in Git repo when point is on > subdirectory. So for the vc-git only reverting repo root is not > working. That's an interesting observation. > Please see attached patch which make it possible for vc-hg to revert > directory. Could you explain both changes in that patch? And also: how does it change, or not change, the behavior of vc-revert in backends that are not Git or Hg?