unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 34949@debbugs.gnu.org
Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete
Date: Fri, 21 Feb 2020 02:16:28 +0200	[thread overview]
Message-ID: <115a6be6-3b64-7409-c405-19cfabf1a98d@yandex.ru> (raw)
In-Reply-To: <87imk35uy6.fsf@mail.linkov.net>

On 19.02.2020 1:36, Juri Linkov wrote:

>> You can check out what diff-hl-dired does in this regard (and it does use
>> the dir-status-files command), though you would need to do something else
>> than its merging logic.
> 
> Thanks, I use diff-hl-dired, but not realized it relies on dir-status-files.
> Maybe dir-status-files could be simplified, so that it wouldn't require
> a special buffer to be current, and could be called in any buffer,
> but this simplification is not much needed.

I'd rather not change the calling convention of existing, old backend 
actions without solid necessity.

>> That still leaves the downside (compared to VC-Dir) of being unable to
>> select individual files in subdirectories, but that's not fixable, I guess.
> 
> When calling the already supported ‘C-x v =’ (vc-diff) on a subdirectory
> in Dired, it operates on all modified files, so it makes sense to commit
> exactly the same files whose diffs are displayed in the *vc-diff* buffer.

Not exactly my style, but okay.

>> I think the only possible problem here is that lambda is invoked
>> asynchronously. But we can sleep while waiting for it.
> 
> Would it be possible to call dir-status-files synchronously?

I think when we discussed this once, the "ideal" change would be for 
such actions to return "process" objects, which could be then consumed 
either synchronously or synchronously by the caller. But that's far off.

Until then, calling sleep-for in a loop should get us close enough.





  parent reply	other threads:[~2020-02-21  0:16 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 17:50 bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Philipp Stephani
2019-10-09 22:40 ` Lars Ingebrigtsen
2019-12-24 19:53   ` Dmitry Gutov
2019-12-24 23:28     ` Juri Linkov
2020-02-17 23:42       ` Juri Linkov
2020-02-18 22:27         ` Dmitry Gutov
2020-02-18 23:36           ` Juri Linkov
2020-02-20 23:14             ` Juri Linkov
2020-02-21  0:22               ` Dmitry Gutov
2020-02-23  0:04                 ` Juri Linkov
2020-02-23  9:01                   ` Dmitry Gutov
2020-02-23 23:25                     ` Juri Linkov
2020-02-24  0:17                       ` Dmitry Gutov
2020-02-25  0:12                         ` Juri Linkov
2020-02-25 10:32                           ` Dmitry Gutov
2020-02-25 21:23                             ` Juri Linkov
2020-02-26 22:49                               ` Dmitry Gutov
2020-02-26 23:46                                 ` Juri Linkov
2020-02-27  7:28                                   ` Dmitry Gutov
2020-02-27 23:15                                     ` Juri Linkov
2020-02-28 19:22                                       ` Dmitry Gutov
2020-02-29 21:25                                         ` Juri Linkov
2020-02-29 22:25                                           ` Dmitry Gutov
2020-03-09 22:55                                             ` Juri Linkov
2020-03-12  0:08                                               ` Dmitry Gutov
2020-03-12  0:41                                                 ` Juri Linkov
2020-03-12 22:43                                                   ` Juri Linkov
2020-03-13 12:11                                                     ` Dmitry Gutov
2020-03-14 23:31                                                       ` Juri Linkov
2020-03-15 21:54                                                         ` Dmitry Gutov
2020-03-15 23:58                                                           ` Juri Linkov
2020-03-16 20:17                                                             ` Dmitry Gutov
2020-03-24 22:16                                                               ` Juri Linkov
2020-03-25 20:47                                                                 ` Juri Linkov
2020-03-25 21:32                                                                   ` Dmitry Gutov
2020-03-29 22:35                                                                     ` Juri Linkov
2020-03-30 19:53                                                                       ` Dmitry Gutov
2020-03-24 22:36                                                               ` Juri Linkov
2020-03-25 20:59                                                                 ` Juri Linkov
2020-03-25 21:15                                                                   ` Drew Adams
2020-03-25 21:50                                                                     ` Juri Linkov
2020-03-25 22:04                                                                       ` Drew Adams
2020-03-26 23:18                                                                         ` Juri Linkov
2020-03-27 16:11                                                                           ` Drew Adams
2020-03-27 22:41                                                                   ` Dmitry Gutov
2020-03-28 23:54                                                                     ` Juri Linkov
2020-03-29 18:41                                                                       ` Dmitry Gutov
2020-03-29 22:27                                                                         ` Juri Linkov
2020-03-30 20:01                                                                           ` Dmitry Gutov
2020-03-30 22:40                                                                             ` Juri Linkov
2020-03-30 23:22                                                                               ` Dmitry Gutov
2020-03-31  1:02                                                                               ` Drew Adams
2020-04-02 22:08                                                                             ` Juri Linkov
2020-04-03  0:21                                                                               ` Dmitry Gutov
2020-04-03 20:08                                                                               ` Philipp Stephani
2020-04-04 23:37                                                                                 ` Juri Linkov
2020-04-05  9:47                                                                                   ` Philipp Stephani
2020-04-05 23:05                                                                                     ` Juri Linkov
2020-04-09  8:41                                                                                   ` Eli Zaretskii
2020-04-11 23:38                                                                                     ` Juri Linkov
2020-04-12  6:33                                                                                       ` Eli Zaretskii
2020-04-12 23:51                                                                                         ` Juri Linkov
2020-04-13  4:31                                                                                           ` Eli Zaretskii
2020-04-13 23:25                                                                                             ` Juri Linkov
2020-03-25 21:59                                                                 ` Dmitry Gutov
2020-03-26 23:10                                                                   ` Juri Linkov
2020-03-26 23:51                                                                     ` Dmitry Gutov
2020-02-21  0:16             ` Dmitry Gutov [this message]
2019-12-25 21:45     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=115a6be6-3b64-7409-c405-19cfabf1a98d@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=34949@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).