From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#32002: 24.4; Scroll bar start, end not correct Date: Sun, 15 Jul 2018 18:47:56 -0700 Message-ID: <11390.1531705676@alto> References: <20180629073602.GA21394@sfu.ca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Trace: blaine.gmane.org 1531705630 29548 195.159.176.226 (16 Jul 2018 01:47:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Jul 2018 01:47:10 +0000 (UTC) Cc: 32002@debbugs.gnu.org, kurn@sfu.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 16 03:47:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fesbR-0007bV-7a for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2018 03:47:05 +0200 Original-Received: from localhost ([::1]:48467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fesdX-0000yQ-Is for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jul 2018 21:49:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fesdN-0000yA-LP for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2018 21:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fesdK-0008Hr-Gq for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2018 21:49:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fesdK-0008HM-Bm for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2018 21:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fesdJ-0001Tb-T6 for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2018 21:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jul 2018 01:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32002 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 32002-submit@debbugs.gnu.org id=B32002.15317056865610 (code B ref 32002); Mon, 16 Jul 2018 01:49:01 +0000 Original-Received: (at 32002) by debbugs.gnu.org; 16 Jul 2018 01:48:06 +0000 Original-Received: from localhost ([127.0.0.1]:42170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fescP-0001SP-VQ for submit@debbugs.gnu.org; Sun, 15 Jul 2018 21:48:06 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:18693 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fescN-0001SG-Uw for 32002@debbugs.gnu.org; Sun, 15 Jul 2018 21:48:04 -0400 Original-Received: from alto (96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id w6G1luLI004489 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 15 Jul 2018 18:48:01 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133] claimed to be alto In-Reply-To: Your message of "Sat, 14 Jul 2018 09:49:00 +0300." <83r2k6b9cz.fsf@gnu.org> X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 26.1 Content-ID: <11389.1531705676.1@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148552 Archived-At: Eli Zaretskii wrote: > > From: Mike Kupfer > > cc: Andrew Kurn , 32002@debbugs.gnu.org > > Date: Fri, 13 Jul 2018 21:56:40 -0700 > > > > With > > > > (setq scroll-bar-adjust-thumb-portion nil) > > > > the thumb takes up the entire track. (I'm doing this testing with a > > theme that lacks steppers.) Moving the mouse down (while holding > > button1) does not move the thumb, but it does cause the text to scroll > > up. Moving the mouse up (while holding button1) does not cause the text > > to reappear, even if I move the mouse all the way to the top of the > > thumb. [...] > Which part of scroll-bar-toolkit-scroll gets executed when you move > the thumb up, after scrolling the entire text out of the window? [...] It's ((eq part 'handle) (scroll-bar-drag-1 event)))) > [...] in which case I think the problem is in > scroll-bar-drag-1. Can you spot it? I think it calculates the new > starting point of the window incorrectly, because it doesn't take into > account the special situation with scroll-bar-adjust-thumb-portion in > this particular case. What I see is that in scroll-bar-drag-1, portion-whole is (1 . 1), both when I drag the mouse down and when I drag it up. So scroll-bar-drag-1 always does (goto-char (point-max)). Should scroll-bar-drag-1 be doing the correction to account for scroll-bar-adjust-thumb-portion, or should that be done higher up the stack? (If scroll-bar-drag-1 needs to apply a correction, then I suspect there are other functions that also need to apply a correction. Perhaps it would be cleaner to make the correction early on, so that it only needs to be done once. But I'm not familiar with the code, so there may well be aspects to this that I'm missing.) mike