From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sat, 29 Oct 2022 09:32:52 -0700 Message-ID: <11379.1667061172@alto> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28024"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 29 18:34:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooomr-00075U-UB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Oct 2022 18:34:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooomc-0004aj-Oh; Sat, 29 Oct 2022 12:34:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooomY-0004Z3-GA for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 12:34:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooomY-0003at-1D for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 12:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooomX-0007ze-Ot for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 12:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2022 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166706118230656 (code B ref 58721); Sat, 29 Oct 2022 16:34:01 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 29 Oct 2022 16:33:02 +0000 Original-Received: from localhost ([127.0.0.1]:36471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooola-0007yO-Eb for submit@debbugs.gnu.org; Sat, 29 Oct 2022 12:33:02 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:37659 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooolX-0007xw-H8 for 58721@debbugs.gnu.org; Sat, 29 Oct 2022 12:33:00 -0400 Original-Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 29TGWqXL033688 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 29 Oct 2022 09:32:57 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto In-Reply-To: Your message of "Sat, 29 Oct 2022 18:48:35 +0300." <83mt9ehbqk.fsf@gnu.org> X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 Content-ID: <11378.1667061172.1@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246554 Archived-At: Eli Zaretskii wrote: > > From: Mike Kupfer > > Date: Sat, 29 Oct 2022 08:24:53 -0700 > > > > I played with this some more this morning, this time on Emacs 29. It > > looks like rename-file should have called copy-directory as > > > > copy-directory("/tmp/emacs-git" > > "/home/kupfer/.local/share/Trash/files/emacs-gitH0lx1e/" t nil t) > > I don't think we can change how rename-file behaves when the argument > is a directory. Any changes we need to make must be in > move-file-to-trash, not in primitives it calls. Yes, that makes sense. So... (rename-file "a" "/tmp/newa" t) gives the original error. (rename-file "a" "/tmp/newa/" t) gives us /tmp/newa/a/b. What we want is /tmp/newa/b. I can think of 2 ways forward. One is to add an optional argument to rename-file to get the desired behavior, like the copy-contents argument to copy-directory. The other is for move-file-to-trash to call rename-file on the top-level contents of the directory that is being trashed ("a/b" in my simple test case), rather than on the directory itself. I think the first approach is preferable, in that it parallels the definition of copy-directory. But either should work. mike