From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Matt Bisson Newsgroups: gmane.emacs.bugs Subject: bug#37359: [PATCH] Fix ignored Motif scrollbar resources. Date: Tue, 10 Sep 2019 09:26:21 -0400 (EDT) Message-ID: <1110040707.1460241.1568121981762.JavaMail.zimbra@zimbra.ccs.neu.edu> References: <581256029.1395514.1568053627475.JavaMail.zimbra@zimbra.ccs.neu.edu> <8b0afa0a-f4d5-2beb-fc30-ab9c58b7e84f@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31148"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37359@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 10 15:30:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i7gDi-0007x0-K8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Sep 2019 15:30:10 +0200 Original-Received: from localhost ([::1]:39856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7gDh-0007Pj-0t for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Sep 2019 09:30:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7gDb-0007Pd-9d for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2019 09:30:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7gDa-0004CS-96 for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2019 09:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i7gDa-0004CO-6F for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2019 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i7gDa-0005mf-0R for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2019 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matt Bisson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Sep 2019 13:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37359-submit@debbugs.gnu.org id=B37359.156812215222137 (code B ref 37359); Tue, 10 Sep 2019 13:30:01 +0000 Original-Received: (at 37359) by debbugs.gnu.org; 10 Sep 2019 13:29:12 +0000 Original-Received: from localhost ([127.0.0.1]:41061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i7gCl-0005ky-QU for submit@debbugs.gnu.org; Tue, 10 Sep 2019 09:29:12 -0400 Original-Received: from amber.ccs.neu.edu ([129.10.116.51]:44498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i7gCj-0005ko-Sh for 37359@debbugs.gnu.org; Tue, 10 Sep 2019 09:29:10 -0400 Original-Received: from zimbra.ccs.neu.edu ([129.10.117.202]) by amber.ccs.neu.edu with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1i7gBQ-0008GP-Cc; Tue, 10 Sep 2019 09:29:48 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.ccs.neu.edu (Postfix) with ESMTP id 77B1A1B2001F; Tue, 10 Sep 2019 09:26:23 -0400 (EDT) Original-Received: from zimbra.ccs.neu.edu ([127.0.0.1]) by localhost (zimbra.ccs.neu.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zyvsaccueii1; Tue, 10 Sep 2019 09:26:22 -0400 (EDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.ccs.neu.edu (Postfix) with ESMTP id 3EE9F1B20020; Tue, 10 Sep 2019 09:26:22 -0400 (EDT) X-Virus-Scanned: amavisd-new at zimbra.ccs.neu.edu Original-Received: from zimbra.ccs.neu.edu ([127.0.0.1]) by localhost (zimbra.ccs.neu.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7YEe7EhJ2P5b; Tue, 10 Sep 2019 09:26:22 -0400 (EDT) Original-Received: from zimbra.ccs.neu.edu (localhost [127.0.0.1]) by zimbra.ccs.neu.edu (Postfix) with ESMTP id 0F69B1B2001F; Tue, 10 Sep 2019 09:26:22 -0400 (EDT) In-Reply-To: <8b0afa0a-f4d5-2beb-fc30-ab9c58b7e84f@gmx.at> X-Originating-IP: [144.121.38.226] X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF69 (Linux)/8.6.0_GA_1153) Thread-Topic: bug#37359: [PATCH] Fix ignored Motif scrollbar resources. Thread-Index: 9EfRsAIIBIrIN60IdmRBapiOM/wJeg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166346 Archived-At: > I suppose that you have not done any copyright assignment so I'll mark this as a tiny change. >From the copyright assignment page, it seems reasonable to call this a tiny change, so I didn't do the assignment: > We can accept small changes (roughly, fewer than 15 lines) without an assignment. This is a cumulative limit (e.g., three separate 5 line patches) over all your contributions. If you prefer, I can go through that process as well. Whatever is easier. > Sounds reasonable so I intend to install it. When you say "install" do you mean you are going to test it, and I should push to the repo (which I am completely willing to do), or do you mean you are going to commit the patch when ready? (The patch is against the emacs-26 branch, btw.) Thanks, -Matt ----- Original Message ----- From: "martin rudalics" To: "mbisson" , 37359@debbugs.gnu.org Sent: Tuesday, September 10, 2019 3:56:03 AM Subject: Re: bug#37359: [PATCH] Fix ignored Motif scrollbar resources. > On Motif scrollbars, "foreground" has no meaning, while "background" > means the truck and arrow colors, and "trough" means the background > of the entire widget. I have hooked up the Emacs scrollbar > "foreground" color to the XmNbackground resource, and the > "background" color to XmNtroughColor. This is more in line with how > Xaw scrollbars behave. Sounds reasonable so I intend to install it. I suppose that you have not done any copyright assignment so I'll mark this as a tiny change. Thanks, martin