From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Donald Curtis Newsgroups: gmane.emacs.bugs Subject: bug#14082: 24.3; Package dependences calculated in reverse Date: Fri, 5 Apr 2013 10:27:38 -0500 Message-ID: <110E0219-69CB-4A85-AF3B-9A074704575C@coe.edu> References: <75CA5373-3097-48D1-AB94-0018583483B1@coe.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1365278714 30735 80.91.229.3 (6 Apr 2013 20:05:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:05:14 +0000 (UTC) Cc: 14082-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 22:05:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZJd-0001KY-4l for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2013 22:02:21 +0200 Original-Received: from localhost ([::1]:38378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO8Yg-0005SG-Qt for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2013 11:28:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO8YV-0005P4-0r for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2013 11:28:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO8YN-0007Lr-GY for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2013 11:27:54 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO8YN-0007Lj-Cx for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2013 11:27:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UO8bW-0008Qz-Hf for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2013 11:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Donald Curtis Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2013 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14082-done@debbugs.gnu.org id=D14082.136517586132414 (code D ref 14082); Fri, 05 Apr 2013 15:31:02 +0000 Original-Received: (at 14082-done) by debbugs.gnu.org; 5 Apr 2013 15:31:01 +0000 Original-Received: from localhost ([127.0.0.1]:35710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO8bV-0008Ql-C9 for submit@debbugs.gnu.org; Fri, 05 Apr 2013 11:31:01 -0400 Original-Received: from mail-ia0-f172.google.com ([209.85.210.172]:35061) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO8bS-0008Qc-JH for 14082-done@debbugs.gnu.org; Fri, 05 Apr 2013 11:30:59 -0400 Original-Received: by mail-ia0-f172.google.com with SMTP id l29so3337247iag.31 for <14082-done@debbugs.gnu.org>; Fri, 05 Apr 2013 08:27:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:content-type:mime-version:subject:from:in-reply-to:date :cc:content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=wMW2gLrEaZoCSD06HHjM5/s09bkbtMuBfIz1ftc2GWQ=; b=W2rYCsQkk4LjUnK+UuhedEio2EiVDGpdxAr7cY1+Ofy35rzwAfcAtxtZa/Mc9I8Kxm aX+Z1VkRmAdcZvRkIllegGBjpEPesQOI2oDcwTsxMPrztjzfuOEgqREWNRBE5ZiSpCSP qSfWx6H274Bhza4RDjUY8KRJEZuvGp/lb0PCnUIDIBZFZ3MgzKvf4J5wKRZ3xccZ+1NY A1bGcRCKGjuzqgHziAolqAKf2cqLazkN3NjA2x5ZiivHvj4+IlCImFpiCS1K+cGdEB7b tTyQUwZRzdczaH0OzbY6qu6fWyGjwEePsF0NLckLxwpvoz1GgpHvK84cVQzQjxrMBZj5 DHHg== X-Received: by 10.50.17.234 with SMTP id r10mr1780243igd.102.1365175662215; Fri, 05 Apr 2013 08:27:42 -0700 (PDT) Original-Received: from [172.16.14.104] ([192.133.84.6]) by mx.google.com with ESMTPS id qs4sm3078860igb.10.2013.04.05.08.27.39 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Apr 2013 08:27:40 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.1503) X-Gm-Message-State: ALoCoQk2ZWzBgttjrBW3xPtHyGMqvdfRY+pOPDAq2vKogeTnpDPbmwMOtThttpiLFAPVmVf9smXU X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73212 Archived-At: It appears the bug is still happening because if the package already = exists then the new code will not get called because it is wrapped in = the `unless'. The following patch works perfectly for me. It just always = adds the package to the front. diff --git a/package.el.orig b/package.el index ab17ec1..064e1db 100644 --- a/package.el.orig +++ b/package.el @@ -810,11 +810,10 @@ but version %s required" (symbol-name next-pkg) (package-version-join next-version) (package-version-join (package-desc-vers (cdr = pkg-desc))))) ;; Only add to the transaction if we don't already have it. - (unless (memq next-pkg package-list) - (setq package-list - ;; Move to front, so it gets installed early enough - ;; (bug#14082). - (cons next-pkg (delq next-pkg package-list)))) + (setq package-list + ;; Move to front, so it gets installed early enough + ;; (bug#14082). + (cons next-pkg (delq next-pkg package-list))) (setq package-list (package-compute-transaction package-list (package-desc-reqs Donald On Apr 3, 2013, at 21:46, Stefan Monnier = wrote: >> * rinari requires: ruby-mode, inf-ruby, ruby-compilation, jump >> * jump requires: findr, inflections >> * ruby-compilation requires: inf-ruby >=20 >> Yet, the order of compilation appears to be: >=20 >> 1. inflections >> 2. findr >> 3. jump >> 4. ruby-compilation *fails missing inf-ruby* >=20 > Indeed, thanks. I installed the patch below which should fix > this problem. Note that a better fix would be to first download = packages, > the unpack packages, then autoload packages, then compile packages. > This way, ordering won't matter (including circular dependencies). >=20 >=20 > Stefan >=20 >=20 > =3D=3D=3D modified file 'lisp/emacs-lisp/package.el' > --- lisp/emacs-lisp/package.el 2013-04-04 01:51:33 +0000 > +++ lisp/emacs-lisp/package.el 2013-04-04 02:42:31 +0000 > @@ -811,7 +811,10 @@ > (package-version-join (package-desc-vers (cdr pkg-desc))))) > ;; Only add to the transaction if we don't already have it. > (unless (memq next-pkg package-list) > - (push next-pkg package-list)) > + (setq package-list > + ;; Move to front, so it gets installed early enough > + ;; (bug#14082). > + (cons next-pkg (delq next-pkg package-list)))) > (setq package-list > (package-compute-transaction package-list > (package-desc-reqs >=20