From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14086: 24.3.50; `substitute-command-keys': inappropriate "(that binding is currently shadowed by another mode)" Date: Sun, 4 Oct 2020 10:40:55 -0700 (PDT) Message-ID: <10de7711-3a84-4e13-ae38-be2b4c93e0fe@default> References: <0FF2F801815441C3B5385CE3202E16A0@us.oracle.com> <87364basd9.fsf@gnus.org> <875z7rdksc.fsf@web.de> <87a6x2t7nh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1076"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14086@debbugs.gnu.org To: Lars Ingebrigtsen , Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 19:42:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP81e-0000Bd-29 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 19:42:22 +0200 Original-Received: from localhost ([::1]:53554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP81d-00014G-00 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 13:42:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP81K-000144-QR for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 13:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kP81K-0005w1-ES for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 13:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kP81K-0005i0-Cu for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2020 13:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Oct 2020 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14086 X-GNU-PR-Package: emacs Original-Received: via spool by 14086-submit@debbugs.gnu.org id=B14086.160183326821881 (code B ref 14086); Sun, 04 Oct 2020 17:42:02 +0000 Original-Received: (at 14086) by debbugs.gnu.org; 4 Oct 2020 17:41:08 +0000 Original-Received: from localhost ([127.0.0.1]:46682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP80S-0005gr-IP for submit@debbugs.gnu.org; Sun, 04 Oct 2020 13:41:08 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:58916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP80Q-0005gG-L3 for 14086@debbugs.gnu.org; Sun, 04 Oct 2020 13:41:08 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 094HeAiJ099306; Sun, 4 Oct 2020 17:41:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=UrEla+fGxGJV/xPX8kHOFUnBFLDv9iVESXPpge/PMKY=; b=qxjf+7NsLHDKRULAhm1cjRyV9hDMUBK2Ht9nxtGdlaw8vbl9d8WAwrg0qdkWo+/9skTK ha9QpCCRE9tnz0F+/K/etXsmkuVQJC3083WLDOmNmTuQH/2HeGGP4qAUj6Fltkg9sbZZ JBHCsFcCARQ9bHY1FTNW2gjYF06T8qQH1lrtbX6xpHGClWx1dg3bJAwIBaAGPaR+cv5R oGJO5Z2Qc7XkId8rvLLN8Ny1VIE778SHGXkBCuG9nmL6XlMkVluMFJNWPwPQrHEMNwYm JRAycMYLXa9Iar/Ev9GycvcHON2/6+P7PPpAeOmOtpJOqHKISRLs0o5DMbWv5Kt46LGN mA== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 33xetak061-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 04 Oct 2020 17:41:00 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 094HexLn120529; Sun, 4 Oct 2020 17:40:59 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 33y32nw4uh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 04 Oct 2020 17:40:59 +0000 Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 094HeunE008312; Sun, 4 Oct 2020 17:40:57 GMT In-Reply-To: <87a6x2t7nh.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9764 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010040136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9764 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010040136 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189759 Archived-At: > > seems you treated this in 64d2e5a7a "Make shadowing warning in > > describe_map less confusing". Contended enough to close this report? >=20 > Yeah I think so; closing. I don't have a way of seeing the change you made. Can you please describe it here or include the patch here? Usually a patch is included in the bug thread, and it's then directly accessible from the thread on debugs.gnu.org. A reference like "64d2e5a7a" means nothing to me. Wrt the confusion that this bug is about: I think that one of the following things should happen, or something else that takes care of the same problem of listing the same key twice, and not together, and with no labeled grouping of the different keymaps (parent, child): * List the duplicate keys next to each other, with the unshadowed one first. That makes clear (a) that shadowing occurs, and (b) which shadows the other (given the note for the shadowed one). It doesn't, however, by itself make clear what shadowing is, and that there are multiple keymaps involved, with inheritance causing the "shadowing". OR ELSE * List the keys of a given keymap (parent or child) together, as is apparently (?) done now, but label them as such. IOW, label each of the keymap listings, and say which keymap's keys shadow the other's. And clearly label a shadowed key binding with the command that shadows it. And preferably include a link to that command's line in the listing (since it is far away, in the other keymap's listing). If neither of those, or similar, is done, then I don't think this bug should be closed.