From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#38013: [PATCH] Rectangular region selection with mouse Date: Sun, 3 Nov 2019 13:51:31 -0800 (PST) Message-ID: <10a910e6-6981-4f23-8e46-24db4ce3392f@default> References: <83lft0m3ug.fsf@gnu.org> <3541E0E8-9E33-4FBD-B0D9-DFF77C241F6F@acm.org> <83y2wzlorw.fsf@gnu.org> <83v9s3lo5f.fsf@gnu.org> <75EC4FBC-F636-4D75-BAC4-982D85188794@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="32511"; mail-complaints-to="usenet@blaine.gmane.org" To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 38013@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 03 22:52:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRNn7-0008P7-V1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Nov 2019 22:52:10 +0100 Original-Received: from localhost ([::1]:56548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRNn6-0001ya-Rx for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Nov 2019 16:52:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58017) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRNn1-0001yU-52 for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 16:52:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRNn0-0007lp-2d for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 16:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRNmz-0007kf-UF for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 16:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iRNmz-00068s-RB for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 16:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Nov 2019 21:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38013-submit@debbugs.gnu.org id=B38013.157281790323560 (code B ref 38013); Sun, 03 Nov 2019 21:52:01 +0000 Original-Received: (at 38013) by debbugs.gnu.org; 3 Nov 2019 21:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:35602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRNmg-00067w-PX for submit@debbugs.gnu.org; Sun, 03 Nov 2019 16:51:43 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:43922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRNmf-00067h-5L for 38013@debbugs.gnu.org; Sun, 03 Nov 2019 16:51:41 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA3LijJY064515; Sun, 3 Nov 2019 21:51:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=/uR4gVxsx0vuh+QU9tFjPQ382bT0WBNxYQ0bNrW0zS4=; b=R0nmZaV6rM885HRfTlnqVXuv0zYuy5zakBicAbQTCsaVHUhPZtBVgMc6Ezsv4+VRbVRl nQ59cu6tBjlpskIW98iuKUsOep1fmIZDKnAbiZuzn7m6D1w4o4D70F6akHzuxinlsrYu XfWFmYL4bawUHuV/XPkYUr2Mbjc1/d6HKOuhPONo51fjgKT3kEl0O25HV2UufklFZ/Bz jrqpBMNHLpByxSN3km/OKDROs6NPcuFoPtOFutA0kHUfsx+Ct6tWf4aVPebQSwMWjinx 9R9jDNIbpmxt2Z6I1ArCXvFE4FgGpKfZ1RoB9AbcF8GfizOTbVjttBrrAsk+4Pd7v+vf uQ== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2w117tm4wn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 03 Nov 2019 21:51:34 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA3LnW5S030657; Sun, 3 Nov 2019 21:51:33 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2w1ka8bv5s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 03 Nov 2019 21:51:33 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA3LpV7o000581; Sun, 3 Nov 2019 21:51:32 GMT In-Reply-To: <75EC4FBC-F636-4D75-BAC4-982D85188794@acm.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9430 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=960 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911030227 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9430 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911030227 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170905 Archived-At: Sorry, but I don't see why you did any of what you did that affects the secondary selection. Why all of that? Why not just continue to provide the same default mouse key bindings for it? It's always been easy for a user to change those default mouse key bindings. How are things easier for users after the proposed changes? Searching your patch for "second", it seems that the only changes affecting the secondary affect just the (mouse) key bindings for it. How is any of that related to rectangular region selection? I really don't see what has been gained by the changes that affect the secondary selection. Can you please explain? What's the aim - what's the problem that this is trying to solve? How about just removing all of the code in the patch that deals with the secondary selection? Is any of that needed, to provide mouse selection of a rectangular region? And I disagree with removing the longstanding default mouse key bindings for the secondary. You've done that in a roundabout way (defaulting a new user option to nil), but you've done it, AFAICT. [BTW, there's no need to use '(); just () suffices.]=20